Spec URL: http://beta.glwb.info/crystal/crystal.spec SRPM URL: http://beta.glwb.info/crystal/crystal-1.0.0-1.src.rpm Description: Crystal is a kwin window decoration theme, which offers you (pseudo) TRANSPARENT titlebar, buttons and borders. It also has some little usuability enhancements.
Not an official review as I'm not yet sponsored Mock Built for i386 development is successfull with cpio: crystal-1.0.0/client/<built-in>: No such file or directory cpio: crystal-1.0.0/client/config/<built-in>: No such file or directory MUST Items: - MUST: rpmlint shows no error - MUST: dist tag is present - MUST: The package is named according to the Package Naming Guidelines. - MUST: The spec file name matching the base package crystal, in the format crystal.spec - MUST: This package meets the Packaging Guidelines. - MUST: The package is licensed with an open-source compatible license GPL. - MUST: The License field in the package crystal.spec file matches the actual license file COPYING in tarball. - MUST: The sources used to build the package matches the upstream source, as provided in the spec URL. md5sum is correct. - MUST: This package owns all directories that it creates. - MUST: This package did not contain any duplicate files in the %files listing. - MUST: This package have a %clean section, which contains rm -rf $RPM_BUILD_ROOT. - MUST: This package used macros. - MUST: Document files are included like INSTALL README. - MUST: Package is calling ldconfig on postun post successfully. * Source URL is present. * BuildRoot is correct BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * BuildRequires is correct Not tested Desktop Icon but found its installed successfully.
> Not tested Desktop Icon but found its installed successfully. kcontrol > Appearance & Themes > Window Decoration Yes, Im ignoring on Rex's advice: https://www.redhat.com/archives/fedora-extras-list/2006-June/msg00911.html Hans, can you do the official review ?
This one's relatively simple, I can do it.
Thanks, Rex.
Offhand, looks pretty good, but... * you can omit %doc INSTALL * SOURCE Url doesn't work for me, but this does: http://www.kde-look.org/content/files/13969-crystal-1.0.0.tar.bz2 and it matches your source (md5sum-wise)
Updated: Spec URL: http://beta.glwb.info/crystal/crystal.spec SRPM URL: http://beta.glwb.info/crystal/crystal-1.0.0-2.src.rpm
(In reply to comment #2) > > Hans, can you do the official review ? > Nope sorry I'm rather busy at the moment. Besides that now that you're sponsored any FE contributer can do a review for you and its sortoff up to you to get yor packages reviewed. The best way to get your packages reviewed is to exchange reviews with someone. For example I see that Rex is reviewing this one for you, so you should review one of his packages in return. In the end you should review as many packages as you submit, even everybody only submits packages and doesn't review the system will bog down very quickly. Also now that you are sponsored you don't need to put me in the CC-list for every review request you submit.
New release: Spec URL: http://beta.glwb.info/crystal/crystal.spec SRPM URL: http://beta.glwb.info/crystal/crystal-1.0.1-1.src.rpm
Looks good, APPROVED.
HELP! I have the build failed on fc4 x86_64 and devel (fc6) x86_64 --------------------- Job failed on arch x86_64 Build logs may be found at http://buildsys.fedoraproject.org/logs/fedora-4-extras/11631-crystal-1.0.1-1.fc4/ ------------------------------------------------- checking for size_t... yes checking size of size_t... 8 checking for unsigned long... yes checking size of unsigned long... 8 checking sizeof size_t == sizeof unsigned long... yes checking crt_externs.h usability... no checking crt_externs.h presence... no checking for crt_externs.h... no checking for _NSGetEnviron... no checking for vsnprintf... yes checking for snprintf... yes checking for X... libraries /usr/X11R6/lib64, headers /usr/X11R6/include checking for IceConnectionNumber in -lICE... yes checking for libXext... yes checking for pthread_create in -lpthread... yes checking for extra includes... no checking for extra libs... no checking for libz... -lz checking for libpng... -lpng -lz -lm checking for libjpeg6b... no checking for libjpeg... -ljpeg checking for perl... /usr/bin/perl checking for Qt... configure: error: Qt (>= Qt 3.3) (library qt-mt) not found. Please check your installation! For more details about this problem, look at the end of config.log. Make sure that you have compiled Qt with thread support! error: Bad exit status from /var/tmp/rpm-tmp.5419 (%build) RPM build errors: Bad exit status from /var/tmp/rpm-tmp.5419 (%build)
I take it that the fc5/x86_64 build worked?
no, neither :(
Should I use qt-devel as BR ? http://www.uwsg.iu.edu/hypermail/linux/kernel/0409.0/1412.html
Adding BuildRequires: qt-devel kdelibs-devel wouldn't hurt, but it won't help, either. Here's the problem: export QTLIB=${QTDIR}/%{_lib} QTINC=${QTDIR}/include Either set it right, or don't set at all (qt package should set these correctly now). *Should* be: export QTLIB=${QTDIR}/lib QTINC=${QTDIR}/include Sorry I didn't catch that earlier (like in the review).
Package Change Request ====================== Package Name: crystal Owners: bnemec Taking over maintenance of this package per https://lists.fedoraproject.org/pipermail/devel/2014-June/199723.html
Complete.