Bug 1961945 - RHV should upgrade guest BIOS from i440fx chipset to q35 automatically when the cluster is set with the q35 chipset
Summary: RHV should upgrade guest BIOS from i440fx chipset to q35 automatically when t...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Virt
Version: 4.4.6.8
Hardware: x86_64
OS: Unspecified
unspecified
medium
Target Milestone: ovirt-4.4.7
: ---
Assignee: Lucia Jelinkova
QA Contact: mxie@redhat.com
URL:
Whiteboard: V2V_RHV_INT
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-05-19 06:13 UTC by mxie@redhat.com
Modified: 2021-07-08 14:15 UTC (History)
15 users (show)

Fixed In Version: ovirt-engine-4.4.7.6
Clone Of:
Environment:
Last Closed: 2021-07-08 14:15:37 UTC
oVirt Team: Virt
Embargoed:
pm-rhel: ovirt-4.4+
ahadas: blocker-


Attachments (Terms of Use)
guest-bios-i440fx-cluster-q35.png (221.49 KB, image/png)
2021-05-19 06:13 UTC, mxie@redhat.com
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 115450 0 master MERGED engine: update vmware vms to Q35 during rhv-upload 2021-06-29 08:16:10 UTC

Description mxie@redhat.com 2021-05-19 06:13:51 UTC
Created attachment 1784676 [details]
guest-bios-i440fx-cluster-q35.png

Description of problem:
RHV should upgrade guest BIOS from i440fx chipset to q35 automatically when the cluster is set with the q35 chipset

Version-Release number of selected component (if applicable):
rhv4.4.6.8-0.1.el8ev
virt-v2v-1.42.0-12.module+el8.5.0+10976+d40a93e9.x86_64

How reproducible:
100%

Steps to Reproduce:
1.Log into rhv4.4 web, the cluster has CPU Type Chipset/Firmware Type " Q35 Chipset with BIOS"
2.Convert a guest to rhv4.4 by v2v via rhv-upload on rhel8.5 v2v server, but guest got CPU Type Chipset/Firmware Type "I440FX Chipset with BIOS" after conversion,please refer to screenshot"guest-bios-i440fx-cluster-q35.png"
# virt-v2v -ic vpx://root.198.169/data/10.73.199.217/?no_verify=1 -it vddk -io vddk-libdir=/home/vddk7.0 -io  vddk-thumbprint=B5:52:1F:B4:21:09:45:24:51:32:56:F6:63:6A:93:5D:54:08:2D:78  -o rhv-upload -of qcow2 -oc https://dell-per740-22.lab.eng.pek2.redhat.com/ovirt-engine/api -ip /home/passwd -op /home/rhvpasswd  -os nfs_data -b ovirtmgmt  esx7.0-win2016-x86_64


Actual results:
RHV can't convert the BIOS of VMs to Q35 when the target cluster is set to Q35 if guest is converted from foreign hypervisor by rhel8 v2v via rhv-upload

Expected results:
RHV should upgrade guest BIOS from i440fx chipset to q35 when the cluster is set with the q35 chipset if guest is converted from foreign hypervisor by rhel8 v2v via rhv-upload

Additional info:
Can't reproduce the problem on rhv4.4.6.3-0.8 because rhv4.4.6.3 haven't added option 'Change existing VMs/Templates from I440fx to Q35 Chipset with BIOS' in cluster

Comment 1 RHEL Program Management 2021-06-23 13:45:55 UTC
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.

Comment 2 mxie@redhat.com 2021-06-23 13:49:00 UTC
The bug blocked some cases in virt-v2v auto testing, please help to modify the bug ASAP, thanks very much!

Comment 3 Arik 2021-06-23 14:07:25 UTC
But how come that it blocks some cases in the automation now? it never worked.. if those are new tests, can you disable them until this one is fixed?

Comment 4 Xiaodai Wang 2021-06-23 14:19:22 UTC
Based on the discussion in 1950881, the chipset should be set to Q35 when running
v2v+'-o rhv_upload', but now it always be set to BIOS which breaks our expected
result. This is not new tests.
Is there anything changed?

Comment 5 Arik 2021-06-23 15:36:05 UTC
Yes, the chipset should change to Q35.
We've made a lot of changes related to this so I can't rule out the possibility that it broke but I was under the impression that import-from-configuration, which is what we do for rhv_upload, didn't change..

Comment 9 mxie@redhat.com 2021-06-25 01:49:18 UTC
(In reply to Arik from comment #3)
> But how come that it blocks some cases in the automation now? it never
> worked.. if those are new tests, can you disable them until this one is
> fixed?

rhv4.4.6.3-0.8 will ignore the biostype setting of guest.ovf after v2v rhv-upload conversion, but rhv >=4.4.6.8-0.1 will not ignore the biostype setting of guest.ovf, so BIOS type of guest will be set according to the biostype setting of guest.ovf after v2v rhv-upload conversion, v2v auto tests will check the guest if BIOS is Q35 after v2v rhv-upload conversion, so the change of rhv >=4.4.6.8-0.1 will make v2v auto test cases failed.

Comment 10 Arik 2021-06-25 06:37:42 UTC
(In reply to mxie from comment #9)
> rhv4.4.6.3-0.8 will ignore the biostype setting of guest.ovf after v2v
> rhv-upload conversion, but rhv >=4.4.6.8-0.1 will not ignore the biostype
> setting of guest.ovf, so BIOS type of guest will be set according to the
> biostype setting of guest.ovf after v2v rhv-upload conversion, v2v auto
> tests will check the guest if BIOS is Q35 after v2v rhv-upload conversion,
> so the change of rhv >=4.4.6.8-0.1 will make v2v auto test cases failed.

I see, so with the previous implementation the chipset has changed to q35 and now the chipset remains i440fx.
I wouldn't use the term "ignore" because RHV doesn't ignore the specified bios type but may override it by "upgrading" the VM to q35 based on the target cluster and now also based on the operating system of the guest.

Comment 12 mxie@redhat.com 2021-07-08 09:34:19 UTC
Verify the bug with below builds:
rhv-4.4.7.6-0.11.el8ev
vdsm-4.40.70.6-1.el8ev.x86_64


Steps:
1.Log into rhv4.4 web, the cluster has CPU Type Chipset/Firmware Type " Q35 Chipset with BIOS"

2.Convert a guest to rhv4.4 by v2v via rhv-upload on rhel8.5 v2v server
# virt-v2v -ic vpx://root.198.169/data/10.73.199.217/?no_verify=1 -it vddk -io vddk-libdir=/home/vddk7.0.2 -io  vddk-thumbprint=B5:52:1F:B4:21:09:45:24:51:32:56:F6:63:6A:93:5D:54:08:2D:78  -o rhv-upload -of qcow2 -oc https://dell-per740-22.lab.eng.pek2.redhat.com/ovirt-engine/api -ip /home/passwd -op /home/rhvpasswd  -os nfs_data -b ovirtmgmt esx7.0-rhel7.9-rhel8.4-multiple_linux_os

3.Check guest on rhv4.4 web GUI after v2v conversion, guest gets CPU Type Chipset/Firmware Type "Q35 Chipset with BIOS" after conversion


Result:
   RHV-4.4.7.6 can upgrade guest BIOS to q35 automatically when the cluster is set with the q35 chipset, move the bug from ON_QA to VERIFIED

Comment 13 Sandro Bonazzola 2021-07-08 14:15:37 UTC
This bugzilla is included in oVirt 4.4.7 release, published on July 6th 2021.

Since the problem described in this bug report should be resolved in oVirt 4.4.7 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.