Document URL: Section Number and Name: Describe the issue: A cluster may have old and new templates provided by CNV(e.g after upgrade); older templates, if used by VMs, should be not be deleted from the cluster (bug 1929165). Suggestions for improvement: Additional information:
Add a known issue to the CNV 4.8 release notes: Caution: Do not delete CNV-provided templates. If you delete a template and edit the VM, then the edit fails because the template was deleted. $ oc edit vm rhelvm error: virtualmachines.kubevirt.io "rhelvm" could not be patched: admission webhook "virt-template-admission.kubevirt.io" denied the request: missing parent template (key=openshift/rhel8-server-tiny-v0.11.3) for rhelvm
Hi @rnetser- Please review draft text for 4.8 release notes Known Issues. We can't use CAUTION blocks unless there are steps in the documentation, so let me know if this is sufficient (assuming this is a bug that will be fixed). {VirtProductName} is our variable for the OV /CNV product. * Do not delete {VirtProductName}-provided templates. If you delete {VirtProductName}-provided templates and then edit the virtual machine created from the template, the edit fails because the template was deleted. Thanks, Bob
PR: https://github.com/openshift/openshift-docs/pull/34228 Doc preview: https://deploy-preview-34228--osdocs.netlify.app/openshift-enterprise/latest/virt/virt-4-8-release-notes.html#virt-4-8-known-issues
@rnetser - Sure, that sounds fine. How about this: Do not delete OpenShift Virtualization-provided templates in version 4.8 or later releases. If you delete OpenShift Virtualization-provided templates in version 4.8 or later releases, and then edit the virtual machine created from the template, the edit fails because the template was deleted. I am not sure what you mean by "reconsiled". I can explain that if you can define it for me... up to you if you think it's helpful. If you approve the above wording, I can get this bug fix merged Thursday July 8. Thanks for your help, Bob
@bgaydos By "reconciled" I mean that the SSP operator will re-create the templates. So the flow is as follows: If the user deletes a new template (i.e those provided with the current release), they will be re-created by the operator. If a user deletes an old template (i.e templates that were deployed as part of a previous release), those templates will not be re-created. Editing (or any update) of a VM using the old template will fail if this template was deleted. Do you think it's worth distiguishing between the 2 use cases?
Hi @rnetser, I'm going to say that more info is better, but I think it can be summarized. Here's what I suggest: If you delete OpenShift Virtualization-provided templates in version 4.8 or later, the templates are automatically recreated by the OpenShift Virtualization Operator. However, if you delete OpenShift Virtualization-provided templates created before version 4.8, any edit or update to a virtual machine referencing a deleted template will fail. Let me know if this works. Thanks Bob
rnetser can approve this version? ==== If you delete {VirtProductName}-provided templates in version 4.8 or later, the templates are automatically recreated by the {VirtProductName} Operator. However, if you delete {VirtProductName}-provided templates created before version 4.8, those earlier templates are not automatically recreated after deletion. As a result, any edit or update to a virtual machine referencing a deleted earlier template will fail. ==== I'd like to get this merged on Monday July 19. it's passed peer review so we just need your sign-off. Thanks, Bob
@bgaydos LGTM
Thanks @rnester Merged into 4.8 notes and DONE: https://github.com/openshift/openshift-docs/pull/34228
Corrected needsinfo target from "rnester" to "rnetser".