Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: http://nikolov.io/rpm-review/fillets-ng-data/fillets-ng-data.spec SRPM URL: http://nikolov.io/rpm-review/fillets-ng-data/fillets-ng-data-1.0.1-13.fc34.src.rpm Description: This is the package, containing the data files for the Fish Fillets game that was retired in Fedora 34. I want to unretire and maintain it. Review request for the main package is in rhbz#1955107. This data package compiles as is from the last git version, but I'm sending it for review, so it can be cleaned up and brought up to speed with the latest fedora packaging guidelines. Fedora Account System Username: nickysn
- Macro beginning with two underscores __ are reserved for RPM private use, please use actual binaries instead: %install mkdir -p %{buildroot}%{_datadir}/fillets-ng cp -a * %{buildroot}%{_datadir}/fillets-ng/ rm %{buildroot}%{_datadir}/fillets-ng/COPYING # Replace bundled copy of the fonts with symlinks to the original one rm -f %{buildroot}%{_datadir}/fillets-ng/font/copyright for FONTFILE in %{buildroot}%{_datadir}/fillets-ng/font/*.ttf; do rm -f ${FONTFILE} ln -s %{_datadir}/fonts/gnu-free/FreeSansBold.ttf ${FONTFILE} done - Notify upstream if not dead about their use of an obsolete FSF address fillets-ng-data.noarch: E: incorrect-fsf-address /usr/share/licenses/fillets-ng-data/COPYING - I don't think this is still necessary as it has not been packaged since Fedora 10 (!) Obsoletes: fillets-ng-data-cs <= 0.6.0 Package approved. Please fix the aforementioned issue before import. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GNU General Public License, Version 2", "GNU General Public License v2.0 or later", "Unknown or generated". 8943 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/fillets-ng-data/review-fillets-ng- data/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Avoid bundling fonts in non-fonts packages. Note: Package contains font files [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: fillets-ng-data-1.0.1-13.fc35.noarch.rpm fillets-ng-data-1.0.1-13.fc35.src.rpm fillets-ng-data.noarch: W: obsolete-not-provided fillets-ng-data-cs fillets-ng-data.noarch: W: dangling-symlink /usr/share/fillets-ng/font/font_console.ttf /usr/share/fonts/gnu-free/FreeSansBold.ttf fillets-ng-data.noarch: W: dangling-symlink /usr/share/fillets-ng/font/font_menu.ttf /usr/share/fonts/gnu-free/FreeSansBold.ttf fillets-ng-data.noarch: W: dangling-symlink /usr/share/fillets-ng/font/font_subtitle.ttf /usr/share/fonts/gnu-free/FreeSansBold.ttf fillets-ng-data.noarch: E: zero-length /usr/share/fillets-ng/script/rotate/dialogs_bg.lua fillets-ng-data.noarch: E: zero-length /usr/share/fillets-ng/script/rotate/dialogs_cs.lua fillets-ng-data.noarch: E: zero-length /usr/share/fillets-ng/script/rotate/dialogs_de.lua fillets-ng-data.noarch: E: zero-length /usr/share/fillets-ng/script/rotate/dialogs_es.lua fillets-ng-data.noarch: E: zero-length /usr/share/fillets-ng/script/rotate/dialogs_fr.lua fillets-ng-data.noarch: E: zero-length /usr/share/fillets-ng/script/rotate/dialogs_it.lua fillets-ng-data.noarch: E: zero-length /usr/share/fillets-ng/script/rotate/dialogs_nl.lua fillets-ng-data.noarch: E: zero-length /usr/share/fillets-ng/script/rotate/dialogs_pl.lua fillets-ng-data.noarch: E: zero-length /usr/share/fillets-ng/script/rotate/dialogs_ru.lua fillets-ng-data.noarch: E: zero-length /usr/share/fillets-ng/script/rotate/dialogs_sl.lua fillets-ng-data.noarch: E: zero-length /usr/share/fillets-ng/script/rotate/dialogs_sv.lua fillets-ng-data.noarch: E: incorrect-fsf-address /usr/share/licenses/fillets-ng-data/COPYING 2 packages and 0 specfiles checked; 12 errors, 4 warnings.
Small nitpick from me: > %{__ln_s} %{_datadir}/fonts/gnu-free/FreeSansBold.ttf ${FONTFILE} While I can't find any specific paragraph for this in the Packaging Guidelines, I believe it's recommended not to rely on hard-coded font paths, and instead use fontconfig to determine them. I'd look like this: > %global fontlist font(freesans) > BuildRequires: fontconfig > BuildRequires: %{fontlist} > Requires: %{fontlist} > ... > ln -s "$(fc-match -f '%%{file}' 'Free Sans:Bold')" "${FONTFILE}" For an example of this in action, you can check the opensurge package spec: https://src.fedoraproject.org/rpms/opensurge/raw/e9e580368df1227d965638ba1a5a08e49e21ac26/f/opensurge.spec
Ok, will apply the fontconfig change before package import as well. Thanks!
Closing this since the package was un-retired successfully. https://pagure.io/releng/issue/10125