Bug 196305 - [PATCH] Missing quoting in mkinitrd's emit_iscsi()
Summary: [PATCH] Missing quoting in mkinitrd's emit_iscsi()
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: mkinitrd
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Peter Jones
QA Contact: David Lawrence
URL:
Whiteboard:
Keywords: EasyFix
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2006-06-22 14:47 UTC by Robert Scheck
Modified: 2007-11-30 22:11 UTC (History)
0 users

(edit)
Clone Of:
(edit)
Last Closed: 2006-06-23 12:52:19 UTC


Attachments (Terms of Use)
Thanks to wwoods and Dyson pointing me to it :) (399 bytes, patch)
2006-06-22 15:34 UTC, Robert Scheck
no flags Details | Diff

Description Robert Scheck 2006-06-22 14:47:58 UTC
Description of problem:
$ rpm -ivh kernel-2.6.17-1.2293_FC6.i686.rpm
Vorbereiten...              ########################################### [100%]
   1:kernel                 ########################################### [100%]
cp: Aufruf von stat für »/sbin/iscsistart« nicht möglich: Datei oder Verzeichnis 
nicht gefunden
$

Sorry, error message is i18n, but:
$ ls -l /sbin/iscsistart
ls: /sbin/iscsistart: No such file or directory
$

Version-Release number of selected component (if applicable):
mkinitrd-5.0.43-1

How reproducible:
Everytime, see above.

Actual results:
mkinitrd tries to use /sbin/iscsistart without any conditionals.

Expected results:
At least, the use of /sbin/iscsistart should be conditional - not everybody
wants iSCSI support (SCSI over IP?)... ;-)

Comment 1 Robert Scheck 2006-06-22 15:34:46 UTC
Created attachment 131362 [details]
Thanks to wwoods and Dyson pointing me to it :)

$ /sbin/new-kernel-pkg -v --package kernel --mkinitrd --depmod --install
2.6.17-1.2293_FC6
initrdfile is /boot/initrd-2.6.17-1.2293_FC6.img
running depmod for 2.6.17-1.2293_FC6
creating initrd /boot/initrd-2.6.17-1.img using 2.6.17-1.2293_FC6
cp: Aufruf von stat für »/sbin/iscsistart« nicht möglich: Datei oder
Verzeichnis nicht gefunden
found /boot/initrd-2.6.17-1.2293_FC6.img and using it with grubby
adding 2.6.17-1.2293_FC6 to /boot/grub/grub.conf
/etc/lilo.conf does not exist, not running grubby
$

As far as I can see, no iSCSI was detected, otherwise there would have been a
"Found iscsi component $1" output, right? In assumption of this, I went through

mkinitrd code. For debugging, I put a 

    if [ -n ${iscsi_devs} ]; then
      echo "true";
      echo "x${iscsi_devs}x";
    fi

into emit_iscsi() which returned the following:

[...]
true
xx
[...]

Ahhhhhhh....please fix your faulty code soon! :-P

Comment 2 Robert Scheck 2006-06-23 12:52:19 UTC
Thanks Jeremy and Karsten for fixing it in 5.0.44-1 - closing now.


Note You need to log in before you can comment on or make changes to this bug.