Bug 196345 - rescue mode: add filesystem label to partition chooser
Summary: rescue mode: add filesystem label to partition chooser
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: 6
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Chris Lumens
QA Contact: Mike McLean
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2006-06-22 17:37 UTC by John Reiser
Modified: 2007-11-30 22:11 UTC (History)
0 users

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2006-07-07 17:58:14 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description John Reiser 2006-06-22 17:37:38 UTC
Description of problem: In rescue mode, the dialog box "System to Rescue" should
list the filesystem labels (if any) as well as the partitions.  Also, the text
"What partition holds the root ..." should read "Which partition hold the root
..." [a minor grammar correction.]


Version-Release number of selected component (if applicable):
anaconda-11.1.0.45-1.i386.rpm

How reproducible:
always

Steps to Reproduce:
1. "boot: linux rescue" on a aystem with more than one installed Fedora system
root partition.
2. Advance to the dialog box "System to Rescue"
3.
  
Actual results:
The partitions are listed only by name (hda3,hdb2, etc.)

Expected results:
The filesystem labels, if any, should appear in addition to the partition name.
   I often use tune2fs to set the ext3 label to be the release name or number. 
This helps me identify which system is which.

Additional info:

Comment 1 Jeremy Katz 2006-06-26 01:30:35 UTC
Seems reasonable

Comment 2 Chris Lumens 2006-06-26 17:46:13 UTC
Committed to Rawhide.  Please test with FC6 test 2.

Comment 3 John Reiser 2006-06-30 04:52:22 UTC
"rawhide report: 20060629 changes" says that anaconda-11.1.0.49-1 has the
change.  However, FC-development-i386-rescuecd.iso of 2006-06-29 with sha1sum 
de6e2ccb329759ebd7f20d659c4d6ead3c2fa424 still shows just the partition name
(such as "hda7") and no ext3 label (such as "/fc1" on my system.)

I'll test again at FC6test2, but I thought that "committed to Rawhide" plus
appearing the "rawhide report" meant that the changed version was supposed to be
available in the packaged rescuecd.

Comment 4 Chris Lumens 2006-07-05 20:16:07 UTC
Yes, this should be in there.  I will test this week and make sure it's working
as intended.

Comment 5 John Reiser 2006-07-06 15:25:40 UTC
Printing the ext3 filesystem label is missing from the "System to Rescue" dialog of
FC-development-i386-rescuecd.iso	2006-Jul-06 02:57:07 [PDT?]	78.7M
sha1sum=947bfe62f5a878911e64a8dba59e4a2f3bcb0669

I see a one-column list of the nine systems I have installed (hda7, hda8, hda9,
hda10, hda11, hda12, hdb7, hd10, hdb9 [yes, the last two partitions are not in
ascending cylinder order]) but no labels.

Comment 6 Chris Lumens 2006-07-07 16:59:29 UTC
Yeah, that patch was wrong.  Committing a new and tested patch that works for
both regular partitions and LVM.

Comment 7 John Reiser 2006-07-08 14:51:36 UTC
Confirmed: works for me in anaconda-11.1.0.54-1.



Note You need to log in before you can comment on or make changes to this bug.