Bug 1965709 - xgridloc doesn't start
Summary: xgridloc doesn't start
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: xgridloc
Version: 33
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Richard Shaw
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-05-28 20:48 UTC by Jaroslav Škarvada
Modified: 2021-07-07 17:52 UTC (History)
1 user (show)

Fixed In Version: xgridloc-1.8.2-32.fc35
Clone Of:
Environment:
Last Closed: 2021-07-07 17:06:49 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Proposed fix (2.60 KB, patch)
2021-05-29 13:11 UTC, Jaroslav Škarvada
no flags Details | Diff
SPEC changes (1.15 KB, patch)
2021-05-29 13:13 UTC, Jaroslav Škarvada
no flags Details | Diff

Description Jaroslav Škarvada 2021-05-28 20:48:52 UTC
Description of problem:
xgridloc doesn't start on f33

Version-Release number of selected component (if applicable):
xgridloc-1.8.2-30.fc33.x86_64

How reproducible:
Always

Steps to Reproduce:
1. xgridloc
2.
3.

Actual results:
Xgridloc: failed to add objects to builder:
Failed to open file “/home/yarda/.xgridloc/xgridloc.glade”: No such file or directory
Xgridloc: Listing Object Ids:
main_window
home_lon_deg
home_lon_min
home_lon_sec
home_lon_dir
home_lat_deg
home_lat_min
home_lat_sec
home_lat_dir
home_loc
remt_lon_deg
remt_lon_min
remt_lon_sec
remt_lon_dir
remt_lat_deg
remt_lat_min
remt_lat_sec
remt_lat_dir
remt_loc
bng_spath
dist_spath
short_label
bng_lpath
dist_lpath
long_label
clear
default_home
enable_xplanet
quit


Expected results:
xgridloc starts

Additional info:
$ rpm -qV xgridloc
<nothing>

Comment 1 Jaroslav Škarvada 2021-05-28 21:38:14 UTC
The problem seems to be caused by the no-home patch.

I think you should install the xgridloc.glade into /usr/share/xgridloc/ and patch line 72 of main.c to load it from there. It could fallback to the home. I think such patch should be sent upstream.

The similar thing should be probably also done with the xgridlocrc. It should be installed to /etc/xgridloc and the sources should be patched to try loading the config from the home and if it fails fallback to the /etc/xgridloc/xgridlocrc.

Comment 2 Jaroslav Škarvada 2021-05-28 21:39:57 UTC
(In reply to Jaroslav Škarvada from comment #1)
> The problem seems to be caused by the no-home patch.
> 
> I think you should install the xgridloc.glade into /usr/share/xgridloc/ and
> patch line 72 of main.c to load it from there. It could fallback to the
> home. I think such patch should be sent upstream.
> 
Or better try it to load the glade from the home and if it fails fallback to the system wide /usr/share/xgridloc/xgridloc.glade.

Comment 3 Jaroslav Škarvada 2021-05-29 13:11:51 UTC
Created attachment 1788018 [details]
Proposed fix

Maybe not the best solution, but it should work.

Also upstream could switch to the 'install' command and use parallel install (I used it for the files I am installing).

Comment 4 Jaroslav Škarvada 2021-05-29 13:13:23 UTC
Created attachment 1788019 [details]
SPEC changes

Comment 5 Jaroslav Škarvada 2021-07-03 00:32:25 UTC
Richard, what do you think about the attached patch? It works for me.

Comment 6 Richard Shaw 2021-07-03 13:16:24 UTC
I hate the way BZ handles patches/attachments, you have to download them when sometimes I just want to "view" them. I'll try to take a look but a PR would be much easier :)

Comment 7 Jaroslav Škarvada 2021-07-07 13:47:19 UTC
(In reply to Richard Shaw from comment #6)
> I hate the way BZ handles patches/attachments, you have to download them
> when sometimes I just want to "view" them. I'll try to take a look but a PR
> would be much easier :)

NP, I will create PR.

Comment 8 Jaroslav Škarvada 2021-07-07 14:27:42 UTC
(In reply to Jaroslav Škarvada from comment #7)
> (In reply to Richard Shaw from comment #6)
> > I hate the way BZ handles patches/attachments, you have to download them
> > when sometimes I just want to "view" them. I'll try to take a look but a PR
> > would be much easier :)
> 
> NP, I will create PR.

https://src.fedoraproject.org/rpms/xgridloc/pull-request/1

Comment 9 Fedora Update System 2021-07-07 17:05:50 UTC
FEDORA-2021-f4edf2ac5a has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-f4edf2ac5a

Comment 10 Fedora Update System 2021-07-07 17:06:49 UTC
FEDORA-2021-f4edf2ac5a has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Richard Shaw 2021-07-07 17:21:16 UTC
Packages are building and I'll submit an update for f33/f34.

BTW, are you interested in maintaining the package? I don't use it often but didn't want it to get retired.

Comment 12 Jaroslav Škarvada 2021-07-07 17:22:55 UTC
(In reply to Richard Shaw from comment #11)
> Packages are building and I'll submit an update for f33/f34.
> 
> BTW, are you interested in maintaining the package? I don't use it often but
> didn't want it to get retired.

Thanks, I use it quite regularly, so no problem to maintain / co-maintain.

Comment 13 Jaroslav Škarvada 2021-07-07 17:52:48 UTC
I also sent the patch upstream.


Note You need to log in before you can comment on or make changes to this bug.