Bug 1965711 - Review Request: rpg-cli - rpg-cli is a terminal game
Summary: Review Request: rpg-cli - rpg-cli is a terminal game
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-05-28 20:59 UTC by Rémi Lauzier
Modified: 2021-06-15 01:04 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-06-15 01:04:50 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Rémi Lauzier 2021-05-28 20:59:39 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/remilauzier/rpg-cli/fedora-rawhide-x86_64/02214981-rpg-cli/rpg-cli.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/remilauzier/rpg-cli/fedora-rawhide-x86_64/02214981-rpg-cli/rpg-cli-0.2.0-1.fc35.src.rpm
Description: rpg-cli is a bare-bones JRPG-inspired terminal game written in Rust.
Fedora Account System Username: remilauzier

Comment 1 Rémi Lauzier 2021-05-28 21:02:55 UTC
Compile in mock.
For information there is no crate for rpg-cli.
There another program in crates.io call rpg-cli that 
have no link with it.
I am not the upstream developer.

Comment 2 Robert-André Mauchin 🐧 2021-05-29 19:03:50 UTC
 - DO not repeat the name in the Summary:

Summary:        JRPG-inspired terminal game

 - Try to respect the Rust packaging convention:

%bcond_without check

%global crate rpg-cli

Name:           rust-%{crate}
Version:        0.2.0
Release:        1%{?dist}
Summary:        JRPG-inspired terminal game

# Upstream license specification: MIT
License:        MIT
URL:            https://github.com/facundoolano/rpg-cli
Source:         %{url}/archive/refs/tags/%{version}.tar.gz

ExclusiveArch:  %{rust_arches}
%if %{__cargo_skip_build}
BuildArch:      noarch
%endif

BuildRequires:  rust-packaging

%global _description %{expand:
rpg-cli is a bare-bones JRPG-inspired terminal game written in Rust.}

%description %{_description}

%if ! %{__cargo_skip_build}
%package     -n %{crate}
Summary:        %{summary}

%description -n %{crate} %{_description}

%files       -n %{crate}
%doc README.md
%license LICENSE
%{_bindir}/rpg-cli
%endif

%prep
%autosetup -n %{crate}-%{version_no_tilde} -p1
%cargo_prep

%generate_buildrequires
%cargo_generate_buildrequires

%build
%cargo_build

%install
%cargo_install

%if %{with check}
%check
%cargo_test
%endif

%changelog
* Fri May 28 15:50:45 EDT 2021 Rémi Lauzier <remilauzier> - 0.2.0-1
- Initial package

Comment 3 Rémi Lauzier 2021-05-29 20:21:41 UTC
There is a crate on crates.io that have the same name so if somebody want to package it for fedora, would it be preferable to call this
program only rpg-cli. or is it first arrive, first taken.

Comment 5 Robert-André Mauchin 🐧 2021-05-29 21:18:45 UTC
Ha yes, disregard my comment then.

PAckage approved as initially proposed.

Comment 6 Jens Petersen 2021-05-31 02:41:52 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rpg-cli

Comment 7 Jens Petersen 2021-05-31 02:46:36 UTC
I suggest not to delete the older copr builds since it breaks the urls here.

https://download.copr.fedorainfracloud.org/results/remilauzier/rpg-cli/fedora-rawhide-x86_64/02215449-rpg-cli/rpg-cli.spec

Comment 8 Fedora Update System 2021-05-31 18:30:17 UTC
FEDORA-2021-cc184eb027 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-cc184eb027

Comment 9 Fedora Update System 2021-06-01 01:43:38 UTC
FEDORA-2021-cc184eb027 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-cc184eb027 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-cc184eb027

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 10 Fedora Update System 2021-06-07 01:29:41 UTC
FEDORA-2021-24f3bb34b5 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-24f3bb34b5`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-24f3bb34b5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2021-06-15 01:04:50 UTC
FEDORA-2021-24f3bb34b5 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.