Spec URL: http://www.dangerouslyinc.com/~bowes/fe/vobject.spec SRPM URL: http://www.dangerouslyinc.com/~bowes/fe/vobject-0.3.0-1.src.rpm Description: VObject is intended to be a full featured python library for parsing and generating vCard and vCalendar files.
Not an official review as I'm not yet sponsored Mock build for development i386 is suceesfull with some warnings + /usr/bin/python setup.py build /usr/lib/python2.4/distutils/dist.py:236: UserWarning: Unknown distribution option: 'zip_safe' warnings.warn(msg) /usr/lib/python2.4/distutils/dist.py:236: UserWarning: Unknown distribution option: 'install_requires' warnings.warn(msg) MUST Items: - MUST: rpmlint shows no error on i386 - MUST: dist tag is present - MUST: The package is named according to the Package Naming Guidelines. - MUST: The spec file name matching the base package vobject, in the format vobject.spec - MUST: This package meets the Packaging Guidelines. - MUST: The package is licensed with an open-source compatible license Apache Software License. - MUST: The License field in the package vobject.spec file did not match any file in tarball. - MUST: The sources used to build the package matches the upstream source, as provided in the spec URL. md5sum is correct. - MUST: This package owns all directories that it creates. - MUST: This package did not contain any duplicate files in the %files listing. - MUST: This package have a %clean section, which contains rm -rf $RPM_BUILD_ROOT. - MUST: This package used macros. - MUST: Document files are included like README.txt * Source URL is present and working. * BuildRoot is correct BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * BuildRequires is correct What you Need:- * You dont need to have Requires: python-abi = %(%{__python} -c "import sys ; print sys.version[:3]") as this is only for rpms targetting for FC3 or prior. * Add License file in tarball if you can alter the tarball contents.
The package should probably be named python-vobject as well.
Updated locations: Spec URL: http://www.dangerouslyinc.com/~bowes/fe/python-vobject.spec SRPM URL: http://www.dangerouslyinc.com/~bowes/fe/python-vobject-0.3.0-1.src.rpm Thanks for the feedback, guys! I've: * Renamed the package to python-vobject * Removed the python-abi requires * Removed the unused python-sitearch macro * Removed some comments left over from the template I didn't add in the license file, since the released version does not package it in the tarball. However, the current sources in svn do have a LICENSE file, so it should be in the next release.
APPROVED, based upon the review by Parag AN and the updated package. For furture reference, please bump the release each time you update the package.
Thanks for your help, everyone!
Package Change Request ====================== Package Name: python-vobject Updated Fedora Owners: jbowes, dgoodwin
done
Package Change Request ====================== Package Name: python-vobject New Branches: el6 Owners: sharkcz
Need an ack here from the Fedora owners.
Hm, I got no response on email sent 2 weeks ago ... Let's wait a bit if James shows here.
Can you please set fedora-cvs flag again when you are ready?
ACK. sorry.
Git done (by process-git-requests).