Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1966122

Summary: [RFE] - PMDA ds389 to provide metrics for replication
Product: Red Hat Enterprise Linux 8 Reporter: Raul Mahiques <rmahique>
Component: pcpAssignee: Raul Mahiques <rmahique>
Status: CLOSED ERRATA QA Contact: Jan Kurik <jkurik>
Severity: unspecified Docs Contact: Apurva Bhide <abhide>
Priority: unspecified    
Version: 8.4CC: agerstmayr, jkurik, myllynen, nathans
Target Milestone: betaKeywords: FutureFeature, Triaged
Target Release: 8.6Flags: pm-rhel: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: pcp-5.3.4-1.el8 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2022-05-10 13:30:36 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Raul Mahiques 2021-05-31 12:27:36 UTC
Description of problem:
The current version doesn't monitor replication and metrics are coded in the script, in order to have more flexibility and be able to offer metrics about aspects such as replication status and others i have made some changes which can be found in the following PR:
https://github.com/performancecopilot/pcp/pull/1310

With these changes the user can define extra metrics via the configuration file.


Version-Release number of selected component (if applicable):
RHEL8


Additional info:
PR provided:
https://github.com/performancecopilot/pcp/pull/1310

Comment 9 Jan Kurik 2021-09-16 08:39:48 UTC
Marking as FailedQA for the following reasons:

1) Registration of ds389 pmda does not work due to syntax errors in pmdads389.pl
- Lines 265 and 267 of the pmdads389.pl contain misspelled keywords 'elif' instead of 'elsif'.

2) In previous versions of ds389 pmda it was possible to register the pmda even when the server was not up/running. Now, the registration is possible only with running server. I am considering this as a regression.

Comment 10 Nathan Scott 2021-09-16 23:22:09 UTC
Thanks Jan, good pickups - Raul and/or Marko, are you guys able to look into these issues?

Longer term could be a candidate PMDA for python conversion if that's your native language.

cheers.

Comment 11 Marko Myllynen 2021-09-17 06:44:38 UTC
Unfortunately I don't have access to a suitable test environment and I'm too low on spare cycles to set one up myself for the time being.

Raul?

Comment 12 Jan Kurik 2021-09-28 06:12:17 UTC
I created an upstream pull request https://github.com/performancecopilot/pcp/pull/1422 to fix the syntax error in pmdads389.pl .
However as I am not a 'perl guy' the point 2 from the comment #9 still remains.

Comment 13 Nathan Scott 2021-09-30 02:54:35 UTC
Thanks Jan - we'll look into part #2 soon.  Your initial fix is upstream ...

commit ef4468872a5bf9ce944f10d557064f4f7110d45f
Author: Jan Kurik <jkurik>
Date:   Tue Sep 28 08:06:34 2021 +0200

    Fix of a syntax error in pmdads389.pl

Comment 14 Nathan Scott 2021-10-06 00:58:00 UTC
Part #2 now fixed upstream...

commit fabe05a9fc4d1779882edb60a7450cc492c0daaa
Author: Nathan Scott <nathans>
Date:   Wed Oct 6 11:56:32 2021 +1100

    pmdads389: allow installation when ds389 server is down
    
    Recent extensions to the ds389 PMDA have resulted in an
    accidental failure to install when the server is not up
    (picked up by QA).  This fixes that, and also reduces a
    bit of log noise in this (expected sometimes) scenario.
    
    Related to Red Hat BZ #1966122

Comment 18 errata-xmlrpc 2022-05-10 13:30:36 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (pcp bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2022:1765