Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1966177

Summary:	[CBT][RFE] Unable to delete a vm checkpoint if vm has poweroff state
Product:	[oVirt] ovirt-engine	Reporter:	Yury.Panchenko
Component:	BLL.Storage	Assignee:	Eyal Shenitzky <eshenitz>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Amit Sharir <asharir>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.4.5.11	CC:	bugs, dfodor, eshames, eshenitz, nsoffer, pchavva, sfishbai, sshmulev, Yury.Panchenko
Target Milestone:	ovirt-4.4.7	Keywords:	FutureFeature, ZStream
Target Release:	---	Flags:	sbonazzo: ovirt-4.4? sshmulev: testing_plan_complete+ pm-rhel: planning_ack? pm-rhel: devel_ack+ pm-rhel: testing_ack+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Enhancement
Doc Text:	Feature: VM checkpoint can be removed while the VM is in a 'DOWN' state. Reason: Until now, the VM checkpoint that was taken during a VM backup process can be removed only when the VM is running. This fix provides the ability to remove the VM checkpoint when the VM isn't running using the same API - DELETE /vms/123/checkpoints/456/ Result: VM checkpoint can be removed when the VM is 'UP' or 'DOWN' using the same API.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-07-06 07:28:29 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Yury.Panchenko 2021-05-31 15:44:02 UTC

Description of problem:
After sucessfull backup, I want to delete older checkpoints.
But if vm's in poweroff state, i can't do that.


Version-Release number of selected component (if applicable):
ovirt-4.4.5

How reproducible:
poweroff vm and try to delete checkpoint

Actual results:
Checkpoint deletion failed

Expected results:
Checkpoint sucessfully deleted

Comment 1 Eyal Shenitzky 2021-06-01 05:28:45 UTC

Will be fixed as part of bug 1952577.

Comment 2 Amit Sharir 2021-07-01 09:45:53 UTC

Version: 
ovirt-engine-4.4.7.5-0.9.el8ev.noarch
rhv-release-4.4.7-5-001.noarch
redhat-release-8.4-0.6.el8.x86_64
redhat-release-eula-8.4-0.6.el8.x86_64
vdsm-4.40.70.5-1.el8ev.x86_64

Verification steps:
1. I created a VM and disk (incremental backup enabled).
2. Did a successful backup (including finalization) - using API calls.
3. Powered off the VM. 
4. Deleted checkpoint using SDK - {root@storage-{name}-vdsm1 examples]# python3 remove_checkpoint.py c1e713a1-ad3c-4f6a-9c62-29c754d12fb2 083235e9-1194-4050-a5db-3d8e7f47a4b8 -c engine}. 

Verification procedure:

1. After step 2 I used an API call to see the relevant checkpoint {api call : {{engine}}vms/c1e713a1-ad3c-4f6a-9c62-29c754d12fb2/checkpoints}
I saw the relevant checkpoint is: 
 
<checkpoint href="/ovirt-engine/api/vms/c1e713a1-ad3c-4f6a-9c62-29c754d12fb2/checkpoints/083235e9-1194-4050-a5db-3d8e7f47a4b8" id="083235e9-1194-4050-a5db-3d8e7f47a4b8">

2. Then a proceeded and completed step 3. 

3. After completing step 4 I got the following:

[ 0.0 ] Removing VM 'c1e713a1-ad3c-4f6a-9c62-29c754d12fb2' checkpoint '083235e9-1194-4050-a5db-3d8e7f47a4b8'
[ 0.5 ] Checkpoint '083235e9-1194-4050-a5db-3d8e7f47a4b8' removed successfully

4. I also double-checked with an additional API call that the checkpoint was deleted and indeed got an empty checkpoint list:

<checkpoints/>

Verification conclusions:
The expected output matched the actual output.
The total flow mentioned was done with no errors/unexpected logs.
I was able to delete checkpoints when the VM was powered off.  


Bug verified.

Comment 3 Sandro Bonazzola 2021-07-06 07:28:29 UTC

This bugzilla is included in oVirt 4.4.7 release, published on July 6th 2021.

Since the problem described in this bug report should be resolved in oVirt 4.4.7 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.