Bug 1966177 - [CBT][RFE] Unable to delete a vm checkpoint if vm has poweroff state
Summary: [CBT][RFE] Unable to delete a vm checkpoint if vm has poweroff state
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Storage
Version: 4.4.5.11
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ovirt-4.4.7
: ---
Assignee: Eyal Shenitzky
QA Contact: Amit Sharir
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-05-31 15:44 UTC by Yury.Panchenko
Modified: 2022-02-01 08:45 UTC (History)
9 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-07-06 07:28:29 UTC
oVirt Team: Storage
Embargoed:
sbonazzo: ovirt-4.4?
sshmulev: testing_plan_complete+
pm-rhel: planning_ack?
pm-rhel: devel_ack+
pm-rhel: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 114913 0 master MERGED remove_bitmap_test.py: add tests for bitmap removal 2021-06-16 11:22:06 UTC
oVirt gerrit 114914 0 master ABANDONED remove_bitmap.py: remove the bitmap from all the volumes in the chain 2021-06-07 04:32:00 UTC
oVirt gerrit 114915 0 master MERGED caps.py: add support for bitmap removal 2021-06-16 11:22:14 UTC
oVirt gerrit 114943 0 master MERGED core: add clear_bitmaps_enabled field to VDS 2021-06-23 11:55:18 UTC
oVirt gerrit 114944 0 master MERGED core: introduce RemoveVolumeBitmapVDSCommand 2021-06-22 14:50:59 UTC
oVirt gerrit 114945 0 master MERGED core: introduce RemoveVolumeBitmapCommand 2021-06-22 14:51:03 UTC
oVirt gerrit 114946 0 master MERGED core: allow removing a VM checkpoint for non-running VMs 2021-06-22 14:51:09 UTC
oVirt gerrit 115053 0 master ABANDONED volume_info.py: allow lock all volume chain 2021-06-07 04:31:54 UTC

Description Yury.Panchenko 2021-05-31 15:44:02 UTC
Description of problem:
After sucessfull backup, I want to delete older checkpoints.
But if vm's in poweroff state, i can't do that.


Version-Release number of selected component (if applicable):
ovirt-4.4.5

How reproducible:
poweroff vm and try to delete checkpoint

Actual results:
Checkpoint deletion failed

Expected results:
Checkpoint sucessfully deleted

Comment 1 Eyal Shenitzky 2021-06-01 05:28:45 UTC
Will be fixed as part of bug 1952577.

Comment 2 Amit Sharir 2021-07-01 09:45:53 UTC
Version: 
ovirt-engine-4.4.7.5-0.9.el8ev.noarch
rhv-release-4.4.7-5-001.noarch
redhat-release-8.4-0.6.el8.x86_64
redhat-release-eula-8.4-0.6.el8.x86_64
vdsm-4.40.70.5-1.el8ev.x86_64

Verification steps:
1. I created a VM and disk (incremental backup enabled).
2. Did a successful backup (including finalization) - using API calls.
3. Powered off the VM. 
4. Deleted checkpoint using SDK - {root@storage-{name}-vdsm1 examples]# python3 remove_checkpoint.py c1e713a1-ad3c-4f6a-9c62-29c754d12fb2 083235e9-1194-4050-a5db-3d8e7f47a4b8 -c engine}. 

Verification procedure:

1. After step 2 I used an API call to see the relevant checkpoint {api call : {{engine}}vms/c1e713a1-ad3c-4f6a-9c62-29c754d12fb2/checkpoints}
I saw the relevant checkpoint is: 
 
<checkpoint href="/ovirt-engine/api/vms/c1e713a1-ad3c-4f6a-9c62-29c754d12fb2/checkpoints/083235e9-1194-4050-a5db-3d8e7f47a4b8" id="083235e9-1194-4050-a5db-3d8e7f47a4b8">

2. Then a proceeded and completed step 3. 

3. After completing step 4 I got the following:

[ 0.0 ] Removing VM 'c1e713a1-ad3c-4f6a-9c62-29c754d12fb2' checkpoint '083235e9-1194-4050-a5db-3d8e7f47a4b8'
[ 0.5 ] Checkpoint '083235e9-1194-4050-a5db-3d8e7f47a4b8' removed successfully

4. I also double-checked with an additional API call that the checkpoint was deleted and indeed got an empty checkpoint list:

<checkpoints/>

Verification conclusions:
The expected output matched the actual output.
The total flow mentioned was done with no errors/unexpected logs.
I was able to delete checkpoints when the VM was powered off.  


Bug verified.

Comment 3 Sandro Bonazzola 2021-07-06 07:28:29 UTC
This bugzilla is included in oVirt 4.4.7 release, published on July 6th 2021.

Since the problem described in this bug report should be resolved in oVirt 4.4.7 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.