Red Hat Bugzilla – Bug 196620
Review Request: perl-Algorithm-Annotate - represent a series of changes in annotate form
Last modified: 2008-06-12 13:34:21 EDT
Spec URL: http://znark.com/fedora/perl-Algorithm-Annotate.spec
SRPM URL: http://znark.com/fedora/perl-Algorithm-Annotate-0.10-1.src.rpm
Description: generates a list that is useful for generating output simliar to cvs annotate.
It is required by perl-SVK.
Several mirror issues:
# rpmlint perl-Algorithm-Annotate-0.10-1.fc5.noarch.rpm
W: perl-Algorithm-Annotate summary-not-capitalized represent a series of changes
in annotate form
W: perl-Algorithm-Annotate spelling-error-in-description simliar similar
W: perl-Algorithm-Annotate invalid-license CHECK(GPL or Artistic)
* Empty %doc.
* Superfluous requires:
Requires: perl(Algorithm::Diff) >= 1.15
Seems as if you missed to manually edit a generated spec file ;)
I fixed the warnings. There are no doc files included beyond the man page. The
META.yml specifies a version for Algorithm::Diff so a versioned dependency is
proper. Since only a newer version is available, the version probably doesn't
(In reply to comment #2)
> META.yml specifies a version for Algorithm::Diff so a versioned dependency
The actual files contain no versioned dependency.
> Since only a newer version is available, the version probably doesn't
Exactly. That's why I consider it superfluous.
It's worse than superfluous. You get this in the dependency list:
perl(Algorithm::Diff) >= 1.15
I have no problem with you specifying a specific version, although as far as I
can tell the earliest version that was ever in Extras was 1.19 so you shouldn't
need to worry. If you really want to, however, you _must_ filter the
unversioned dependency generated by RPM. Let me know if you need help doing this.
The package does build in mock; rpmlint has this to day:
W: perl-Algorithm-Annotate incoherent-version-in-changelog 0.10-2 0.10-3.fc6
You neglected to add a changelog entry for the last version bump.
Also, your %doc tag has no files. I understand that there are none to ship, so
you should just remove it.
So I see three blockers.
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible. License text not included upstream.
* source files match upstream:
* latest version is being packaged.
* BuildRequires are proper.
* package builds in mock (development, x86_64).
* rpmlint is silent.
X final requires list has a duplicate entry:
perl(Algorithm::Annotate) = 0.10
perl-Algorithm-Annotate = 0.10-3.fc6
X perl(Algorithm::Diff) >= 1.15
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass:
All tests successful.
Files=1, Tests=3, 0 wallclock secs ( 0.02 cusr + 0.02 csys = 0.04 CPU)
* no scriptlets present.
* code, not content.
X no documentation, but empty %doc tag.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
Three blockers are fixed:
No more versioned Algorithm::Diff dependency.
No empty %doc tag.
Changelog entries include versions.
Built for devel.
Package Change Request
Package Name: perl-Algorithm-Annotate
New Branches: EL-4 EL-5
Kevin -- I see this is closed, but CPAN carries this as license 'Unknown' at one
point, and Artistic down in the footer to the POD explosion sub-page
Is this a problem?
At the bottom of the POD you see:
Copyright 2003 by Chia-liang Kao <email@example.com>.
This program is free software; you can redistribute it and/or modify it under
the same terms as Perl itself.
This is "GPLv2+ or Artistic" which is valid for software in Fedora.