Bug 1966387 - Review Request: rust-cloudflare-zlib-sys - Cloudflare fork of zlib with massive performance improvements
Summary: Review Request: rust-cloudflare-zlib-sys - Cloudflare fork of zlib with massi...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1966386
TreeView+ depends on / blocked
 
Reported: 2021-06-01 03:57 UTC by Rémi Lauzier
Modified: 2021-06-16 20:47 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-06-16 20:47:03 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+

Attachments (Terms of Use)

Description Rémi Lauzier 2021-06-01 03:57:50 UTC 
Spec URL: https://download.copr.fedorainfracloud.org/results/remilauzier/rust-oxipng/fedora-rawhide-x86_64/02219518-rust-cloudflare-zlib-sys/rust-cloudflare-zlib-sys.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/remilauzier/rust-oxipng/fedora-rawhide-x86_64/02219518-rust-cloudflare-zlib-sys/rust-cloudflare-zlib-sys-0.3.0-1.fc35.src.rpm
Description: Cloudflare fork of zlib with massive performance improvements
Fedora Account System Username: remilauzier
Comment 1 Rémi Lauzier 2021-06-01 04:36:32 UTC 
The readme file include a part of the license text, so should i include the readme in %license, or should i contact upstream to seperate the file?
Comment 2 Robert-André Mauchin 🐧 2021-06-05 16:55:10 UTC 
 - For the license do something like this:

sed -e '0,/^## License/d' README.md > LICENSE

and include the resulting license file.

 - Ideally this should be unbundled too but it's not trivial and it would conflict with existing zlib library in Fedora.

 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.
Comment 3 Rémi Lauzier 2021-06-05 17:28:53 UTC 
Done

https://download.copr.fedorainfracloud.org/results/remilauzier/rust-oxipng/fedora-rawhide-x86_64/02232755-rust-cloudflare-zlib-sys/rust-cloudflare-zlib-sys.spec
https://download.copr.fedorainfracloud.org/results/remilauzier/rust-oxipng/fedora-rawhide-x86_64/02232755-rust-cloudflare-zlib-sys/rust-cloudflare-zlib-sys-0.3.0-1.fc35.src.rpm
Comment 4 Gwyn Ciesla 2021-06-07 13:33:27 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cloudflare-zlib-sys
Comment 5 Fedora Update System 2021-06-07 16:13:03 UTC 
FEDORA-2021-56b69e2f64 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-56b69e2f64
Comment 6 Fedora Update System 2021-06-09 01:16:41 UTC 
FEDORA-2021-56b69e2f64 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-56b69e2f64 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-56b69e2f64

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 7 Fedora Update System 2021-06-16 20:47:03 UTC 
FEDORA-2021-56b69e2f64 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.