Bug 1966392 - Review Request: rust-libdeflate-sys - Bindings to libdeflate for DEFLATE (de)compression
Summary: Review Request: rust-libdeflate-sys - Bindings to libdeflate for DEFLATE (de)...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1966388
TreeView+ depends on / blocked
 
Reported: 2021-06-01 04:03 UTC by Rémi Lauzier
Modified: 2021-06-16 20:48 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-06-16 20:48:05 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Rémi Lauzier 2021-06-01 04:03:16 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/remilauzier/rust-oxipng/fedora-rawhide-x86_64/02220394-rust-libdeflate-sys/rust-libdeflate-sys.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/remilauzier/rust-oxipng/fedora-rawhide-x86_64/02220394-rust-libdeflate-sys/rust-libdeflate-sys-0.7.1-1.fc35.src.rpm
Description: Bindings to libdeflate for DEFLATE (de)compression exposed as non-streaming buffer operations. Contains bindings for raw deflate, zlib, and gzip data. 
Fedora Account System Username: remilauzier

Comment 2 Robert-André Mauchin 🐧 2021-06-05 16:40:35 UTC
 - It would be nice to unbundle and package libdeflate, although it doesn't seem trivial.

 - The bundled libdeflate is MIT licensed

# Upstream license specification: Apache-2.0
³ libdeflate: MIT
License:        ASL 2.0 and MIT


 - And you need to add the license file to %license:

%files          devel
%doc README.md
%license LICENSE libdeflate/COPYING
%{cargo_registry}/%{crate}-%{version_no_tilde}/

 - You need to add a bundled Provides

Provides: bundled(libdeflate) = 1.7-1.20201124git4a0bb73

 - Simplify the summary:

rust-libdeflate-sys-devel.noarch: E: summary-too-long C Bindings to libdeflate for DEFLATE (de)compression exposed as non-streaming buffer operations

 - License ok
 - Latest version packaged
 - Builds in mock

Comment 4 Robert-André Mauchin 🐧 2021-06-06 14:09:15 UTC
Package approved.

Comment 5 Gwyn Ciesla 2021-06-07 13:40:13 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-libdeflate-sys

Comment 6 Fedora Update System 2021-06-07 19:30:57 UTC
FEDORA-2021-eafd94e9a0 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-eafd94e9a0

Comment 7 Fedora Update System 2021-06-09 01:16:59 UTC
FEDORA-2021-eafd94e9a0 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-eafd94e9a0 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-eafd94e9a0

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2021-06-16 20:48:05 UTC
FEDORA-2021-eafd94e9a0 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.