Bug 1966675 - Admin console string updates
Summary: Admin console string updates
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 4.8
Hardware: Unspecified
OS: Unspecified
Target Milestone: ---
: 4.8.0
Assignee: Kim Dobestein
QA Contact: Siva Reddy
Depends On:
TreeView+ depends on / blocked
Reported: 2021-06-01 16:18 UTC by ralpert
Modified: 2021-07-27 23:11 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Last Closed: 2021-07-27 23:10:52 UTC
Target Upstream Version:

Attachments (Terms of Use)
the error text verbiage (273.38 KB, image/png)
2021-06-11 14:24 UTC, Siva Reddy
no flags Details
ImageStream word consistency (69.11 KB, image/png)
2021-06-11 14:25 UTC, Siva Reddy
no flags Details

System ID Private Priority Status Summary Last Updated
Github openshift console pull 9137 0 None open Bug 1966675: Update Image Stream to ImageStream 2021-06-03 16:16:01 UTC
Red Hat Product Errata RHSA-2021:2438 0 None None None 2021-07-27 23:11:08 UTC

Description ralpert 2021-06-01 16:18:58 UTC
Description of problem:
On review of the strings sent over for translation from Sprint 201, we found some issues:
* All uses of "Image Stream" in public.json should be updated to "ImageStream" for consistency
* "Are you sure you want to remove volume <2>{volume.name}</2> from <5>{kind.label}</5>: <7>{resource.metadata.name}</7>?" in public.json needs to be verified in the UI. Typically you need to use double brackets to get the data to show up. Otherwise you'll literally just see "volume.name," etc.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. Look at public.json/the code.

Actual results:
Keys require update in code.

Expected results:
Public.json contains correct keys.

Additional info:

Comment 1 Kim Dobestein 2021-06-03 16:12:25 UTC
A PR will be coming soon for the first bullet point.

Had a chance to look at the issue raised in the second bullet point - "Are you sure you want to remove volume <2>{volume.name}</2> from <5>{kind.label}</5>: <7>{resource.metadata.name}</7>?".  I believe this is working correctly in the UI.  This is called on the remove-volume-modal.tsx file which is only called by the volumes-table.tsx file.  The volumes table is called in numerous places in the app, but here is the easiest way to get to it:
  1. Click on Workloads > Deployments
  2. Click on a deployment 
  3. On the deployment details page, scroll down to the "Volumes" table.
  4. Click on one of the vertical ellipsis
  5. Click on "Remove volume"
  6. Verify text in the confirmation modal is correct.

Comment 3 Siva Reddy 2021-06-11 14:24:32 UTC
Created attachment 1790243 [details]
the error text verbiage

Comment 4 Siva Reddy 2021-06-11 14:25:08 UTC
Created attachment 1790244 [details]
ImageStream word consistency


Steps to verify:
 1. git clone the repo and checked the file in the code and verified the text is "ImageStreams"
 2. Login to console 
 3. Check all the places where the text is displayed for example
     and the child pages from here

All instances have "ImageStreams" instead of "Image streams"

attached screenshot

Also verified the error text for volumes - attached screen shot for it too.

Comment 7 errata-xmlrpc 2021-07-27 23:10:52 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.