Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1966725

Summary:	OCP 4.8: Node Feature Discovery (NFD) CSV nfd.v4.8.0.clusterserviceversion.yaml has alm-examples configData section in workerConfig all commented out, leading to mislabeling
Product:	OpenShift Container Platform	Reporter:	Walid A. <wabouham>
Component:	Node Feature Discovery Operator	Assignee:	Carlos Eduardo Arango Gutierrez <carangog>
Status:	CLOSED ERRATA	QA Contact:	Walid A. <wabouham>
Severity:	high	Docs Contact:
Priority:	unspecified
Version:	4.8	CC:	lhorsley, rpattath, sejug
Target Milestone:	---
Target Release:	4.8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-07-27 22:19:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Walid A. 2021-06-01 18:19:50 UTC

Description of problem:
The NFD CSV nfd.v4.8.0.clusterserviceversion.yaml has the alm-examples configData section in workerConfig all commented out, leading to mislabeling of nodes with GPU card such as AWS g4dn.xlarge instances.  

https://github.com/openshift/cluster-nfd-operator/blob/master/manifests/4.8/manifests/nfd.v4.8.0.clusterserviceversion.yaml#L25

It needs to be:

      "configData": "sources:\n  pci:\n    deviceLabelFields:\n      - \"vendor\"\n    deviceClassWhitelist:\n      - \"0200\"\n      - \"03\"\n      - \"12\"\n"


Version-Release number of selected component (if applicable):
OCP build: 4.8.0-0.nightly-2021-05-21-233425
kubelet version:  v1.21.0-rc.0+c656d63

How reproducible:
Every time

Steps to Reproduce:
1. Deploy NFD operator bundle with operator-sdk run
2.
3.

Actual results:
 Worker node g4dn.xlarge is mislabeled:  feature.node.kubernetes.io/pci-0302_10de.present=true

Expected results:

 Worker node g4dn.xlarge should be labeled:  feature.node.kubernetes.io/pci-10de.present=true

Additional info:

Comment 2 Walid A. 2021-06-04 04:06:30 UTC

Verified on OCP 4.8.0-0.nightly-2021-06-03-055145  with latest nfd operator bundle built from NFD master github repo.

# oc describe node | grep feature | grep pci
                    feature.node.kubernetes.io/pci-1414.present=true
                    feature.node.kubernetes.io/pci-1414.present=true
                    feature.node.kubernetes.io/pci-1414.present=true

Comment 5 errata-xmlrpc 2021-07-27 22:19:28 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.8.2 extras update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:2435