Bug 1967293
| Summary: | [OSP 16.2] Volumes and vNICs are being hot plugged into SEV based instances without iommu='on' causing failures to attach and later detach within the guest OS | ||
|---|---|---|---|
| Product: | Red Hat OpenStack | Reporter: | Lee Yarwood <lyarwood> |
| Component: | openstack-nova | Assignee: | Lee Yarwood <lyarwood> |
| Status: | CLOSED ERRATA | QA Contact: | OSP DFG:Compute <osp-dfg-compute> |
| Severity: | urgent | Docs Contact: | |
| Priority: | urgent | ||
| Version: | 16.2 (Train) | CC: | amodi, dasmith, dgilbert, eglynn, jhakimra, jinzhao, jparker, juzhang, kchamart, sbauza, sgordon, shrjoshi, spower, virt-maint, vromanso, xuwei |
| Target Milestone: | rc | Keywords: | Patch, Triaged |
| Target Release: | 16.2 (Train on RHEL 8.4) | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | openstack-nova-20.6.2-2.20210607104827.el8ost.2 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-09-15 07:15:41 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1972699 | ||
| Bug Blocks: | 1833442 | ||
|
Description
Lee Yarwood
2021-06-02 19:21:31 UTC
Looking at that back trace, it feels more like the hot-add never actually completed. Can you confirm the XML fragment you passed to libvirt to do the hotadd? In particular I'm curious whether it has the iommu_platform stuff. (In reply to Dr. David Alan Gilbert from comment #1) > Looking at that back trace, it feels more like the hot-add never actually > completed. > Can you confirm the XML fragment you passed to libvirt to do the hotadd? > In particular I'm curious whether it has the iommu_platform stuff. Many thanks, the attach XML was: <disk type="block" device="disk"> <driver name="qemu" type="raw" cache="none" io="native"/> <source dev="/dev/sdc"/> <target bus="virtio" dev="vdb"/> <serial>b11ce83a-723a-49a2-a5cc-025cb8985b0d</serial> </disk> Later the detach device XML was: <disk type="block" device="disk"> <driver name="qemu" type="raw" cache="none" io="native"/> <source dev="/dev/sdc"/> <target bus="virtio" dev="vdb"/> <serial>b11ce83a-723a-49a2-a5cc-025cb8985b0d</serial> <address type="pci" domain="0x0000" bus="0x06" slot="0x00" function="0x0"/> </disk> (In reply to Lee Yarwood from comment #2) > (In reply to Dr. David Alan Gilbert from comment #1) > > Looking at that back trace, it feels more like the hot-add never actually > > completed. > > Can you confirm the XML fragment you passed to libvirt to do the hotadd? > > In particular I'm curious whether it has the iommu_platform stuff. > > Many thanks, the attach XML was: > > <disk type="block" device="disk"> > <driver name="qemu" type="raw" cache="none" io="native"/> > <source dev="/dev/sdc"/> > <target bus="virtio" dev="vdb"/> > <serial>b11ce83a-723a-49a2-a5cc-025cb8985b0d</serial> > </disk> I think that's missing the iommu part; i.e a <driver iommu='on'/> which you need for all SEV devices. (I also thought there was a preference for virtio-scsi on sev, but you seem to be fine on your boot disk). Dave > Later the detach device XML was: > > <disk type="block" device="disk"> > <driver name="qemu" type="raw" cache="none" io="native"/> > <source dev="/dev/sdc"/> > <target bus="virtio" dev="vdb"/> > <serial>b11ce83a-723a-49a2-a5cc-025cb8985b0d</serial> > <address type="pci" domain="0x0000" bus="0x06" slot="0x00" function="0x0"/> > </disk> (In reply to Dr. David Alan Gilbert from comment #3) > (In reply to Lee Yarwood from comment #2) > > (In reply to Dr. David Alan Gilbert from comment #1) > > > Looking at that back trace, it feels more like the hot-add never actually > > > completed. > > > Can you confirm the XML fragment you passed to libvirt to do the hotadd? > > > In particular I'm curious whether it has the iommu_platform stuff. > > > > Many thanks, the attach XML was: > > > > <disk type="block" device="disk"> > > <driver name="qemu" type="raw" cache="none" io="native"/> > > <source dev="/dev/sdc"/> > > <target bus="virtio" dev="vdb"/> > > <serial>b11ce83a-723a-49a2-a5cc-025cb8985b0d</serial> > > </disk> > > I think that's missing the iommu part; i.e a > <driver iommu='on'/> > > which you need for all SEV devices. > (I also thought there was a preference for virtio-scsi on sev, but you seem > to be fine on > your boot disk). Yeah appears there's missing logic within openstack-nova when hot plugging devices to a SEV instance as opposed to launching with them already attached. Moving this back over to openstack-nova, thanks for the help with this! Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Red Hat OpenStack Platform (RHOSP) 16.2 enhancement advisory), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2021:3483 |