RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1967335 - metrics role task to enable logging for targeted hosts not working
Summary: metrics role task to enable logging for targeted hosts not working
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: rhel-system-roles
Version: 8.4
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: beta
: 8.5
Assignee: Rich Megginson
QA Contact: Jan Kurik
Eliane Ramos Pereira
URL:
Whiteboard: role:metrics
Depends On:
Blocks: 1978746
TreeView+ depends on / blocked
 
Reported: 2021-06-02 22:16 UTC by Brian Smith
Modified: 2021-11-09 20:35 UTC (History)
5 users (show)

Fixed In Version: rhel-system-roles-1.4.0-1.el8
Doc Type: Bug Fix
Doc Text:
.Task to enable logging for targeted hosts in the `metric` role now works Previously, a bug in the `metric` RHEL System Role prevented referring to targeted hosts in the `enabling the performance metric logging` task. Consequently, the control file for performance metric logging was not generated. This update fixes the issue, and now the targeted hosts are correctly referred to. As a result, the control file is successfully created, enabling the performance metric logging execution.
Clone Of:
: 1978746 (view as bug list)
Environment:
Last Closed: 2021-11-09 17:45:29 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github linux-system-roles metrics pull 87 0 None closed __pcp_target_hosts not defined so loop doesn't run 2021-06-10 17:09:06 UTC
Red Hat Product Errata RHBA-2021:4159 0 None None None 2021-11-09 17:45:47 UTC

Description Brian Smith 2021-06-02 22:16:33 UTC
Description of problem:
The "Ensure performance metric logging is enabled for targeted hosts" task is not doing anything, even if the "metrics_monitored_hosts" role variable is defined.  This prevents pmlogger from gathering metrics from remote hosts


Version-Release number of selected component (if applicable):
rhel-system-roles-1.0.1-1.el8.noarch

How reproducible:
Every time

Steps to Reproduce:
1. Run playbook:
---
- hosts: localhost
  vars:
    metrics_graph_service: yes
    metrics_query_service: yes
    metrics_retention_days: 7
    metrics_monitored_hosts: ["rhel8-server1", "rhel8-server2", "rhel7-server1", "rhel7-server2"]
  roles: 
    - redhat.rhel_system_roles.metrics


Actual results:
The "Ensure performance metric logging is enabled for targeted hosts" task doesn't do anything:

TASK [redhat.rhel_system_roles.private_metrics_subrole_pcp : Ensure performance metric logging is enabled for targeted hosts] ***


Expected results:
The task runs and creates configuration files for each host under 
/etc/pcp/pmlogger/control.d/


Additional info:

It appears to me that the issue is the "Ensure performance metric logging is enabled for targeted hosts" task is looping on the "__pcp_target_hosts" variable which is not set anywhere, so the loop doesn't run.    

I updated the task to loop on "pcp_target_hosts" and this appeared to fix the issue and the task runs as expected and created the configuration files.

Comment 1 Brian Smith 2021-06-02 22:22:53 UTC
Created pull request with proposed fix (please verify this is correct way to fix issue):  https://github.com/linux-system-roles/metrics/pull/87

Comment 15 errata-xmlrpc 2021-11-09 17:45:29 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (rhel-system-roles bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:4159


Note You need to log in before you can comment on or make changes to this bug.