Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1967591

Summary: The ManagementCPUsOverride admission plugin should not mutate containers with the limit
Product: OpenShift Container Platform Reporter: Artyom <alukiano>
Component: NodeAssignee: Artyom <alukiano>
Node sub component: Autoscaler (HPA, VPA) QA Contact: Sunil Choudhary <schoudha>
Status: CLOSED ERRATA Docs Contact:
Severity: high    
Priority: high CC: aos-bugs, mfojtik, xxia
Version: 4.8   
Target Milestone: ---   
Target Release: 4.8.0   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-07-27 23:11:25 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Artyom 2021-06-03 12:50:47 UTC
Description of problem:
During the mutation of container with CPU limit we can finish with the container that looks:
    limits:
        cpu: 500m
        management.workload.openshift.io/cores: "20"
        memory: 256Mi
      requests:
        cpu: 500m
        management.workload.openshift.io/cores: "20"
        memory: 32Mi

What happens:
1. The container has a limit and request, but it not guaranteed pod so the container mutated by our plugin.
2. The plugin removes the CPU request and add our management resource request
3. The k8s defaulter restore CPU request to be equal to the CPU limit

Version-Release number of selected component (if applicable):
master

How reproducible:
Always

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:
For 4.8 we should just avoid mutating containers with both CPU request and limit


Additional info:

Comment 5 errata-xmlrpc 2021-07-27 23:11:25 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438