Description of problem: Hide text box for attached devices mode add capacity Version-Release number of selected component (if applicable): How reproducible: Steps to Reproduce: 1.Go to storage cluster. 2.click on Add Capacity. Actual results: When no storage class selected or a non no-prov storage class is selected. The input box shows up with NaN and undefined values. Expected results: We don't need to show input box for attached devices mode in any case. Since there is no predefined t-shirt size. Additional info:
Opening this BZ again as it is needed for the PR to get merged.
I tested it with an LSO vSphere cluster with the conf: OCP 4.9, OCS 4.9. Jenkins link to the cluster: https://ocs4-jenkins-csb-ocsqe.apps.ocp4.prod.psi.redhat.com/job/qe-deploy-ocs-cluster/6014/ Steps I did to reproduce the BZ: 1. Go to Installed Operators -> OpenShift Data Foundation -> click on StorageSystem 2. Click on "Add Capacity". After the steps above, it opens the Add capacity input box, But with no option to add new storage. I will add a screenshot with the details. Next step, I added a new disk to VM 'compute-0' on vSphere. Then I clicked again on "Add Capacity". Here I got the option to add new storage - I will add a screenshot with the details. I clicked on the "Add" option - And it increased the count in the ocs-storagecluster from 3 to 4: $ oc get storageclusters.ocs.openshift.io ocs-storagecluster -o yaml | grep count count: 4 The new PV that was created was in a "Bound" state: $ oc get pv NAME CAPACITY ACCESS MODES RECLAIM POLICY STATUS CLAIM STORAGECLASS REASON AGE local-pv-2d0ef873 256Gi RWO Delete Bound openshift-storage/ocs-deviceset-localblock-0-data-0jqhk8 localblock 64m local-pv-49973fcf 256Gi RWO Delete Bound openshift-storage/ocs-deviceset-localblock-0-data-2thd5g localblock 64m local-pv-b8a641d5 256Gi RWO Delete Bound openshift-storage/ocs-deviceset-localblock-0-data-3rdpk2 localblock 6m28s local-pv-ca89c574 256Gi RWO Delete Bound openshift-storage/ocs-deviceset-localblock-0-data-1qkdlq localblock 64m And a new OSD was created: $ oc get pods | grep osd rook-ceph-osd-0-8558786b49-zzk6j 2/2 Running 0 110m rook-ceph-osd-1-5dfcb8575f-x8r6r 2/2 Running 0 110m rook-ceph-osd-2-6c84bb7dcf-ptccv 2/2 Running 0 110m rook-ceph-osd-3-98b8d8649-vpmbk 2/2 Running 0 52m rook-ceph-osd-prepare-ocs-deviceset-localblock-0-data---1-gqhdn 0/1 Completed 0 52m rook-ceph-osd-prepare-ocs-deviceset-localblock-0-data---1-mwxwp 0/1 Completed 0 110m rook-ceph-osd-prepare-ocs-deviceset-localblock-0-data---1-nrrxv 0/1 Completed 0 110m rook-ceph-osd-prepare-ocs-deviceset-localblock-0-data---1-sr79x 0/1 Completed 0 110m In summarizing, we still see the input box for attached devices mode. Still, the behavior of the "add capacity" process seems reasonable except that it shows in the "add capacity" input box that it adds three replicas instead of the right amount that was 1. So one solution is to hide the input box for the mode of the attached devices. The other solution is to check first how many PVs are available, and when clicking on the "add capacity" option, it will show only the amount of the available PVs(and not necessarily 3)
Versions: OCP version: Client Version: 4.9.0-0.nightly-2021-09-10-170926 Server Version: 4.9.0-0.nightly-2021-09-18-052905 Kubernetes Version: v1.22.0-rc.0+af080cb OCS verison: ocs-operator.v4.9.0-142.ci OpenShift Container Storage 4.9.0-142.ci Succeeded cluster version NAME VERSION AVAILABLE PROGRESSING SINCE STATUS version 4.9.0-0.nightly-2021-09-18-052905 True False 5h36m Cluster version is 4.9.0-0.nightly-2021-09-18-052905 Rook version rook: 4.9-189.17d4fa2.release_4.9 go: go1.16.6 Ceph version ceph version 16.2.0-117.el8cp (0e34bb74700060ebfaa22d99b7d2cdc037b28a57) pacific (stable) Please let me know what do you think according to my comments above.
Hi Itzhak, The description of this BZ is not appropriate enough that is why this is causing this confusion. Let me brief about this BZ: --> We don't want to hide add-capacity modal. Here in this BZ's description input box refers to "Raw Capacity" input option that we have on this modal. --> This was the bug (please refer to the attached screenshot https://bugzilla.redhat.com/attachment.cgi?id=1824541). --> So, this BZ has a following scope: 1) You won't see this "NaN" issue anymore. 2) For internal-mode deployment, if osdSize is not 512GiB/2TiB/4TiB - this "Raw Capacity" input box will be hidden. 3) For attached-mode (that is selected storage-class is no provisioner storage-class) - this "Raw Capacity" input box will be hidden.
According to my conclusions before, I think the behavior is as expected. But still, in the attached-mode, it shows in the "add capacity" input box that it adds three replicas instead of the right amount that was one(As we can see in this screenshot https://bugzilla-attachments.redhat.com/attachment.cgi?id=1824356&t=IJtOgIM5uD). So I suggest fixing this part so that the customers will know the right amount of the capacity they add. Please let me know what do you think.
According to the comments above and to other discussions in the chat group, I think it's ok to move the BZ to verified.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Moderate: OpenShift Container Platform 4.9.0 bug fix and security update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2021:3759