Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1968373

Summary:	[4.8.0] BMAC re-attaches installed node on ISO regeneration
Product:	OpenShift Container Platform	Reporter:	Flavio Percoco <fpercoco>
Component:	assisted-installer	Assignee:	Flavio Percoco <fpercoco>
assisted-installer sub component:	assisted-service	QA Contact:	Yuri Obshansky <yobshans>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	medium
Priority:	medium	CC:	aos-bugs, nshidlin
Version:	4.8	Keywords:	Triaged
Target Milestone:	---
Target Release:	4.8.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	AI-Team-Platform KNI-EDGE-4.8
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-07-27 23:11:49 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1968372
Bug Blocks:

Description Flavio Percoco 2021-06-07 08:36:23 UTC

This bug was initially created as a copy of Bug #1968372

I am copying this bug because: 



Description of problem:

BMH resources are marked as detached once the deployment completes. Currently, BMAC takes care of re-attaching the BMH when an ISO is regenerated. This will cause a node re-deployment for every BMH associated to the InfraEnv that an image has been regenerated for, including installed nodes.

As far as assisted service is concerned, an installed spoke cluster is not part of the hub cluster anymore. Therefore, BMAC should respect this principle and skip reconcile for BMH nodes that have been detached.

Comment 3 nshidlin 2021-06-29 17:40:16 UTC

this bug doesn't block OCP4.8.0 -release -  the fix will be delivered the the ACM channel on the AI-operator add verified then

Comment 4 nshidlin 2021-07-08 12:42:42 UTC

Verified with ACM: 2.3.0-DOWNSTREAM-2021-07-06-21-29-18

Node is installed and and bmh is marked as detached before regenerating the ISO:
oc get bmh sno-0-bmh -o json | jq '.status.operationalStatus'
"detached"

 oc get agent ee2b463e-9c54-429b-bcf5-8ef57551d471 -o json | jq '.status.conditions[-1]'
{
  "lastTransitionTime": "2021-07-08T12:10:42Z",
  "message": "The installation has completed: Done",
  "reason": "InstallationCompleted",
  "status": "True",
  "type": "Installed"
}

ISO is regenerated by removing nmstateconfig_label.

bmh remains in detached state:

oc get bmh sno-0-bmh -o json | jq '.status.operationalStatus'
"detached"

Comment 8 errata-xmlrpc 2021-07-27 23:11:49 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.8.2 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2438