Spec URL: http://www.herr-schmitt.de/pub/python-smbpasswd/python-smbpasswd.spec SRPM URL: http://www.herr-schmitt.de/pub/python-smbpasswd/python-smbpasswd-1.0.1-1.src.rpm Description: This package contains a python module, which is able to generate LANMAN and NT password hashes suiteable to us with Samba.
I hope you're still interested in this package. It looks fine, only thing you have to do is remove python-api dependecy, because rpm do it automatically.
Next release: Spec URL: http://www.herr-schmitt.de/pub/python-smbpasswd/python-smbpasswd.spec SRPM URL: http://www.herr-schmitt.de/pub/python-smbpasswd/python-smbpasswd-1.0.1-2.src.rpm
Ok, I'll review your package. MUST items: * rpmlint message: E: python-smbpasswd-debuginfo script-without-shellbang /usr/src/debug/py- smbpasswd-1.0.1/smbpasswd.c - you should change permissions of this file to 644 in %prep section * the package is named well * spec file is named well * License field in package spec file match the actual license (GPL) * spec is written in American English and is legible * md5sums of source used to build the package and of upstream source are matching (0eab2c29588e32e77ce6e5d2faea7874) * package successfully compile on i386 * all build dependencies is good listed (mock builds successful) * there is no any locales * package doesn't contain shared library files * there is no duplicate files in %files listing * permissions aren't set properly (rpmlint error) * package has a good %clean section * there is no .la files * there is no GUI applications Thus, everything is good except for bad permissions of smbpasswd.c file. If you fix it, I'll approve this package.
Next release: Spec URL: http://www.herr-schmitt.de/pub/python-smbpasswd/python-smbpasswd.spec SRPM URL: http://www.herr-schmitt.de/pub/python-smbpasswd/python-smbpasswd-1.0.1-3.src.rpm
Okay, package approved.
Can this review request be closed now? Package is in CVS and out in the wild now.