Bug 1969791 - WebTerminal widget should send resize events
Summary: WebTerminal widget should send resize events
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Dev Console
Version: 4.6
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ---
: 4.7.z
Assignee: Sahil Budhwar
QA Contact: spathak@redhat.com
URL:
Whiteboard:
Depends On: 1969784
Blocks: 1972661
TreeView+ depends on / blocked
 
Reported: 2021-06-09 09:17 UTC by Sahil Budhwar
Modified: 2021-06-29 04:20 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1969784
: 1972661 (view as bug list)
Environment:
Last Closed: 2021-06-29 04:20:14 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
WebTerminal widget sends resize events (90.95 KB, image/png)
2021-06-16 07:37 UTC, spathak@redhat.com
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 9190 0 None open [release-4.7] Bug 1969791: fixes: WebTerminal widget should send resize events 2021-06-09 17:09:52 UTC
Red Hat Product Errata RHBA-2021:2502 0 None None None 2021-06-29 04:20:37 UTC

Description Sahil Budhwar 2021-06-09 09:17:11 UTC
+++ This bug was initially created as a clone of Bug #1969784 +++

From Christian:
everytime the pod terminal updates we send this:

const data = Base64.encode(JSON.stringify({ Height: rows, Width: cols }));
this.ws && this.ws.send(`4${data}`);
but widget that is used for WebTerminal does not seem to send it.

It's critical for WebTerminal since even kubectl edit command does not work with the default terminal size.

Comment 3 spathak@redhat.com 2021-06-16 07:37:39 UTC
Created attachment 1791479 [details]
WebTerminal widget sends resize events

Comment 4 spathak@redhat.com 2021-06-16 07:39:11 UTC
Verified on build version: 4.7.0-0.nightly-2021-06-12-151209
Browser: Google Chrome 89

Comment 5 OpenShift Automated Release Tooling 2021-06-17 12:29:08 UTC
OpenShift engineering has decided to not ship Red Hat OpenShift Container Platform 4.7.17 due a regression https://bugzilla.redhat.com/show_bug.cgi?id=1973006. All the fixes which were part of 4.7.17 will be now part of 4.7.18 and planned to be available in candidate channel on June 23 2021 and in fast channel on June 28th.

Comment 9 errata-xmlrpc 2021-06-29 04:20:14 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (OpenShift Container Platform 4.7.18 bug fix update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:2502


Note You need to log in before you can comment on or make changes to this bug.