Created attachment 1789664 [details]
500 node ovn-controller perf data

Based on attached perf results, there are some small optimizations that can be made in ovn-controller:

* Remove smap_get() call from datapath_is_switch() in ovn-util.c in favor of caching the result in the local_datapath struct.

* Optimize prepare_ipv6_ras() in pinctrl.c to not call smap_get() as often:
  * On the local_datapath, set a bool indicating if any of its ports is configured to use periodic RAs.
  * Call datapath_is_switch() to short-circuit if we are examining a switch instead of a router.
  * If possible, change the local_datapath peers members to use a wrapper struct instead of sbrec_port_binding, and save the periodic RA setting on it to avoid smap_get().

Aside from those, the following are ideas for performance improvement, but it is worth testing to see if it's actually helpful before actually merging:

* parse_action() in actions.c can have its if-else ladder changed into an shash lookup.

* The existing stopwatch() in ovn-controller.c could be made opt-in, potentially using an ovn-appctl command.