Spec URL: https://omos.fedorapeople.org/shared_files/chessx/chessx.spec SRPM URL: https://omos.fedorapeople.org/shared_files/chessx/chessx-1.5.6-2.fc35.src.rpm Description: ChessX is a free and open source chess database application for Linux, Mac OS X and Windows. Fedora Account System Username: omos ChessX is a Qt5 GUI application for working with chess game databases and analyzing chess games. COPR with test builds: https://copr.fedorainfracloud.org/coprs/omos/chessx/ Upstream project URL: https://sourceforge.net/projects/chessx/
- Use -p to keep timestamps: %install # Install the binary (already has all resources bundled) install -d %{buildroot}/%{_bindir} install -pm 0755 release/chessx %{buildroot}/%{_bindir} # Install the icon for the desktop file install -d %{buildroot}/%{_datadir}/pixmaps install -pm 0644 data/images/chessx.png %{buildroot}/%{_datadir}/pixmaps - explicitly BR gcc-c++ - Part of scid 1.0 (https://sourceforge.net/projects/scid/) is bundled, add: Provides: bundled(scid) = 1.0 - a copy of quazip is also bundled Provides: bundled(quazip) It would be better to unbundle it if possible as it is already packaged by Fedora. See if upstream can help, - it could be nice to provide an appdata file, see https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "GNU General Public License v2.0 or later", "BSD 3-clause "New" or "Revised" License", "GNU General Public License, Version 3", "GNU Lesser General Public License, Version 2.1", "LGPL (v2.1 or v3)", "GNU Library General Public License v2 or later [obsolete FSF postal address (Temple Place)]", "zlib/libpng license", "GNU General Public License", "Expat License". 483 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/chessx/review- chessx/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: chessx-1.5.6-2.fc35.x86_64.rpm chessx-debuginfo-1.5.6-2.fc35.x86_64.rpm chessx-debugsource-1.5.6-2.fc35.x86_64.rpm chessx-1.5.6-2.fc35.src.rpm chessx.x86_64: W: no-documentation chessx.x86_64: W: no-manual-page-for-binary chessx 4 packages and 0 specfiles checked; 0 errors, 2 warnings.
(In reply to Robert-André Mauchin 🐧 from comment #1) > - Use -p to keep timestamps: > > %install > # Install the binary (already has all resources bundled) > install -d %{buildroot}/%{_bindir} > install -pm 0755 release/chessx %{buildroot}/%{_bindir} > > # Install the icon for the desktop file > install -d %{buildroot}/%{_datadir}/pixmaps > install -pm 0644 data/images/chessx.png %{buildroot}/%{_datadir}/pixmaps I realized that upstream already has support for installing these files (and also desktop + appdata file) via `make install` in the master branch, so I'll backport the patches and just use %make_install. > - explicitly BR gcc-c++ Will add in next iteration. > - Part of scid 1.0 (https://sourceforge.net/projects/scid/) is bundled, add: > > Provides: bundled(scid) = 1.0 Ditto. > - a copy of quazip is also bundled > > Provides: bundled(quazip) > > It would be better to unbundle it if possible as it is already packaged by > Fedora. See if upstream can help, For now I added the Provides, but I plan to look into unbundling later. > - it could be nice to provide an appdata file, see > https://docs.fedoraproject.org/en-US/packaging-guidelines/AppData/ As mentioned above, I'll let %make_install install the upstream one. > [x]: License field in the package spec file matches the actual license. > Note: Checking patched sources after %prep for licenses. Licenses > found: "Unknown or generated", "GNU General Public License, Version > 2", "GNU General Public License v2.0 or later", "BSD 3-clause "New" or > "Revised" License", "GNU General Public License, Version 3", "GNU > Lesser General Public License, Version 2.1", "LGPL (v2.1 or v3)", "GNU > Library General Public License v2 or later [obsolete FSF postal > address (Temple Place)]", "zlib/libpng license", "GNU General Public > License", "Expat License". 483 files have unknown license. Detailed > output of licensecheck in /home/bob/packaging/review/chessx/review- > chessx/licensecheck.txt Hm... I wonder if I should include all/some of these in the license field? Some files indeed contain a different license from what is in LICENSE. *Final notes* I opened two PRs against the upstream project to fix the installation of icons and drop executable bit from source files: https://github.com/Isarhamster/chessx/pull/61 https://github.com/Isarhamster/chessx/pull/62 I added these (and the upstream icons/appdata native install commits - rebased onto the v1.5.6 release version) as patch files to the SRPM. Updated SRPM and spec files: Spec URL: https://omos.fedorapeople.org/shared_files/chessx-v2/chessx.spec SRPM URL: https://omos.fedorapeople.org/shared_files/chessx-v2/chessx-1.5.6-3.fc35.src.rpm Diff from the last iteration: https://gitlab.com/omos/chessx/-/compare/chessx-1.5.6-2...chessx-1.5.6-3 Thanks a lot for the review!
Licenses are: BSD 3-clause "New" or "Revised" License --------------------------------------- chessx-1.5.6/src/database/downloadmanager.cpp chessx-1.5.6/src/database/downloadmanager.h Expat License ------------- chessx-1.5.6/dep/scid/code/src/bytebuf.h GNU General Public License -------------------------- chessx-1.5.6/dep/scid/code/src/board_def.h chessx-1.5.6/dep/scid/code/src/codec.h chessx-1.5.6/dep/scid/code/src/codec_native.h chessx-1.5.6/dep/scid/code/src/codec_scid4.cpp chessx-1.5.6/dep/scid/code/src/codec_scid4.h chessx-1.5.6/dep/scid/code/src/containers.h chessx-1.5.6/dep/scid/code/src/fastgame.h chessx-1.5.6/dep/scid/code/src/filebuf.h chessx-1.5.6/dep/scid/code/src/fullmove.h chessx-1.5.6/dep/scid/code/src/hfilter.h chessx-1.5.6/dep/scid/code/src/index.h chessx-1.5.6/dep/scid/code/src/indexentry.h chessx-1.5.6/dep/scid/code/src/movegen.h chessx-1.5.6/dep/scid/code/src/movetree.h chessx-1.5.6/dep/scid/code/src/namebase.h chessx-1.5.6/dep/scid/code/src/sortcache.cpp chessx-1.5.6/dep/scid/code/src/sortcache.h chessx-1.5.6/dep/scid/code/src/stored.cpp chessx-1.5.6/dep/scid/code/src/stored.h GNU General Public License v2.0 or later ---------------------------------------- chessx-1.5.6/src/database/analysis.cpp chessx-1.5.6/src/database/analysis.h chessx-1.5.6/src/database/bitboard.cpp chessx-1.5.6/src/database/bitboard.h chessx-1.5.6/src/database/board.cpp chessx-1.5.6/src/database/board.h chessx-1.5.6/src/database/database.cpp chessx-1.5.6/src/database/database.h chessx-1.5.6/src/database/databaseconversion.cpp chessx-1.5.6/src/database/databaseconversion.h chessx-1.5.6/src/database/databaseinfo.cpp chessx-1.5.6/src/database/databaseinfo.h chessx-1.5.6/src/database/editaction.cpp chessx-1.5.6/src/database/editaction.h chessx-1.5.6/src/database/enginedata.cpp chessx-1.5.6/src/database/enginedata.h chessx-1.5.6/src/database/enginelist.cpp chessx-1.5.6/src/database/enginelist.h chessx-1.5.6/src/database/enginex.cpp chessx-1.5.6/src/database/enginex.h chessx-1.5.6/src/database/filter.cpp chessx-1.5.6/src/database/filter.h chessx-1.5.6/src/database/filtermodel.cpp chessx-1.5.6/src/database/filtermodel.h chessx-1.5.6/src/database/gamex.cpp chessx-1.5.6/src/database/gamex.h chessx-1.5.6/src/database/historylist.cpp chessx-1.5.6/src/database/historylist.h chessx-1.5.6/src/database/index.cpp chessx-1.5.6/src/database/index.h chessx-1.5.6/src/database/indexitem.cpp chessx-1.5.6/src/database/indexitem.h chessx-1.5.6/src/database/memorydatabase.cpp chessx-1.5.6/src/database/memorydatabase.h chessx-1.5.6/src/database/move.h chessx-1.5.6/src/database/nag.cpp chessx-1.5.6/src/database/nag.h chessx-1.5.6/src/database/openingtree.cpp chessx-1.5.6/src/database/openingtree.h chessx-1.5.6/src/database/output.cpp chessx-1.5.6/src/database/output.h chessx-1.5.6/src/database/outputoptions.cpp chessx-1.5.6/src/database/outputoptions.h chessx-1.5.6/src/database/partialdate.cpp chessx-1.5.6/src/database/partialdate.h chessx-1.5.6/src/database/pgndatabase.cpp chessx-1.5.6/src/database/pgndatabase.h chessx-1.5.6/src/database/playerdata.cpp chessx-1.5.6/src/database/playerdata.h chessx-1.5.6/src/database/playerdatabase.cpp chessx-1.5.6/src/database/playerdatabase.h chessx-1.5.6/src/database/playerinfo.cpp chessx-1.5.6/src/database/playerinfo.h chessx-1.5.6/src/database/rand64.h chessx-1.5.6/src/database/search.cpp chessx-1.5.6/src/database/search.h chessx-1.5.6/src/database/settings.cpp chessx-1.5.6/src/database/settings.h chessx-1.5.6/src/database/spellchecker.cpp chessx-1.5.6/src/database/spellchecker.h chessx-1.5.6/src/database/tablebase.cpp chessx-1.5.6/src/database/tablebase.h chessx-1.5.6/src/database/tagvalues.h chessx-1.5.6/src/database/uciengine.cpp chessx-1.5.6/src/database/uciengine.h chessx-1.5.6/src/database/version.h chessx-1.5.6/src/database/wbengine.cpp chessx-1.5.6/src/database/wbengine.h chessx-1.5.6/src/dialogs/copydialog.cpp chessx-1.5.6/src/dialogs/copydialog.h chessx-1.5.6/src/dialogs/preferences.cpp chessx-1.5.6/src/dialogs/preferences.h chessx-1.5.6/src/dialogs/quicksearch.cpp chessx-1.5.6/src/dialogs/quicksearch.h chessx-1.5.6/src/dialogs/recipientaddressdialog.cpp chessx-1.5.6/src/dialogs/recipientaddressdialog.h chessx-1.5.6/src/dialogs/savedialog.cpp chessx-1.5.6/src/dialogs/savedialog.h chessx-1.5.6/src/gui/analysiswidget.cpp chessx-1.5.6/src/gui/analysiswidget.h chessx-1.5.6/src/gui/boardsetup.cpp chessx-1.5.6/src/gui/boardsetup.h chessx-1.5.6/src/gui/boardtheme.cpp chessx-1.5.6/src/gui/boardtheme.h chessx-1.5.6/src/gui/boardview.cpp chessx-1.5.6/src/gui/boardview.h chessx-1.5.6/src/gui/chessbrowser.cpp chessx-1.5.6/src/gui/chessbrowser.h chessx-1.5.6/src/gui/colorlist.cpp chessx-1.5.6/src/gui/colorlist.h chessx-1.5.6/src/gui/gamelist.cpp chessx-1.5.6/src/gui/gamelist.h chessx-1.5.6/src/gui/main.cpp chessx-1.5.6/src/gui/mainwindow.cpp chessx-1.5.6/src/gui/mainwindow.h chessx-1.5.6/src/gui/mainwindowabout.cpp chessx-1.5.6/src/gui/mainwindowactions.cpp chessx-1.5.6/src/gui/messagedialog.h chessx-1.5.6/src/gui/ooo/formatproperty.cpp chessx-1.5.6/src/gui/ooo/formatproperty.h chessx-1.5.6/src/gui/ooo/styleinformation.cpp chessx-1.5.6/src/gui/ooo/styleinformation.h chessx-1.5.6/src/gui/ooo/styleparser.cpp chessx-1.5.6/src/gui/ooo/styleparser.h GNU General Public License, Version 2 ------------------------------------- chessx-1.5.6/COPYING chessx-1.5.6/License.txt GNU General Public License, Version 3 ------------------------------------- chessx-1.5.6/src/gui/messagedialog.cpp GNU Lesser General Public License, Version 2.1 ---------------------------------------------- chessx-1.5.6/src/gui/qled.cpp chessx-1.5.6/src/gui/qled.h GNU Library General Public License v2 or later [obsolete FSF postal address (Temple Place)] ------------------------------------------------------------------------------------------- chessx-1.5.6/src/quazip/quazip.cpp chessx-1.5.6/src/quazip/quazip.h chessx-1.5.6/src/quazip/quazip_global.h chessx-1.5.6/src/quazip/quazipfile.cpp chessx-1.5.6/src/quazip/quazipfile.h chessx-1.5.6/src/quazip/quazipfileinfo.h chessx-1.5.6/src/quazip/quazipnewinfo.cpp chessx-1.5.6/src/quazip/quazipnewinfo.h LGPL (v2.1 or v3) ----------------- chessx-1.5.6/src/gui/textedit.cpp chessx-1.5.6/src/gui/textedit.h The most restrictive license is GPLv2,so you can put this in the License field, but you can also put all of them if you wish with a comment specifying the license breakdown. Package approved.
(In reply to Robert-André Mauchin 🐧 from comment #3) > The most restrictive license is GPLv2,so you can put this in the License > field, but you can also put all of them if you wish with a comment > specifying the license breakdown. Oh, OK, I found [1], which supports using just the "effective" license. However, the diagram in [2] suggests that neither of GPLv2 and GPLv3 are a "superset" of each other, so I guess the effective license should be "GPLv2 and GPLv3" to be technically correct? (I don't know, maybe I'm overthinking it?) > Package approved. Thanks! [1] https://fedoraproject.org/wiki/Licensing:FAQ?rd=Licensing/FAQ#What_is_.22effective_license.22_and_do_I_need_to_know_that_for_the_License:_tag.3F [2] https://dwheeler.com/essays/floss-license-slide.html
(In reply to Ondrej Mosnacek from comment #4) > (In reply to Robert-André Mauchin 🐧 from comment #3) > > The most restrictive license is GPLv2,so you can put this in the License > > field, but you can also put all of them if you wish with a comment > > specifying the license breakdown. > > Oh, OK, I found [1], which supports using just the "effective" license. > However, the diagram in [2] suggests that neither of GPLv2 and GPLv3 are a > "superset" of each other, so I guess the effective license should be "GPLv2 > and GPLv3" to be technically correct? (I don't know, maybe I'm overthinking > it?) > Yes this seems to be right. However you should specify the license breakdown in a comment.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/chessx
FEDORA-2021-b7f3c1ad0c has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-b7f3c1ad0c
FEDORA-2021-4ae6f3b0a9 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-4ae6f3b0a9
FEDORA-2021-b7f3c1ad0c has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-b7f3c1ad0c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-b7f3c1ad0c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-4ae6f3b0a9 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-4ae6f3b0a9 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-4ae6f3b0a9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-4ae6f3b0a9 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2021-b7f3c1ad0c has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.