Bug 1971372 - Review Request: rust-vcpkg - A library to find native dependencies in a vcpkg
Summary: Review Request: rust-vcpkg - A library to find native dependencies in a vcpkg
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1971375
TreeView+ depends on / blocked
 
Reported: 2021-06-13 21:16 UTC by Rémi Lauzier
Modified: 2021-06-30 03:15 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-06-30 03:15:32 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+

Attachments (Terms of Use)

Description Rémi Lauzier 2021-06-13 21:16:23 UTC 
Spec URL: https://download.copr.fedorainfracloud.org/results/remilauzier/rust-simp/fedora-rawhide-x86_64/02252178-rust-vcpkg/rust-vcpkg.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/remilauzier/rust-simp/fedora-rawhide-x86_64/02252178-rust-vcpkg/rust-vcpkg-0.2.13-1.fc35.src.rpm
Description: A library to find native dependencies in a vcpkg tree at build time in order to be used in Cargo build scripts
Fedora Account System Username: remilauzier
Comment 1 Rémi Lauzier 2021-06-16 22:50:12 UTC 
Update to 0.2.14
https://download.copr.fedorainfracloud.org/results/remilauzier/rust-simp/fedora-rawhide-x86_64/02256142-rust-vcpkg/rust-vcpkg.spec
https://download.copr.fedorainfracloud.org/results/remilauzier/rust-simp/fedora-rawhide-x86_64/02256142-rust-vcpkg/rust-vcpkg-0.2.14-1.fc35.src.rpm
Comment 2 Robert-André Mauchin 🐧 2021-06-18 13:50:30 UTC 
 - I don't think you should ship tests and test-data folders. Exclude them by modifying the cqrgo.toml

exclude = ["/tests/*", "/test-data/*"]

Don't forget to add a comment explaining what you did above the patch.

 - Fix these line encodings:

rust-vcpkg-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/rust-vcpkg-devel/CHANGELOG.md
rust-vcpkg-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/rust-vcpkg-devel/README.md
Comment 3 Rémi Lauzier 2021-06-19 04:15:12 UTC 
Done.
https://download.copr.fedorainfracloud.org/results/remilauzier/rust-simp/fedora-rawhide-x86_64/02263315-rust-vcpkg/rust-vcpkg.spec
https://download.copr.fedorainfracloud.org/results/remilauzier/rust-simp/fedora-rawhide-x86_64/02263315-rust-vcpkg/rust-vcpkg-0.2.14-1.fc35.src.rpm

https://github.com/mcgoo/vcpkg-rs/pull/39
Comment 4 Robert-André Mauchin 🐧 2021-06-19 12:29:13 UTC 
 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.
Comment 5 Gwyn Ciesla 2021-06-21 14:42:55 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-vcpkg
Comment 6 Fedora Update System 2021-06-21 21:38:00 UTC 
FEDORA-2021-02e095c720 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-02e095c720
Comment 7 Fedora Update System 2021-06-22 01:05:08 UTC 
FEDORA-2021-02e095c720 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-02e095c720 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-02e095c720

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
Comment 8 Fedora Update System 2021-06-30 03:15:32 UTC 
FEDORA-2021-02e095c720 has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.