Bug 1972370 - Right click by touchpad two/three-fingers press doesn't work after upgrade to libinput 1.18.0-1.fc34
Summary: Right click by touchpad two/three-fingers press doesn't work after upgrade to...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: libinput
Version: 34
Hardware: x86_64
OS: Linux
unspecified
high
Target Milestone: ---
Assignee: Peter Hutterer
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-06-15 18:06 UTC by badoken1101@gmail.com
Modified: 2021-08-30 23:21 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-06-24 22:37:26 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
libinput record with libinput-1.18.0-1.fc34 being installed (181.69 KB, text/plain)
2021-06-16 07:38 UTC, badoken1101@gmail.com
no flags Details
libinput record with libinput-1.17.2-1.fc34 being installed (86.67 KB, text/plain)
2021-06-16 07:39 UTC, badoken1101@gmail.com
no flags Details

Description badoken1101@gmail.com 2021-06-15 18:06:46 UTC
Description of problem:
After upgrade of libinput I can no longer cast neither right click action by pressing touchpad with two fingers on it nor middle click by pressing touchpad with three fingers on it.

Version-Release number of selected component (if applicable):
1.18.0-1.fc34

How reproducible:
Update from libinput-1.17.2-1.fc34 to libinput 1.18.0-1.fc34.


Steps to Reproduce:
1. Update to libinput 1.18.0-1.fc34;
2. Press on touchpad with two/three fingers on it.

Actual results:
Cursor clicks on hovered element with equivalent of left mouse click.


Expected results:
Cursor clicks on hovered element with equivalent of right/middle click.


Additional info:
Tap with multiple fingers still works. But not press with multiple fingers fingers.

Support of touchpad press with one finger and move with another to select a big area is no longer work too (cursor doesn't move when the second finger is moved)

Manual downgrade to libinput-1.17.2-1.fc34 resolves the issue.

Touchpad: ELAN2604:00 04F3:3114

If I run journalctl | grep -Ei 'i8042|pnp|elantech|touchpad' it shows the following:
Jun 15 20:49:18 badoken-matebook kernel: input: ELAN2604:00 04F3:3114 Touchpad as /devices/pci0000:00/0000:00:15.0/i2c_designware.0/i2c-0/i2c-ELAN2604:00/0018:04F3:3114.0001/input/input6
Jun 15 20:49:19 badoken-matebook kernel: input: ELAN2604:00 04F3:3114 Touchpad as /devices/pci0000:00/0000:00:15.0/i2c_designware.0/i2c-0/i2c-ELAN2604:00/0018:04F3:3114.0001/input/input11
Jun 15 20:49:20 badoken-matebook kernel: input: Video Bus as /devices/LNXSYSTM:00/LNXSYBUS:00/PNP0A08:00/LNXVIDEO:00/input/input12
Jun 15 20:49:29 badoken-matebook org.gnome.Shell.desktop[2601]: libinput error: event6  - ELAN2604:00 04F3:3114 Touchpad: kernel bug: clickpad with right button, assuming it is not a clickpad
Jun 15 20:49:35 badoken-matebook gnome-shell[3270]: libinput error: event6  - ELAN2604:00 04F3:3114 Touchpad: kernel bug: clickpad with right button, assuming it is not a clickpad
Jun 15 20:49:36 badoken-matebook systemd[3143]: Starting Rygel DLNA/UPnP server...
Jun 15 20:49:36 badoken-matebook systemd[3143]: Started Rygel DLNA/UPnP server.
Jun 15 21:01:54 badoken-matebook gnome-shell[3270]: libinput error: event6  - ELAN2604:00 04F3:3114 Touchpad: kernel bug: Touch jump detected and discarded.
Jun 15 21:01:54 badoken-matebook gnome-shell[3270]: See https://wayland.freedesktop.org/libinput/doc/1.18.0/touchpad-jumping-cursors.html for details

Comment 1 Peter Hutterer 2021-06-15 20:51:40 UTC
Can you attach the `libinput record` output for your touchpad please? Thanks.

Comment 2 badoken1101@gmail.com 2021-06-16 07:36:43 UTC
@

Comment 3 badoken1101@gmail.com 2021-06-16 07:38:16 UTC
Created attachment 1791480 [details]
libinput record with libinput-1.18.0-1.fc34 being installed

Comment 4 badoken1101@gmail.com 2021-06-16 07:39:03 UTC
Created attachment 1791481 [details]
libinput record with libinput-1.17.2-1.fc34 being installed

Comment 5 badoken1101@gmail.com 2021-06-16 07:41:14 UTC
Hey Peter. 
I've attached two files with different versions of the lib being used.
During the tests I pressed touchpad in the following order:
- 3 fingers;
- 2 fingers;
- 3 fingers;
- 2 fingers.
Hopefully it helps.

Comment 6 Peter Hutterer 2021-06-16 23:20:02 UTC
fwiw, `libinput record` records kernel output only so the installed libinput version doesn't matter. Thanks though :)

What's the human model number for this? the dmi output is a bit cryptic but it looks like we need a quirk here. Does this work?

$ cat > /etc/libinput/local-overrides.quirks <<EOF
[Huawei MateBook ???]
MatchName=ELAN2604:00 04F3:3114 Touchpad
MatchUdevType=touchpad
MatchDMIModalias=dmi:*svnHUAWEI:*pvrM1010*
AttrEventCodeDisable=BTN_RIGHT
EOF
$ libinput quirks list /dev/input/eventXX # your device's event node
AttrEventCodeDisable=BTN_RIGHT


Then restart the session and it should work. If that all works, i'll get that snippet merged upstream.

Comment 7 badoken1101@gmail.com 2021-06-17 17:30:14 UTC
Thanks for replying, Peter.

I did what you've asked, but I had to create "libinput" folder and the file first (not sure if this matters).

After that touchpad behaviour returned back to normal, so thank you!

Comment 8 badoken1101@gmail.com 2021-06-17 17:35:46 UTC
Just in case the model name needed not only for my local resolution, it's Huawei MateBook 2020 or Huawei EUL-WX9.

Comment 9 Peter Hutterer 2021-06-20 23:15:38 UTC
Upstream MR: https://gitlab.freedesktop.org/libinput/libinput/-/merge_requests/647

Comment 10 Peter Hutterer 2021-06-24 22:37:26 UTC
I forgot to add the bugzilla number to the update, but this should be fixed now: https://bodhi.fedoraproject.org/updates/FEDORA-2021-8bb43ba726

Comment 11 SaGrLand 2021-08-21 20:25:58 UTC
Maybe the fix introduced a new bug:
With libinput 1.18.1-1 the Free Touch Touchpads on both MateBook X 2020 and MateBook X Pro 2021 lost the ability to drag & drop by using two fingers. If one finger is producing a click the second finger can't move the cursor around anymore.

https://gitlab.freedesktop.org/libinput/libinput/-/issues/649

Comment 12 Peter Hutterer 2021-08-30 23:21:06 UTC
SaGrLand: we can't fix or even look at this issue without any data, please look at https://wayland.freedesktop.org/libinput/doc/latest/reporting-bugs.html and then provide the libinput recordings in the upstream issue, thanks


Note You need to log in before you can comment on or make changes to this bug.