Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://dcavalca.fedorapeople.org/review/gnome-shell-frippery/gnome-shell-frippery.spec SRPM URL: https://dcavalca.fedorapeople.org/review/gnome-shell-frippery/gnome-shell-frippery-40.2-1.fc34.src.rpm Description: This package contains some GNOME Shell extensions to provide a user experience more like that of GNOME 2. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=70211082
- if you set --all-name, it will include all po in both frippery-applications-menu and frippery-bottom-panel %find_lang frippery-applications-menu --all-name %find_lang frippery-bottom-panel --all-name Check your resulting packages, you will notice frippery-applications-menu po in frippery-bottom-panel and vice-versa. Re;ove --all-name for both. - Notify upstream that their FSF address is the obsolete one and it should be updated: gnome-shell-extension-frippery-bottom-panel.noarch: E: incorrect-fsf-address /usr/share/licenses/gnome-shell-extension-frippery-bottom-panel/COPYING - Don't mix tabs and spaces, choose one and stick to it: gnome-shell-frippery.src:22: W: mixed-use-of-spaces-and-tabs (spaces: line 22, tab: line 4) Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "*No copyright* GNU General Public License v2.0 or later". 348 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/gnome-shell-frippery/review-gnome-shell- frippery/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 122880 bytes in 8 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gnome- shell-extension-frippery-applications-menu , gnome-shell-extension- frippery-bottom-panel , gnome-shell-extension-frippery-move-clock , gnome-shell-extension-frippery-panel-favorites [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gnome-shell-extension-frippery-applications-menu-40.2-1.fc35.noarch.rpm gnome-shell-extension-frippery-bottom-panel-40.2-1.fc35.noarch.rpm gnome-shell-extension-frippery-move-clock-40.2-1.fc35.noarch.rpm gnome-shell-extension-frippery-panel-favorites-40.2-1.fc35.noarch.rpm gnome-shell-frippery-40.2-1.fc35.src.rpm gnome-shell-extension-frippery-applications-menu.noarch: E: incorrect-fsf-address /usr/share/licenses/gnome-shell-extension-frippery-applications-menu/COPYING gnome-shell-extension-frippery-bottom-panel.noarch: W: spelling-error %description -l en_US workspace -> work space, work-space, works pace gnome-shell-extension-frippery-bottom-panel.noarch: E: incorrect-fsf-address /usr/share/licenses/gnome-shell-extension-frippery-bottom-panel/COPYING gnome-shell-extension-frippery-move-clock.noarch: W: spelling-error %description -l en_US centre -> center, cent re, cent-re gnome-shell-extension-frippery-move-clock.noarch: E: incorrect-fsf-address /usr/share/licenses/gnome-shell-extension-frippery-move-clock/COPYING gnome-shell-extension-frippery-panel-favorites.noarch: W: spelling-error %description -l en_US favourite -> favorite, favoritism gnome-shell-extension-frippery-panel-favorites.noarch: E: incorrect-fsf-address /usr/share/licenses/gnome-shell-extension-frippery-panel-favorites/COPYING gnome-shell-frippery.src:22: W: mixed-use-of-spaces-and-tabs (spaces: line 22, tab: line 4) 5 packages and 0 specfiles checked; 4 errors, 4 warnings.
Spec URL: https://dcavalca.fedorapeople.org/review/gnome-shell-frippery/gnome-shell-frippery.spec SRPM URL: https://dcavalca.fedorapeople.org/review/gnome-shell-frippery/gnome-shell-frippery-40.2-2.fc35.src.rpm Changelog: - Correct %%find_lang macro usage - Convert tabs to spaces
Package approved.
Thanks! $ fedpkg request-repo gnome-shell-frippery 1972511 https://pagure.io/releng/fedora-scm-requests/issue/35309
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/gnome-shell-frippery
FEDORA-2021-2c1e47bd27 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-2c1e47bd27
FEDORA-2021-2c1e47bd27 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-2c1e47bd27 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-2c1e47bd27 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-2c1e47bd27 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.