Bug 1972601 - Review Request: openldap-servers - LDAP server
Summary: Review Request: openldap-servers - LDAP server
Keywords:
Status: CLOSED CANTFIX
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: Package Review
Version: epel8
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FE-NEEDSPONSOR
TreeView+ depends on / blocked
 
Reported: 2021-06-16 10:11 UTC by Danilo Godec
Modified: 2021-11-10 14:18 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-11-10 03:25:57 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Danilo Godec 2021-06-16 10:11:46 UTC
Description of problem:

Red Hat has dropped OpenLDAP servers package, but OpenLDAP is still widely used and actively developed and maintained.

I suggest it gets included in EPEL build.

Comment 1 Carl George 🤠 2021-06-16 17:19:27 UTC
The package review component is for submitting new packages after you've created a spec file [0].  It is not a wishlist to ask other people to do the work.

If you'd like to start this work, there are a few things to be aware of.

- openldap-server is a subpackage from the openldap spec file.
- RHEL8 ships all the other subpackages, and thus the name openldap is blocked from being requested for an epel8 branch.

In order to ship just openldap-servers in EPEL8, the following would have to happen.

- Create a new openldap-servers.spec file based on the RHEL8 spec file [1] but removing all other subpackages and files to avoid conflicts with packages shipped in RHEL8.
- Submit a package review for openldap-servers.
- Once approved and added, keep the EPEL openldap-servers.spec file in sync with the RHEL openldap.spec file over time.


[0] https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Adding_a_new_package
[1] https://git.centos.org/rpms/openldap/blob/c8s/f/SPECS/openldap.spec

Comment 2 Danilo Godec 2021-06-17 09:56:50 UTC
Hope it's OK to re-open this 'bug' to submit the SPEC file, src.rpm and the binary x86_64.rpm.

This is my first package in Fedora 'universe'.

I adapted the SPEC file to build just the openldap-servers binary package - the SPEC file is still named openldap.spec and the resulting src.rpm is also named 'openldap' - should these also be changed to 'openldap-servers' ?

All the files are available on copr:

https://download.copr.fedorainfracloud.org/results/danci1973/openldap-servers/epel-8-x86_64/02257010-openldap/openldap-2.4.46-16.el8.src.rpm
https://download.copr.fedorainfracloud.org/results/danci1973/openldap-servers/epel-8-x86_64/02257010-openldap/openldap-servers-2.4.46-16.el8.x86_64.rpm
https://download.copr.fedorainfracloud.org/results/danci1973/openldap-servers/epel-8-x86_64/02257010-openldap/openldap.spec

Comment 3 Carl George 🤠 2021-08-17 20:09:56 UTC
Yes, the spec file needs to be renamed to openldap-servers.spec, and the Name field has to be changed to openldap-servers.  The servers subpackage (`%package servers`, `%files servers`) will also need to be merged into the top level package.

Comment 4 Jon Levell 2021-11-04 16:21:34 UTC
Based on Danilo Godec's work and the comment here, I've updated the spec file.

Here's the spec file that matches the current upstream spec file:
https://copr-be.cloud.fedoraproject.org/results/jonquark/openldap-servers/epel-8-x86_64/02928889-openldap-servers/openldap-servers-18.spec
And the rpm it produces:
https://copr-be.cloud.fedoraproject.org/results/jonquark/openldap-servers/epel-8-x86_64/02928889-openldap-servers/openldap-servers-2.4.46-18.el8.x86_64.rpm

and here's the RPM (based on an older specfile) that matches the openldap version currently in the centos 8 repos:
https://copr-be.cloud.fedoraproject.org/results/jonquark/openldap-servers/epel-8-x86_64/02928888-openldap-servers/openldap-servers-2.4.46-17.el8_4.x86_64.rpm

I worry slightly about the version locking across repos. Each of these openldap-servers packages requires an exact version of the openldap package which
would cause issues when e.g. an updated openldap is pushed from the main repo and the corresponding openldap-servers hasn't ben pushed to EPEL.

I'm not sure what the right thing to do here is, I guess relax the exact version dependency but it would require some testing to check it worked
with version mismatches (I suspect it would be fine for 2.4.46-17.el8_4 and 2.4.46-18 but you can imagine changes that would cause things to be broken.

Comment 5 Carl George 🤠 2021-11-10 03:25:57 UTC
Thanks Danilo and Jon for your work on this so far.  Fortunately for the long term maintenance (but unfortunately for the time y'all have spent) RHEL is adding openldap-server back to the distribution.  It is available now in CentOS Stream 8 PowerTools, and it should show up in RHEL 8 CRB soon.

https://git.centos.org/centos/comps/c/7b25a7b446b511edfa34bb395d942c49abd21b25?branch=master

It doesn't make any sense to continue this review, in fact openldap-servers will no longer be eligible for EPEL8, so I'm going to close this out.

Comment 6 Jon Levell 2021-11-10 14:18:32 UTC
That is awesome news :)


Note You need to log in before you can comment on or make changes to this bug.