Spec URL: https://spot.fedorapeople.org/R-KEGGREST.spec SRPM URL: https://spot.fedorapeople.org/R-KEGGREST-1.32.0-1.fc34.src.rpm Description: A package that provides a client interface to the Kyoto Encyclopedia of Genes and Genomes (KEGG) REST server. Based on KEGGSOAP by J. Zhang, R. Gentleman, and Marc Carlson, and KEGG (python package) by Aurelien Mazurie. Fedora Account System Username: spot Koji scratch build (rawhide + R 4.1.0): https://koji.fedoraproject.org/koji/taskinfo?taskID=70252522 Needed to build the latest version of R-AnnotationDbi.
Everything ok. Package APPROVED. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package have the default element marked as %%doc :doc, DESCRIPTION, NEWS - Package requires R-core. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 23 files have unknown license. Detailed output of licensecheck in /home/iucar/fedora- review/1972905-R-KEGGREST/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local R: [x]: Package contains the mandatory BuildRequires. [x]: The package has the standard %install section. ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. R: [x]: The %check macro is present [x]: Latest version is packaged. Note: Latest upstream version is 1.32.0, packaged version is 1.32.0 ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: R-KEGGREST-1.32.0-1.fc35.noarch.rpm R-KEGGREST-1.32.0-1.fc35.src.rpm R-KEGGREST.noarch: W: spelling-error %description -l en_US Zhang -> Hang, Chang, Z hang R-KEGGREST.src: W: spelling-error %description -l en_US Zhang -> Hang, Chang, Z hang 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- http://www.bioconductor.org/packages/release/bioc/src/contrib/KEGGREST_1.32.0.tar.gz : CHECKSUM(SHA256) this package : 8d5daf8823a1b906fb2222a0d0db947d06cffe728641278af5f18f0d441b6194 CHECKSUM(SHA256) upstream package : 8d5daf8823a1b906fb2222a0d0db947d06cffe728641278af5f18f0d441b6194 Requires -------- R-KEGGREST (rpmlib, GLIBC filtered): R(ABI) R(Biostrings) R(httr) R(methods) R(png) R-core Provides -------- R-KEGGREST: R(KEGGREST) R-KEGGREST Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1972905 Buildroot used: fedora-rawhide-x86_64 Active plugins: R, Generic, Shell-api Disabled plugins: Haskell, SugarActivity, C/C++, PHP, Perl, Ocaml, fonts, Python, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/R-KEGGREST
Build in side-tag for eventual Rawhide merge.