Spec URL: https://spot.fedorapeople.org/R-BiocIO.spec SRPM URL: https://spot.fedorapeople.org/R-BiocIO-1.2.0-1.fc34.src.rpm Description: Implements `import()` and `export()` standard generics for importing and exporting biological data formats. `import()` supports whole-file as well as chunk-wise iterative import. The `import()` interface optionally provides a standard mechanism for 'lazy' access via `filter()` (on row or element-like components of the file resource), `select()` (on column-like components of the file resource) and `collect()`. The `import()` interface optionally provides transparent access to remote (e.g. via https) as well as local access. Developers can register a file extension, e.g., `.loom` for dispatch from character-based URIs to specific `import()` / `export()` methods based on classes representing file types, e.g., `LoomFile()`. Fedora Account System Username: spot Koji Scratch Build (Rawhide + R 4.1.0): https://koji.fedoraproject.org/koji/taskinfo?taskID=70253405 This package is needed to update R-rtracklayer.
Everything ok. Package APPROVED. Just one detail: checks should work by adding export _R_CHECK_FORCE_SUGGESTS_=0 before the actual check, and sometimes --ignore-vignettes is also required. See e.g. https://src.fedoraproject.org/rpms/R-simmer/blob/rawhide/f/R-simmer.spec#_54 Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package have the default element marked as %%doc :doc, DESCRIPTION - Package requires R-core. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License". 16 files have unknown license. Detailed output of licensecheck in /home/iucar/fedora- review/1972915-R-BiocIO/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local R: [x]: Package contains the mandatory BuildRequires. [x]: The package has the standard %install section. ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. R: [x]: The %check macro is present [x]: Latest version is packaged. Note: Latest upstream version is 1.2.0, packaged version is 1.2.0 ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: R-BiocIO-1.2.0-1.fc35.noarch.rpm R-BiocIO-1.2.0-1.fc35.src.rpm R-BiocIO.noarch: W: spelling-error %description -l en_US https -> HTTP R-BiocIO.src: W: spelling-error %description -l en_US https -> HTTP 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- http://www.bioconductor.org/packages/release/bioc/src/contrib/BiocIO_1.2.0.tar.gz : CHECKSUM(SHA256) this package : f09625df03bbbe07ab8d7172696408bd8075e0ff2ee3db228c783a43fbb57c6a CHECKSUM(SHA256) upstream package : f09625df03bbbe07ab8d7172696408bd8075e0ff2ee3db228c783a43fbb57c6a Requires -------- R-BiocIO (rpmlib, GLIBC filtered): R(ABI) R(BiocGenerics) R(S4Vectors) R(methods) R(tools) R-core Provides -------- R-BiocIO: R(BiocIO) R-BiocIO Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1972915 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, R, Generic Disabled plugins: SugarActivity, Haskell, Python, Ocaml, Perl, Java, C/C++, fonts, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/R-BiocIO
Built in side-tag for eventual rawhide merge.