Spec URL: https://spot.fedorapeople.org/R-rjson.spec SRPM URL: https://spot.fedorapeople.org/R-rjson-0.2.20-1.fc34.src.rpm Description: Converts R object into JSON objects and vice-versa. Fedora Account System Username: spot Koji Scratch Build (Rawhide + R 4.1.0): https://koji.fedoraproject.org/koji/taskinfo?taskID=70254264 This package is a dependency of R-restfulr, which is a new dependency for R-rtracklayer.
Few issues and comments: - Please, use the following for CRAN packages: URL: https://CRAN.R-project.org/package=%{packname} Source0: %{url}&version=%{version}#/%{packname}_%{version}.tar.gz - gcc-c++ not really needed - /usr/bin/R doesn't work in the shebang line. It should be /usr/bin/Rscript - Please, use %{buildroot} instead of $RPM_BUILD_ROOT Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package have the default element marked as %%doc :doc, DESCRIPTION - Package requires R-core. ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 32 files have unknown license. Detailed output of licensecheck in /home/iucar/fedora- review/1972920-R-rjson/licensecheck.txt [-]: License file installed when any subpackage combination is installed. [-]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [!]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local R: [x]: Package contains the mandatory BuildRequires. [x]: The package has the standard %install section. ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. R: [x]: The %check macro is present [x]: Latest version is packaged. Note: Latest upstream version is 0.2.20, packaged version is 0.2.20 ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: R-rjson-0.2.20-1.fc35.x86_64.rpm R-rjson-debuginfo-0.2.20-1.fc35.x86_64.rpm R-rjson-debugsource-0.2.20-1.fc35.x86_64.rpm R-rjson-0.2.20-1.fc35.src.rpm R-rjson.x86_64: W: spelling-error %description -l en_US versa -> avers, verse, verso R-rjson.src: W: spelling-error %description -l en_US versa -> avers, verse, verso 4 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (debuginfo) ------------------- Checking: R-rjson-debuginfo-0.2.20-1.fc35.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Unversioned so-files -------------------- R-rjson: /usr/lib64/R/library/rjson/libs/rjson.so Source checksums ---------------- ftp://cran.r-project.org/pub/R/contrib/main/rjson_0.2.20.tar.gz : CHECKSUM(SHA256) this package : 3a287c1e5ee7c333ed8385913c0a307daf99335fbdf803e9dcca6e3d5adb3f6c CHECKSUM(SHA256) upstream package : 3a287c1e5ee7c333ed8385913c0a307daf99335fbdf803e9dcca6e3d5adb3f6c Requires -------- R-rjson (rpmlib, GLIBC filtered): /usr/bin/R /usr/bin/bash R(ABI) R-core libR.so()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) rtld(GNU_HASH) R-rjson-debuginfo (rpmlib, GLIBC filtered): R-rjson-debugsource (rpmlib, GLIBC filtered): Provides -------- R-rjson: R(rjson) R-rjson R-rjson(x86-64) R-rjson-debuginfo: R-rjson-debuginfo R-rjson-debuginfo(x86-64) debuginfo(build-id) R-rjson-debugsource: R-rjson-debugsource R-rjson-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1972920 Buildroot used: fedora-rawhide-x86_64 Active plugins: R, C/C++, Shell-api, Generic Disabled plugins: Java, SugarActivity, Perl, PHP, Python, fonts, Haskell, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Updated SRPM: https://spot.fedorapeople.org/R-rjson-0.2.20-2.fc34.src.rpm Updated SPEC: https://spot.fedorapeople.org/R-rjson.spec
Thanks, package APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/R-rjson
Built in side tag for eventual rawhide merge.