Spec URL: http://home.comcast.net/~ckweyl/perl-IO-Prompt.spec SRPM URL: http://home.comcast.net/~ckweyl/perl-IO-Prompt-v0.99.4-0.fc5.src.rpm Description: An object-oriented way to query for user input -- and control how that input is obtained.
Note that BuildRequires: perl is redundant, and perl(Test::More), perl(IO::Handle) and perl(POSIX) are all provided by the base Perl package. The test suite skips some tests because of missing modules; you should add BR: perl(Test::Pod), perl(Test::Pod::Coverage) for better test coverage. Review: * package meets naming and packaging guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * dist tag is present. * build root is correct. * license field matches the actual license. * license is open source-compatible. License text not included upstream. * source files match upstream: c62e369783af1f3dfe775e5d80686b61 IO-Prompt-v0.99.4.tar.gz * latest version is being packaged. * BuildRequires are proper. * package builds in mock (development, x86_64). * rpmlint is silent. * final provides and requires are sane: perl(IO::Prompt) perl(IO::Prompt::ReturnVal) perl-IO-Prompt = v0.99.4-0.fc6 = perl >= 0:5.008 perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(IO::Handle) perl(POSIX) perl(Term::ReadKey) perl(Want) perl(strict) perl(version) * no shared libraries are present. * package is not relocatable. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * %clean is present. X %check is present and all tests pass; however, some tests are skipped due to missing modules. All tests successful, 2 tests skipped. Files=3, Tests=1, 0 wallclock secs ( 0.10 cusr + 0.02 csys = 0.12 CPU) * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * no headers. * no pkgconfig files. * no libtool .la droppings. * not a GUI app.
Updated with additional buildreqs. Spec URL: http://home.comcast.net/~ckweyl/perl-IO-Prompt.spec SRPM URL: http://home.comcast.net/~ckweyl/perl-IO-Prompt-v0.99.4-0.1.fc5.src.rpm (note the "odd" release #'s are just so I can release the initial build inside extras as "-1")
The test suite now passes with no tests skipped: All tests successful. Files=3, Tests=3, 1 wallclock secs ( 0.20 cusr + 0.05 csys = 0.25 CPU) There is this warning: t/pod-coverage....Too late to run CHECK block at /builddir/build/BUILD/IO-Prompt-v0.99.4/blib/lib/IO/Prompt.pm line 315. which might be useful to report upstream. I'm not sure what it means. APPROVED
Imported and building for devel -- will build for FC-4, FC-5 after branching. CHECK issue will be reported upstream. Thanks!