Spec URL: https://raw.githubusercontent.com/damien-lemoal/fedora-packages/master/zonefs-tools/zonefs-tools.spec SRPM URL: https://raw.githubusercontent.com/damien-lemoal/fedora-packages/master/zonefs-tools/zonefs-tools-1.5.2-1.fc34.src.rpm Description: The zonefs-tools package provides the mkzonefs (mkfs.zonefs) utility to format zoned block devices for use with the zonefs file system. zonefs is part of the kernel since version 5.6 and is now enabled by default in Fedora 34 as a module. This package successfully builds with koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=70285285 I am the original author and kernel maintainer of zonefs. I am also the maintainer of the zonefs-tools project, hosted on GitHub at https://github.com/westerndigitalcorporation/zonefs-tools. Fedora Account System Username: damien-lemoal
Taking this review.
You're missing "BuildRequires: make" from your spec...
(In reply to Neal Gompa from comment #2) Neal, Thanks for the review. > You're missing "BuildRequires: make" from your spec... Fixed.
Hi Neal, Ping ? Anything else that you see needing fixes ?
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/ngompa/1973110-zonefs-tools/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 2", "[generated file]", "GNU General Public License v2.0 or later", "FSF Unlimited License (with Retention) [generated file]", "FSF Unlimited License [generated file]", "GNU General Public License v2.0 or later [generated file]", "GNU General Public License v3.0 or later", "Expat License [generated file]", "FSF Unlimited License (with Retention) GNU General Public License, Version 2", "FSF Unlimited License (with Retention)". 14 files have unknown license. Detailed output of licensecheck in /home/ngompa/1973110-zonefs- tools/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Bad spec filename: /home/ngompa/1973110-zonefs-tools/srpm- unpacked/zonefs-tools.spec See: (this test has no URL) [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Package should not use obsolete m4 macros Rpmlint ------- Checking: zonefs-tools-1.5.1-1.fc35.x86_64.rpm zonefs-tools-debuginfo-1.5.1-1.fc35.x86_64.rpm zonefs-tools-debugsource-1.5.1-1.fc35.x86_64.rpm zonefs-tools-1.5.1-1.fc35.src.rpm zonefs-tools.x86_64: W: spelling-error %description -l en_US mkfs -> mks zonefs-tools.src: W: spelling-error %description -l en_US mkzonefs -> zone's zonefs-tools.src: W: spelling-error %description -l en_US mkfs -> mks 4 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (debuginfo) ------------------- Checking: zonefs-tools-debuginfo-1.5.1-1.fc35.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/westerndigitalcorporation/zonefs-tools/archive/v1.5.1/zonefs-tools-1.5.1.tar.gz : CHECKSUM(SHA256) this package : ba6427aa3df2da7bb166f0c50ce2278af6f26bec26dedda341a0a80d9c63414b CHECKSUM(SHA256) upstream package : 7362d89ebcc63abda09821b57f729dcdad52aeb2ef192af901afd061c0b47770 diff -r also reports differences Requires -------- zonefs-tools (rpmlib, GLIBC filtered): libblkid.so.1()(64bit) libblkid.so.1(BLKID_1.0)(64bit) libblkid.so.1(BLKID_2.15)(64bit) libblkid.so.1(BLKID_2.17)(64bit) libc.so.6()(64bit) libuuid.so.1()(64bit) libuuid.so.1(UUID_1.0)(64bit) rtld(GNU_HASH) zonefs-tools-debuginfo (rpmlib, GLIBC filtered): zonefs-tools-debugsource (rpmlib, GLIBC filtered): Provides -------- zonefs-tools: zonefs-tools zonefs-tools(x86-64) zonefs-tools-debuginfo: debuginfo(build-id) zonefs-tools-debuginfo zonefs-tools-debuginfo(x86-64) zonefs-tools-debugsource: zonefs-tools-debugsource zonefs-tools-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1973110 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, C/C++, Shell-api Disabled plugins: Python, Java, R, Haskell, Perl, SugarActivity, PHP, Ocaml, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /home/ngompa/1973110-zonefs-tools/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ The sources in the SRPM don't match what I can download with spectool from the spec file. Please fix this.
(In reply to Neal Gompa from comment #6) > Issues: > ======= > - Sources used to build the package match the upstream source, as provided > in the spec URL. > Note: Upstream MD5sum check error, diff is in > /home/ngompa/1973110-zonefs-tools/diff.txt > See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ > > > The sources in the SRPM don't match what I can download with spectool from > the spec file. Please fix this. Sorry about that. I forgot to push the updated srpm. Everything should be in sync now. Thanks !
(In reply to Damien Le Moal from comment #7) > (In reply to Neal Gompa from comment #6) > > Issues: > > ======= > > - Sources used to build the package match the upstream source, as provided > > in the spec URL. > > Note: Upstream MD5sum check error, diff is in > > /home/ngompa/1973110-zonefs-tools/diff.txt > > See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ > > > > > > The sources in the SRPM don't match what I can download with spectool from > > the spec file. Please fix this. > > Sorry about that. I forgot to push the updated srpm. Everything should be in > sync now. > Thanks ! Updated again as I made the same mistake again: the spec file points to github source using a tagged version number but I had not tagged the latest changes. Hence the source code disagreement with the source rpm generated locally on my development machine. I tagged version 1.5.2 in github and updated the spec file and src rpm links accordingly. Thanks !
Then we're good to go! PACKAGE APPROVED.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/zonefs-tools