Bug 1973333 - Investigate why strings removed in English files are showing up in langauge files
Summary: Investigate why strings removed in English files are showing up in langauge f...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Management Console
Version: 4.8
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: 4.9.0
Assignee: ralpert
QA Contact: Yanping Zhang
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-06-17 16:21 UTC by ralpert
Modified: 2021-10-18 17:35 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-10-18 17:35:03 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift console pull 9393 0 None open Bug 1973333: Adjust po generation script 2021-07-01 19:22:45 UTC
Red Hat Product Errata RHSA-2021:3759 0 None None None 2021-10-18 17:35:44 UTC

Description ralpert 2021-06-17 16:21:25 UTC
Description of problem:
Some strings that have been removed from console are still showing up in translation files. For example, "Pool creation is not supported for openshift container storage external mode." is not in English, but is present in ko and ja files. We need to investigate whether this is coming from our scripts, or due to something happening on the translation side in Memsource. The fact that it's not in the zh files is odd.

Version-Release number of selected component (if applicable):
4.8

How reproducible:
Always

Steps to Reproduce:
1. Look for string "Pool creation is not supported for openshift container storage external mode."

Actual results:
It is not in the main code, but is present in ko and ja files.

Expected results:
It is not in the main code or ko/ja files.

Additional info:

Comment 1 ralpert 2021-07-01 17:42:43 UTC
I think the main export script is maintaining the old translations as it imports the new ones. I need to take a closer look and remove that behavior.

Comment 2 ralpert 2021-07-01 19:21:43 UTC
QE folks: You can test this without uploading anything to Memsource by running yarn export-pos using the code in this PR and then searching the files in frontend/po-files.

Comment 4 Yanping Zhang 2021-07-06 06:42:41 UTC
1. Get code containing the pr, in the code, run "yarn export-pos";
2. Search "Pool creation is not supported for openshift container storage external mode" in files under frontend/po-files. The result is null.
[zyp@MiWiFi-R1CM frontend]$ yarn export-pos
yarn run v1.22.10
$ ./i18n-scripts/export-pos.sh
+ source ./i18n-scripts/languages.sh
++ LANGUAGES=('ja' 'zh-cn' 'ko')
++ export LANGUAGES
+ for f in 'public/locales/en/*'
+ for i in '"${LANGUAGES[@]}"'
++ basename public/locales/en/public.json .json
+ yarn i18n-to-po -f public -l ja
$ node ./i18n-scripts/i18n-to-po.js -f public -l ja
Processed public
<--snipset-->
[zyp@MiWiFi-R1CM frontend]$ grep -nr "creation is not supported for openshif" po-files/*
[zyp@MiWiFi-R1CM frontend]$ 
I think the bug is fixed, pls correct me if the step is not suitable.

Comment 7 errata-xmlrpc 2021-10-18 17:35:03 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.9.0 bug fix and security update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:3759


Note You need to log in before you can comment on or make changes to this bug.