Bug 1973562 - seaborn is not importable
Summary: seaborn is not importable
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-seaborn
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Sergio Pascual
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1953532
TreeView+ depends on / blocked
 
Reported: 2021-06-18 07:43 UTC by Elliott Sales de Andrade
Modified: 2021-06-22 10:29 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2021-06-22 01:33:33 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Elliott Sales de Andrade 2021-06-18 07:43:23 UTC
Description of problem:
seaborn is missing a dependency on numpydoc and cannot be imported.


Version-Release number of selected component (if applicable):
python3-seaborn-0.11.1-2.fc35.noarch


Steps to Reproduce:
1. mock -r fedora-rawhide-x86_64 --install 'python3dist(seaborn)'
2. mock -r fedora-rawhide-x86_64 --shell
3. python3 -c 'import seaborn'


Actual results:
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/lib/python3.10/site-packages/seaborn/__init__.py", line 5, in <module>
    from .relational import *  # noqa: F401,F403
  File "/usr/lib/python3.10/site-packages/seaborn/relational.py", line 18, in <module>
    from .axisgrid import FacetGrid, _facet_docs
  File "/usr/lib/python3.10/site-packages/seaborn/axisgrid.py", line 17, in <module>
    from ._docstrings import (
  File "/usr/lib/python3.10/site-packages/seaborn/_docstrings.py", line 3, in <module>
    from numpydoc.docscrape import NumpyDocString
ModuleNotFoundError: No module named 'numpydoc'


Expected results:
No error on import.

Comment 1 Miro Hrončok 2021-06-21 13:30:57 UTC
This commit introduced a patch that requires numpydoc: https://src.fedoraproject.org/rpms/python-seaborn/c/7cc729bd31c1b7550d4e2d2580187f015bd7e9e0?branch=rawhide

This commit removed the requirement but kept that patch: https://src.fedoraproject.org/rpms/python-seaborn/c/9f75002c3df16343816d626da17f673e2273de08?branch=rawhide

Adding Requires: %{py3_dist numpydoc} near Requires: %{py3_dist husl} should fix this, however note that numpydoc requires entire sphinx, so not sure this is desired.

Comment 2 Sergio Pascual 2021-06-22 01:33:33 UTC
I have added Requires: %{py3_dist numpydoc}, I probably deleted it because I thought that it would be handled automatically.

https://koji.fedoraproject.org/koji/taskinfo?taskID=70585235

Comment 3 Miro Hrončok 2021-06-22 10:29:10 UTC
Note: It would be handled automatically if the patch also added the metadata about the new dependency here: https://github.com/mwaskom/seaborn/blob/v0.11.1/setup.py#L32


Note You need to log in before you can comment on or make changes to this bug.