Bug 1973702 - Review Request: golang-github-clickhouse - Golang driver for ClickHouse
Summary: Review Request: golang-github-clickhouse - Golang driver for ClickHouse
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1973695
Blocks: 1973706
TreeView+ depends on / blocked
 
Reported: 2021-06-18 14:02 UTC by Davide Cavalca
Modified: 2021-08-04 17:17 UTC (History)
2 users (show)

Fixed In Version: golang-github-clickhouse-1.4.5-2.fc35
Clone Of:
Environment:
Last Closed: 2021-08-04 17:17:24 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2021-06-18 14:02:22 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/golang-github-clickhouse/golang-github-clickhouse.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/golang-github-clickhouse/golang-github-clickhouse-1.4.5-1.fc35.src.rpm

Description:

Golang driver for ClickHouse.

Fedora Account System Username: dcavalca

Comment 1 Robert-André Mauchin 🐧 2021-06-27 13:24:11 UTC
 -  lib/lz4/LICENSE is overwritting LICENSE, you should rename it to LICENSE-lz4 in %prep. Also include BSD in the License: list and add a comment explaining the license breakdown.
lib/protocol/README.md is overwriting README.md just the same. Don't include it as it is mostly empty. 

%global golicenses      LICENSE lib/lz4/LICENSE
%global godocs          examples CONTRIBUTING.md README.md\\\
                        lib/protocol/README.md




 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.

Comment 2 Robert-André Mauchin 🐧 2021-06-27 13:25:24 UTC
> Also include BSD in the License: list and add a comment explaining the license breakdown.

Sorry you've already done that, just add the license breakdown in a comment.

Comment 3 Davide Cavalca 2021-06-27 14:36:38 UTC
Thanks!

$ fedpkg request-repo golang-github-clickhouse 1973702
https://pagure.io/releng/fedora-scm-requests/issue/35327

Comment 4 Tomas Hrcka 2021-06-28 13:29:50 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-clickhouse


Note You need to log in before you can comment on or make changes to this bug.