Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.
RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1974266

Summary: Backport pmrep archive creation fix
Product: Red Hat Enterprise Linux 8 Reporter: Marko Myllynen <myllynen>
Component: pcpAssignee: Nathan Scott <nathans>
Status: CLOSED ERRATA QA Contact: Jan Kurik <jkurik>
Severity: unspecified Docs Contact: Apurva Bhide <abhide>
Priority: unspecified    
Version: 8.5CC: agerstmayr, jkurik, mgoodwin, nathans
Target Milestone: betaKeywords: Bugfix, Triaged
Target Release: 8.5Flags: pm-rhel: mirror+
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: pcp-5.3.1-2.el8 Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-11-09 17:50:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Marko Myllynen 2021-06-21 08:51:33 UTC
Description of problem:
pmrep(1) archive creation does not work with scaled metrics, this fix is needed to avoid that issue (and ensure created archive are pmlogger(1) compatible):

https://github.com/performancecopilot/pcp/commit/3806df81a6711833cde20f014ebd29fb85013ea2

This BZ is about requesting backporting the fix for RHEL 8.5.

Thanks.

Version-Release number of selected component (if applicable):
RHEL 8.5

Comment 1 Nathan Scott 2021-06-22 00:31:53 UTC
These are the upstream commits needed here:

commit 5ed5940a25307c56ae30aaa814afd0fcdabad92d
Author: Nathan Scott <nathans>
Date:   Mon Jun 21 09:55:59 2021 +1000

    libpcp_import: fix per-instance error handling in pmiWrite

    Marko encountered a double-fault failure condition where we
    would attempt to use a prior error code in memory allocation
    size calculations of a subsequent attempt to add an instance
    value.

    New C test program added to poke the exact failure condition
    and we run it in both with/without valgrind configurations -
    so two new tests.

    Related to https://github.com/performancecopilot/pcp/issues/1327

commit 3806df81a6711833cde20f014ebd29fb85013ea2
Author: Marko Myllynen <myllynen>
Date:   Mon Jun 21 09:13:53 2021 +0300

    pmrep/pmconfig.py: fix archive writing with scaled metrics

    pmrep/pmconfig.py were already using metadata from the source to
    write archive metadata and raw values instead of counter rates.
    For scaled metrics the native type needs to be used so that created
    archives remain compatible with pmlogger created archives and that
    stored metadata and values match each other.

    QA 1072 updated to test this.

commit ac4edfb0cbef8d6618c8fbd063dc9c5727f0d085
Author: Nathan Scott <nathans>
Date:   Tue Jun 22 09:09:11 2021 +1000

    qa: correct the hex indom output in tests 1627, 1628

Comment 6 errata-xmlrpc 2021-11-09 17:50:37 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (pcp bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:4171