Fedora Account System
Red Hat Associate
Red Hat Customer
Spec URL: https://download.copr.fedorainfracloud.org/results/lbalhar/autofixup/fedora-rawhide-x86_64/02285871-git-autofixup/git-autofixup.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/lbalhar/autofixup/fedora-rawhide-x86_64/02285871-git-autofixup/git-autofixup-0.003001-1.fc35.src.rpm Description: git-autofixup parses hunks of changes in the working directory out of \ git diff output and uses git blame to assign those hunks to commits in \ <revision>..HEAD, which will typically represent a topic branch, and then \ creates fixup commits to be used with git rebase --interactive --autosquash. \ It is assumed that hunks near changes that were previously committed to \ the topic branch are related. Fedora Account System Username: lbalhar
Source0 archive (SHA-512: fd9027ee82b326a8d6552518e389551f5a0373e219d79330a64883a3d2a9405b392b286d1b1e51e8d1fdf3279c813ea1b2870803bb4c5905d064a2a7dfb9883a) is original. Ok. Summary verified from git-autofixup. Ok. Description verified from git-autofixup. Ok. License verified from git-autofixup, LICENSE, and README.pod Ok. No XS code, noarch is Ok. Build-time dependencies are Ok. All tests pass. Ok. rpmlint git-autofixup.spec review-git-autofixup/results/git-autofixup-0.003001-1.fc35.noarch.rpm review-git-autofixup/results/git-autofixup-0.003001-1.fc35.src.rpm git-autofixup.noarch: W: spelling-error Summary(en_US) fixup -> fix up, fix-up, fix git-autofixup.noarch: W: spelling-error %description -l en_US fixup -> fix up, fix-up, fix git-autofixup.noarch: W: spelling-error %description -l en_US rebase -> rebate, debase, re base git-autofixup.noarch: W: spelling-error %description -l en_US autosquash -> auto squash, auto-squash, autos quash git-autofixup.src: W: spelling-error Summary(en_US) fixup -> fix up, fix-up, fix git-autofixup.src: W: spelling-error %description -l en_US fixup -> fix up, fix-up, fix git-autofixup.src: W: spelling-error %description -l en_US rebase -> rebate, debase, re base git-autofixup.src: W: spelling-error %description -l en_US autosquash -> auto squash, auto-squash, autos quash 2 packages and 1 specfiles checked; 0 errors, 8 warnings. $ rpm -q -lv -p review-git-autofixup/results/git-autofixup-0.003001-1.fc35.noarch.rpm -rwxr-xr-x 1 root root 23402 Jun 25 18:06 /usr/bin/git-autofixup drwxr-xr-x 2 root root 0 Jun 25 18:06 /usr/share/doc/git-autofixup -rw-r--r-- 1 root root 2185 Nov 25 2020 /usr/share/doc/git-autofixup/Changes -rw-r--r-- 1 root root 6034 Nov 25 2020 /usr/share/doc/git-autofixup/README.pod drwxr-xr-x 2 root root 0 Jun 25 18:06 /usr/share/licenses/git-autofixup -rw-r--r-- 1 root root 9043 May 25 2017 /usr/share/licenses/git-autofixup/LICENSE -r--r--r-- 1 root root 3866 Jun 25 18:06 /usr/share/man/man1/git-autofixup.1.gz -r--r--r-- 1 root root 1238 Jun 25 18:06 /usr/share/man/man3/App::Git::Autofixup.3pm.gz drwxr-xr-x 2 root root 0 Jun 25 18:06 /usr/share/perl5/vendor_perl/App drwxr-xr-x 2 root root 0 Jun 25 18:06 /usr/share/perl5/vendor_perl/App/Git -r--r--r-- 1 root root 340 Nov 25 2020 /usr/share/perl5/vendor_perl/App/Git/Autofixup.pm → These perms should be 0644: -r--r--r-- 1 root root 3866 Jun 25 18:06 /usr/share/man/man1/git-autofixup.1.gz -r--r--r-- 1 root root 1238 Jun 25 18:06 /usr/share/man/man3/App::Git::Autofixup.3pm.gz -r--r--r-- 1 root root 340 Nov 25 2020 /usr/share/perl5/vendor_perl/App/Git/Autofixup.pm Use: %{_fixperms} $RPM_BUILD_ROOT/* after %make_install. No need for "chmod 755 %{buildroot}/%{_bindir}/git-autofixup" after that. - Minimal BR for perl are required: BuildRequires: perl-generators BuildRequires: perl-interpreter BuildRequires: perl(:VERSION) >= 5.8.4 - Constrain MakeMaker: BuildRequires: perl(ExtUtils::MakeMaker) >= 6.76 $ rpm -q --requires -p review-git-autofixup/results/git-autofixup-0.003001-1.fc35.noarch.rpm | sort -f | uniq -c 1 /usr/bin/perl 1 git-core 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Missing BR: BuildRequires: perl(strict) BuildRequires: perl(warnings) BuildRequires: perl(Carp) BuildRequires: perl(File::Spec) BuildRequires: perl(File::Temp) BuildRequires: perl(Getopt::Long) BuildRequires: perl(Pod::Usage) # Tests BuildRequires: perl(Cwd) BuildRequires: perl(English) BuildRequires: perl(File::Temp) BuildRequires: perl(Test::More) Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo $version)) Add them. Missing RR: 1 perl(:VERSION) >= 5.8.4 1 perl(Carp) 1 perl(File::Spec) 1 perl(File::Temp) 1 perl(Getopt::Long) 1 perl(Pod::Usage) 1 perl(strict) 1 perl(warnings) Add perl-generators to get them. $ rpm -q --provides -p review-git-autofixup2/results/git-autofixup-0.003001-1.fc35.noarch.rpm | sort -f | uniq -c 20ms fish 1 git-autofixup = 0.003001-1.fc35 Missing: 1 perl(App::Git::Autofixup) = 0.003001 Add perl-generators to get it. - %{__perl} → perl
Thanks for the review! I hope I have fixed all the issues you mentioned. Spec URL: https://download.copr.fedorainfracloud.org/results/lbalhar/autofixup/fedora-rawhide-x86_64/02304847-git-autofixup/git-autofixup.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/lbalhar/autofixup/fedora-rawhide-x86_64/02304847-git-autofixup/git-autofixup-0.003001-1.fc35.noarch.rpm
Package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/git-autofixup
FEDORA-2021-72b510bf87 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-72b510bf87
FEDORA-2021-580823f9a8 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-580823f9a8
FEDORA-2021-72b510bf87 has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-72b510bf87 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-72b510bf87 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-580823f9a8 has been pushed to the Fedora 33 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-580823f9a8 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-580823f9a8 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-580823f9a8 has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2021-72b510bf87 has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.