Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1974685 - Non-admin user can not revoke user access token, attempt ends with 404
Summary: Non-admin user can not revoke user access token, attempt ends with 404
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Users & Roles
Version: 6.10.0
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: 6.10.0
Assignee: Ondřej Ezr
QA Contact: Akhil Jha
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-06-22 10:15 UTC by Ondřej Ezr
Modified: 2021-11-16 14:12 UTC (History)
5 users (show)

Fixed In Version: foreman-2.5.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-11-16 14:12:00 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Foreman Issue Tracker 32826 0 High Closed Non-admin user can not revoke user access token, attempt ends with 404 2021-06-22 10:15:07 UTC
Github SatelliteQE robottelo pull 9030 0 None open Fix PAT tests and added new test as closeloop 2021-10-06 08:28:52 UTC
Red Hat Product Errata RHSA-2021:4702 0 None None None 2021-11-16 14:12:10 UTC

Description Ondřej Ezr 2021-06-22 10:15:03 UTC 
1. create role with Personal access token filter

and unrestricted permissions 

view_personal_access_tokens, create_personal_access_tokens, revoke_personal_access_tokens

2. assign a role to non-admin user
3. username -> my account -> personal access tokens tab
4. create a token
5. try to revoke it
Comment 1 Ondřej Ezr 2021-06-22 10:15:13 UTC 
Created from redmine issue https://projects.theforeman.org/issues/32826
Comment 2 Ondřej Ezr 2021-06-22 10:15:18 UTC 
Upstream bug assigned to oezr
Comment 4 Bryan Kearney 2021-06-22 12:05:04 UTC 
Moving this bug to POST for triage into Satellite since the upstream issue https://projects.theforeman.org/issues/32826 has been resolved.
Comment 6 Ondrej Gajdusek 2021-08-20 12:34:29 UTC 
Failed QA

@Satellite 6.10.0 snap 13
foreman-2.5.2.4-1.el7sat.noarch
satellite-6.10.0-0.6.beta.el7sat.noarch

Following the exact same steps from the reproducer, being logged in as a non-admin user, a token gets created, but I am getting "Could not revoke Token: Error: Request failed with status code 404".

==> /var/log/foreman/production.log <==
2021-08-20T07:34:34 [I|app|72b590ea] Started DELETE "/api/v2/users/15-read_user/personal_access_tokens/6" for 10.34.131.179 at 2021-08-20 07:34:34 -0400
2021-08-20T07:34:34 [I|app|72b590ea] Processing by Api::V2::PersonalAccessTokensController#destroy as JSON
2021-08-20T07:34:34 [I|app|72b590ea]   Parameters: {"apiv"=>"v2", "user_id"=>"15-read_user", "id"=>"6"}
2021-08-20T07:34:34 [I|app|72b590ea] ActiveRecord::RecordNotFound (ActiveRecord::RecordNotFound)
2021-08-20T07:34:34 [I|app|72b590ea]   Rendering api/v2/errors/not_found.json.rabl within api/v2/layouts/error_layout
2021-08-20T07:34:34 [I|app|72b590ea]   Rendered api/v2/errors/not_found.json.rabl within api/v2/layouts/error_layout (Duration: 8.1ms | Allocations: 7539)
2021-08-20T07:34:34 [I|app|72b590ea] Completed 404 Not Found in 98ms (Views: 13.3ms | ActiveRecord: 11.5ms | Allocations: 39797)

Non-admin user is not able to list the existing tokens if he goes off the page and opens the Edit user page again. BZ1996048 filed for this issue.

If I add `view_users` permission to the non-admin user, using hammer (API) as the non-admin user, I can see the tokens listed:
# hammer user access-token list --user read_user --search "name = fdsf"
---|------|--------|-----------
ID | NAME | ACTIVE | EXPIRES AT
---|------|--------|-----------
3  | fdsf | yes    |           
---|------|--------|-----------
# hammer user access-token revoke --user read_user --id 3
Could not revoke personal access token:
  Resource personal_access_token not found by id '3'


The non-admin user having the `edit_users` permission assigned is able to revoke the token:
# hammer user access-token revoke --user read_user --id 3
Personal access token [fdsf] revoked.

However, adding `edit_users` allows non-admin users to edit the admin's username for example. This makes the Personal Access Tokens feature unusable in environments where they care about security or strictly enforce RBAC.
Comment 10 Akhil Jha 2021-10-04 05:58:14 UTC 
Verified.
Satellite 6.10.0-21.0
Comment 13 errata-xmlrpc 2021-11-16 14:12:00 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: Satellite 6.10 Release), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:4702
Note You need to log in before you can comment on or make changes to this bug.