Description of problem: The command allows executing arbitrary shell commands while viewing a file by entering '!' followed by the command. Entering a command that contains a '%', '!', or '\' causes a segmentation violation. Version-Release number of selected component (if applicable): 2.36.1-1 How reproducible: 100% Steps to Reproduce: 1. Execute the 'more' command on an arbitrary text file 2. Enter '!!' or '!%' or '!\' (without the quotes) 3. Actual results: Segmentation violation Expected results: Error message complaining about no such command, etc Additional info: Apparently the [%!\] character can appear anywhere in the command string, so you get the same result (SIGSEGV) with '!ls%'. The origin of this is a branch in the run_shell() function when a call to strpbrk(cmdbuf, "%!\\") returns non-zero because one of those characters is in the command string. This triggers a call to the expand() function. One of the first things expand() does is call strlen(ctl->shell_line), but at this point ctl->shell_line is still NULL. Ooops. Since this code could never have worked, I imagine that somewhere along the line there was a change that removed initialization of ctl->shell_line, but there's no indication in the change log. Could this have been in there since the beginning of time?
Good catch. Thanks! Fixed by upstream commit https://github.com/karelzak/util-linux/commit/86f05d3946193c447bc8f9120d7046f92da54209, the change will be available in v2.37.1
This message is a reminder that Fedora 33 is nearing its end of life. Fedora will stop maintaining and issuing updates for Fedora 33 on 2021-11-30. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At that time this bug will be closed as EOL if it remains open with a Fedora 'version' of '33'. Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, simply change the 'version' to a later Fedora version. Thank you for reporting this issue and we are sorry that we were not able to fix it before Fedora 33 is end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged change the 'version' to a later Fedora version prior this bug is closed as described in the policy above. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete.
Fedora 33 changed to end-of-life (EOL) status on 2021-11-30. Fedora 33 is no longer maintained, which means that it will not receive any further security or bug fix updates. As a result we are closing this bug. If you can reproduce this bug against a currently maintained version of Fedora please feel free to reopen this bug against that version. If you are unable to reopen this bug, please file a new report against the current release. If you experience problems, please add a comment to this bug. Thank you for reporting this bug and we are sorry it could not be fixed.