Bug 1976005 - No swap on RHVH 4.4.6
Summary: No swap on RHVH 4.4.6
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: redhat-virtualization-host
Version: 4.4.6
Hardware: x86_64
OS: Linux
high
medium
Target Milestone: ovirt-4.4.7
: 4.4.7
Assignee: Lev Veyde
QA Contact: cshao
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-06-24 23:33 UTC by Germano Veit Michel
Modified: 2021-07-22 15:08 UTC (History)
14 users (show)

Fixed In Version: RHVH-4.4-20210705.2-RHVH-x86_64-dvd1.iso
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-07-22 15:07:11 UTC
oVirt Team: Node
Target Upstream Version:
Embargoed:
cshao: testing_plan_complete+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github rhinstaller anaconda pull 3474 0 None open Revert "ovirt / rhv: drop swap partition" 2021-06-28 18:52:22 UTC
Red Hat Knowledge Base (Solution) 6138772 0 None None None 2021-06-25 03:39:29 UTC
Red Hat Product Errata RHSA-2021:2736 0 None None None 2021-07-22 15:08:55 UTC
oVirt gerrit 115457 0 None NEW Revert "anaconda: drop swap" 2021-06-28 18:45:12 UTC
oVirt gerrit 115458 0 None MERGED Revert "anaconda: drop swap" 2021-06-28 18:46:11 UTC

Description Germano Veit Michel 2021-06-24 23:33:36 UTC
I'm not sure if this is an intended change, but fresh installs with RHVH 4.4.6 produce a layout without swap space.

RHVH 4.4.5
==========
- anaconda 33.16.3.26-1.el8

[root@host2 ~]# lvs
  LV                          VG   Attr       LSize  Pool   Origin                    Data%  Meta%  Move Log Cpy%Sync Convert
  home                        rhvh Vwi-aotz--  1.00g pool00                           1.04                                   
  pool00                      rhvh twi-aotz-- 55.23g                                  5.40   1.81                            
  rhvh-4.4.5.4-0.20210330.0   rhvh Vwi---tz-k 28.23g pool00 root                                                             
  rhvh-4.4.5.4-0.20210330.0+1 rhvh Vwi-aotz-- 28.23g pool00 rhvh-4.4.5.4-0.20210330.0 9.04                                   
  root                        rhvh Vri---tz-k 28.23g pool00                                                                  
  swap                        rhvh -wi-ao----  7.90g                                               <----------- missing on RHV 4.4.6 below                                                                        
  tmp                         rhvh Vwi-aotz--  1.00g pool00                           1.11                                   
  var                         rhvh Vwi-aotz-- 15.00g pool00                           2.00                                   
  var_crash                   rhvh Vwi-aotz-- 10.00g pool00                           0.11                                   
  var_log                     rhvh Vwi-aotz--  8.00g pool00                           0.19                                   
  var_log_audit               rhvh Vwi-aotz--  2.00g pool00                           0.52
                                   
[root@host2 ~]# free -m
              total        used        free      shared  buff/cache   available
Mem:           7962         294        7245           8         422        7406
Swap:          8091           0        8091

RHVH 4.4.6
==========
- anaconda 33.16.4.15-1.el8

[root@host3 ~]# lvs
  LV                          VG   Attr       LSize  Pool   Origin                    Data%  Meta%  Move Log Cpy%Sync Convert
  home                        rhvh Vwi-aotz--  1.00g pool00                           1.04                                   
  pool00                      rhvh twi-aotz-- 47.10g                                  6.36   1.82                            
  rhvh-4.4.6.2-0.20210615.0   rhvh Vwi---tz-k 10.10g pool00 root                                                             
  rhvh-4.4.6.2-0.20210615.0+1 rhvh Vwi-aotz-- 10.10g pool00 rhvh-4.4.6.2-0.20210615.0 26.57                                  
  root                        rhvh Vri---tz-k 10.10g pool00                                                                  
  tmp                         rhvh Vwi-aotz--  1.00g pool00                           1.08                                   
  var                         rhvh Vwi-aotz-- 15.00g pool00                           1.23                                   
  var_crash                   rhvh Vwi-aotz-- 10.00g pool00                           0.11                                   
  var_log                     rhvh Vwi-aotz--  8.00g pool00                           0.20                                   
  var_log_audit               rhvh Vwi-aotz--  2.00g pool00                           0.53
                                   
[root@host3 ~]# free -m
              total        used        free      shared  buff/cache   available
Mem:           7960         254        7283           8         422        7449
Swap:             0           0           0

From the logs, we can see that on RHVH 4.4.6 anaconda's swap_is_recommended is set to False, while its True on 4.4.5:

4.4.5/storage.log:2620:DEBUG:anaconda.modules.storage.partitioning.validate:Storage check started with constraints {'min_ram': Size (410 MiB), 'root_device_types': {5}, 'min_partition_sizes': {'/': Size (250 MiB), '/usr': Size (250 MiB), '/tmp': Size (50 MiB), '/var': Size (384 MiB), '/home': Size (100 MiB), '/boot': Size (200 MiB)}, 'req_partition_sizes': {'/var': Size (10 GiB), '/boot': Size (1024 MiB)}, 'must_be_on_linuxfs': {'/usr', '/', '/usr/lib', '/usr/share', '/home', '/tmp', '/var'}, 'must_be_on_root': {'/mnt', '/sbin', '/dev', '/etc', 'lost+found', '/proc', '/bin', '/lib', '/root'}, 'must_not_be_on_root': {'/var'}, 'reformat_whitelist': {'/usr', '/var', '/tmp', '/boot'}, 'reformat_blacklist': {'/usr/local', '/home', '/var/www', '/opt'}, 'swap_is_recommended': True, 'luks2_min_ram': Size (128 MiB)}.

4.4.6/storage.log:2702:DEBUG:anaconda.modules.storage.partitioning.validate:Storage check started with constraints {'min_ram': Size (410 MiB), 'root_device_types': {5}, 'min_partition_sizes': {'/': Size (250 MiB), '/usr': Size (250 MiB), '/tmp': Size (50 MiB), '/var': Size (384 MiB), '/home': Size (100 MiB), '/boot': Size (200 MiB)}, 'req_partition_sizes': {'/var': Size (10 GiB), '/boot': Size (1024 MiB)}, 'must_be_on_linuxfs': {'/usr/share', '/usr/lib', '/', '/var', '/usr', '/home', '/tmp'}, 'must_be_on_root': {'/mnt', '/bin', '/dev', '/etc', '/lib', 'lost+found', '/proc', '/sbin', '/root'}, 'must_not_be_on_root': {'/var'}, 'reformat_whitelist': {'/tmp', '/usr', '/var', '/boot'}, 'reformat_blacklist': {'/home', '/opt', '/usr/local', '/var/www'}, 'swap_is_recommended': False, 'luks2_min_ram': Size (128 MiB)}
                                                                                                                                   
Tracked it down to this, its uncommented in 4.4.6.

4.4.6: 
======
[anaconda root@localhost /]# grep swap_is_recommended /etc/anaconda/product.d/rhvh.conf
swap_is_recommended = False

4.4.5:
====== 
[anaconda root@localhost /]# grep swap_is_recommended /etc/anaconda/product.d/rhvh.conf
#swap_is_recommended = False

Can't find anything about it on the release notes or a BZ that tracked this change.
https://access.redhat.com/documentation/en-us/red_hat_virtualization/4.4/html/release_notes/red_hat_virtualization_4_4_batch_update_5_ovirt_4_4_6

Comment 1 cshao 2021-06-25 02:01:33 UTC
QE can reproduce this issue on 4.4.6.

# imgbase w 
You are on rhvh-4.4.6.2-0.20210615.0+1

# lvs
  LV                          VG                  Attr       LSize   Pool   Origin                    Data%  Meta%  Move Log Cpy%Sync Convert
  home                        rhvh_hp-bl460cg9-01 Vwi-aotz--   1.00g pool00                           1.83                                   
  pool00                      rhvh_hp-bl460cg9-01 twi-aotz-- 178.00g                                  1.98   1.90                            
  rhvh-4.4.6.2-0.20210615.0   rhvh_hp-bl460cg9-01 Vwi---tz-k 141.00g pool00 root                                                             
  rhvh-4.4.6.2-0.20210615.0+1 rhvh_hp-bl460cg9-01 Vwi-aotz-- 141.00g pool00 rhvh-4.4.6.2-0.20210615.0 1.95                                   
  root                        rhvh_hp-bl460cg9-01 Vri---tz-k 141.00g pool00                                                                  
  tmp                         rhvh_hp-bl460cg9-01 Vwi-aotz--   1.00g pool00                           1.87                                   
  var                         rhvh_hp-bl460cg9-01 Vwi-aotz--  15.00g pool00                           3.05                                   
  var_crash                   rhvh_hp-bl460cg9-01 Vwi-aotz--  10.00g pool00                           0.21                                   
  var_log                     rhvh_hp-bl460cg9-01 Vwi-aotz--   8.00g pool00                           0.65                                   
  var_log_audit               rhvh_hp-bl460cg9-01 Vwi-aotz--   2.00g pool00                           0.98                                   

# free -m
              total        used        free      shared  buff/cache   available
Mem:         128522         931      127027          20         563      126693
Swap:             0           0           0

Comment 6 Michal Skrivanek 2021-06-28 12:19:07 UTC
we should follow the same rule regarding swap size as in <=4.4.5. We do need swap to cover for memory overcommit pressure

Comment 9 cshao 2021-07-06 03:53:17 UTC
Test version:
rhvh-4.4.7.2-0.20210705.0+1

# imgbase w 
You are on rhvh-4.4.7.2-0.20210705.0+1

# lvs
  LV                          VG   Attr       LSize   Pool   Origin                    Data%  Meta%  Move Log Cpy%Sync Convert
  home                        rhvh Vwi-aotz--   1.00g pool00                           1.83                                   
  pool00                      rhvh twi-aotz-- 174.01g                                  2.01   1.84                            
  rhvh-4.4.7.2-0.20210705.0   rhvh Vwi---tz-k 137.01g pool00 root                                                             
  rhvh-4.4.7.2-0.20210705.0+1 rhvh Vwi-aotz-- 137.01g pool00 rhvh-4.4.7.2-0.20210705.0 2.01                                   
  root                        rhvh Vri---tz-k 137.01g pool00                                                                  
  swap                        rhvh -wi-ao----   4.00g                                                                         
  tmp                         rhvh Vwi-aotz--   1.00g pool00                           2.16                                   
  var                         rhvh Vwi-aotz--  15.00g pool00                           3.14                                   
  var_crash                   rhvh Vwi-aotz--  10.00g pool00                           0.21                                   
  var_log                     rhvh Vwi-aotz--   8.00g pool00                           0.52                                   
  var_log_audit               rhvh Vwi-aotz--   2.00g pool00          

Swap partition is correct, so the bug is fixed, change bug status to VERIFIED.

Comment 13 errata-xmlrpc 2021-07-22 15:07:11 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Important: Red Hat Virtualization Host security and bug fix update [ovirt-4.4.7]), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:2736


Note You need to log in before you can comment on or make changes to this bug.