Spec URL: https://people.freedesktop.org/~whot/rpms/wireplumber.spec SRPM URL: https://people.freedesktop.org/~whot/rpms/wireplumber-0.4.0-1.fc34.src.rpm Description: WirePlumber is a modular session/policy manager for PipeWire and a GObject-based high-level library that wraps PipeWire's API, providing convenience for writing the daemon's modules as well as external tools for managing PipeWire. Fedora Account System Username: whot Note that due to upstream incompatibilities, lua 5.3 is currently bundled, I understand this will need an exception, meanwhile I've added the appropriate Provides: bundled(lua) = 5.3.6 line.
Taking this review.
Should perhaps Provides: pipewire-session-manager
Should PipeWire have more than one installed at a time? If not, it should be Provides+Conflicts.
New SRPM URL (version change upstream to 0.4.1): Spec URL: https://people.freedesktop.org/~whot/rpms/wireplumber.spec SRPM URL: https://people.freedesktop.org/~whot/rpms/wireplumber-0.4.1-1.fc34.src.rpm Changes to above: - 0.4.1 no longer requires lua 5.3 so we can use the system lua now. celebratory emoticon here. - Provides: pipewire-session-manager added - Conflicts: pipewire-media-session added (obv. the pipewire spec file needs the same once wireplumber exists) > Should PipeWire have more than one installed at a time? If not, it should be Provides+Conflicts. No, only one, I've added the conflicts line now, thanks. Also: this package will need to be managed through the systemd presets, see Bug 1976006 for the discussion on how to best handle this.
> %{_sysconfdir}/wireplumber/* This needs to be enumerated and marked as "%config(noreplace)"
> %{_prefix}/lib/systemd/user/wireplumber.service > %{_prefix}/lib/systemd/user/wireplumber@.service Replace "%{_prefix}/lib/systemd/user" with "%{_userunitdir}"
> Provides: pipewire-session-manager > Conflicts: pipewire-media-session This doesn't do what we want. This should be: Provides: pipewire-session-manager Conflicts: pipewire-session-manager And that should also be added to the pipewire-session-manager package.
I've added the necessary Conflicts to pipewire-media-session: https://src.fedoraproject.org/rpms/pipewire/c/3d3f0022fde763c88bc9f8dadaeb43f9104e8a84
(In reply to Neal Gompa from comment #7) > > Provides: pipewire-session-manager > > Conflicts: pipewire-media-session > > This doesn't do what we want. This should be: > > Provides: pipewire-session-manager > Conflicts: pipewire-session-manager > > And that should also be added to the pipewire-session-manager package. Oops, I meant "pipewire-media-session" package, which I did in Comment 8.
Thanks for all the comments, didn't know the provides+conflicts could work that way without conflicting itself :) > This needs to be enumerated and marked as "%config(noreplace)" > Replace "%{_prefix}/lib/systemd/user" with "%{_userunitdir}" > This should be: > Provides: pipewire-session-manager > Conflicts: pipewire-session-manager All the above are done now, at the same URLs: Spec URL: https://people.freedesktop.org/~whot/rpms/wireplumber.spec SRPM URL: https://people.freedesktop.org/~whot/rpms/wireplumber-0.4.1-1.fc34.src.rpm
> %config(noreplace) %{_sysconfdir}/wireplumber/bluetooth.lua.d > %config(noreplace) %{_sysconfdir}/wireplumber/common > %config(noreplace) %{_sysconfdir}/wireplumber/main.lua.d > %config(noreplace) %{_sysconfdir}/wireplumber/policy.lua.d These should be "%dir" instead of "%config(noreplace)". As a general comment, why are these in /etc instead of in /usr/share? Ideally, these should be installed in /usr and only admin overrides exist in /etc.
> These should be "%dir" instead of "%config(noreplace)". oops, sorry. fixed, same URLS. > As a general comment, why are these in /etc instead of in /usr/share? Ideally, these should be installed in /usr and only admin overrides exist in /etc. working on it upstream, but it's a bit entangled with pipewire and there's only so much I can do in a day ;) I'm hoping this should be fixed soon enough that it's not an issue.
> %{_datadir}/wireplumber/* Take the asterisk off, because the asterisk makes it so RPM doesn't own "%{_datadir}/wireplumber". The slash alone is sufficient for recursive ownership.
> BuildRequires: systemd Do you actually need this for anything?
> Take the asterisk off, because the asterisk makes it so RPM doesn't own "%{_datadir}/wireplumber". The slash alone is sufficient for recursive ownership. I'm assuming the same applies to %{_includedir}/wireplumber-0.4/* and I've fixed them both, thanks. > Do you actually need this for anything? yep, wireplumber uses systemd.pc to determine whether (and where) to install the systemd service files.
(In reply to Peter Hutterer from comment #15) > > Take the asterisk off, because the asterisk makes it so RPM doesn't own "%{_datadir}/wireplumber". The slash alone is sufficient for recursive ownership. > > I'm assuming the same applies to > %{_includedir}/wireplumber-0.4/* > and I've fixed them both, thanks. > Yep, thanks! :) > > Do you actually need this for anything? > > yep, wireplumber uses systemd.pc to determine whether (and where) to install > the systemd service files. You should consider converting any build dependencies that are located by Meson via pkgconfig to use pkgconfig() names instead of their package names. That way you'll always get them, even if they change package names.
> %{_libdir}/wireplumber-0.4/libwireplumber-*.so You need a "%dir %{_libdir}/wireplumber-0.4" entry here.
> %{_libdir}/wireplumber-0.4/libwireplumber-*.so > %{_libdir}/libwireplumber-0.4.so.* > %{_libdir}/girepository-1.0/Wp-0.4.typelib These should all be in a libs subpackage, similar to how it was done for pipewire itself. That makes the WirePlumber libraries safe for multi-lib, which may be needed with multi-lib PipeWire too.
> You should consider converting any build dependencies that are located by Meson via pkgconfig to use pkgconfig() names instead of their package names. That way you'll always get them, even if they change package names. true, though in this case: wireplumber wants *a lot* of .pc files which are effectively all provided by glib2-devel and gobject-introspection-devel. Switching to pkgconfig means either only checking separately for all of those, making the spec file harder to maintain, or just some of those knowing that they're in the same package anyway. Both option are IMO worse than requiring the package name directly. Only systemd and lua-devel could meaningfully be switched to the pkgconfig check here without any drawbacks. > These should all be in a libs subpackage, similar to how it was done for pipewire itself. That makes the WirePlumber libraries safe for multi-lib, which may be needed with multi-lib PipeWire too. Done, same URLs.
The devel package needs to depend on the libs package now. :)
(In reply to Peter Hutterer from comment #19) > > You should consider converting any build dependencies that are located by Meson via pkgconfig to use pkgconfig() names instead of their package names. That way you'll always get them, even if they change package names. > > true, though in this case: wireplumber wants *a lot* of .pc files which are > effectively all provided by glib2-devel and gobject-introspection-devel. > Switching to pkgconfig means either only checking separately for all of > those, making the spec file harder to maintain, or just some of those > knowing that they're in the same package anyway. Both option are IMO worse > than requiring the package name directly. Only systemd and lua-devel could > meaningfully be switched to the pkgconfig check here without any drawbacks. That's an interesting argument. The way I tend to look at it is that by having the information in sync with what Meson is actually looking for, it's less likely to fail in the future if things get reorganized.
> The devel package needs to depend on the libs package now. :) ♫ 99 issues with the review request ♩ ♪ 99 things to change ♬ ♬ fix them all, submit it again ♪ ♩ 99 issues with the review request ♫ Done, same sources. > That's an interesting argument. The way I tend to look at it is that by having the information in sync with what Meson is actually looking for, it's less likely to fail in the future if things get reorganized. Yeah, I generally agree (I think most of my other packages now use pkgconfig) but here it's clunky. glib has a lot of .pc files so we need to check for 4 of those. pipewire has 2. but gobject-introspection-devel is still the package because WP checks for a binary, not the .pc file. So it's all a bit messy, IMO. But that's not a hill I'm willing to engage windmills in aggressive conduct on, so I've changed it to pkgconfig now.
(In reply to Peter Hutterer from comment #22) > > The devel package needs to depend on the libs package now. :) > > ♫ 99 issues with the review request ♩ > ♪ 99 things to change ♬ > ♬ fix them all, submit it again ♪ > ♩ 99 issues with the review request ♫ > It almost feels like a song could be made out of this, but I promise the wait is nearly over! :) > Done, same sources. > > > That's an interesting argument. The way I tend to look at it is that by having the information in sync with what Meson is actually looking for, it's less likely to fail in the future if things get reorganized. > > Yeah, I generally agree (I think most of my other packages now use > pkgconfig) but here it's clunky. glib has a lot of .pc files so we need to > check for 4 of those. pipewire has 2. but gobject-introspection-devel is > still the package because WP checks for a binary, not the .pc file. So it's > all a bit messy, IMO. But that's not a hill I'm willing to engage windmills > in aggressive conduct on, so I've changed it to pkgconfig now. No worries, I wasn't going to force it either. But I'm glad it's changed. :)
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /etc/wireplumber [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/girepository-1.0, /usr/share/gir-1.0, /usr/lib/systemd, /etc/wireplumber, /usr/lib/systemd/user [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: wireplumber-0.4.1-1.fc35.x86_64.rpm wireplumber-libs-0.4.1-1.fc35.x86_64.rpm wireplumber-devel-0.4.1-1.fc35.x86_64.rpm wireplumber-debuginfo-0.4.1-1.fc35.x86_64.rpm wireplumber-debugsource-0.4.1-1.fc35.x86_64.rpm wireplumber-0.4.1-1.fc35.src.rpm wireplumber.x86_64: W: no-documentation wireplumber.x86_64: W: no-manual-page-for-binary wireplumber wireplumber.x86_64: W: no-manual-page-for-binary wpctl wireplumber.x86_64: W: no-manual-page-for-binary wpexec wireplumber-libs.x86_64: W: no-documentation wireplumber-devel.x86_64: W: no-documentation wireplumber.src:23: W: unversioned-explicit-provides pipewire-session-manager 6 packages and 0 specfiles checked; 0 errors, 7 warnings. Rpmlint (debuginfo) ------------------- Checking: wireplumber-libs-debuginfo-0.4.1-1.fc35.x86_64.rpm wireplumber-debuginfo-0.4.1-1.fc35.x86_64.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Unversioned so-files -------------------- wireplumber-libs: /usr/lib64/wireplumber-0.4/libwireplumber-module-default-nodes-api.so wireplumber-libs: /usr/lib64/wireplumber-0.4/libwireplumber-module-default-nodes.so wireplumber-libs: /usr/lib64/wireplumber-0.4/libwireplumber-module-default-profile.so wireplumber-libs: /usr/lib64/wireplumber-0.4/libwireplumber-module-device-activation.so wireplumber-libs: /usr/lib64/wireplumber-0.4/libwireplumber-module-lua-scripting.so wireplumber-libs: /usr/lib64/wireplumber-0.4/libwireplumber-module-metadata.so wireplumber-libs: /usr/lib64/wireplumber-0.4/libwireplumber-module-mixer-api.so wireplumber-libs: /usr/lib64/wireplumber-0.4/libwireplumber-module-portal-permissionstore.so wireplumber-libs: /usr/lib64/wireplumber-0.4/libwireplumber-module-reserve-device.so wireplumber-libs: /usr/lib64/wireplumber-0.4/libwireplumber-module-si-audio-adapter.so wireplumber-libs: /usr/lib64/wireplumber-0.4/libwireplumber-module-si-audio-endpoint.so wireplumber-libs: /usr/lib64/wireplumber-0.4/libwireplumber-module-si-node.so wireplumber-libs: /usr/lib64/wireplumber-0.4/libwireplumber-module-si-standard-link.so Source checksums ---------------- https://gitlab.freedesktop.org/pipewire/wireplumber/-/archive/0.4.1/wireplumber-0.4.1.tar.bz2 : CHECKSUM(SHA256) this package : bc6e2c357ceea21bdc88dbe79f78730eb71c32df3a9a5ede91858ff2ddf0a93f CHECKSUM(SHA256) upstream package : bc6e2c357ceea21bdc88dbe79f78730eb71c32df3a9a5ede91858ff2ddf0a93f Requires -------- wireplumber (rpmlib, GLIBC filtered): /bin/sh config(wireplumber) glibc libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libpipewire-0.3.so.0()(64bit) libwireplumber-0.4.so.0()(64bit) rtld(GNU_HASH) wireplumber-libs (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) liblua-5.4.so()(64bit) libm.so.6()(64bit) libpipewire-0.3.so.0()(64bit) libwireplumber-0.4.so.0()(64bit) rtld(GNU_HASH) wireplumber-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libwireplumber-0.4.so.0()(64bit) pkgconfig(gio-2.0) pkgconfig(gmodule-2.0) pkgconfig(gobject-2.0) pkgconfig(libpipewire-0.3) wireplumber(x86-64) wireplumber-libs(x86-64) wireplumber-debuginfo (rpmlib, GLIBC filtered): wireplumber-debugsource (rpmlib, GLIBC filtered): Provides -------- wireplumber: config(wireplumber) pipewire-session-manager wireplumber wireplumber(x86-64) wireplumber-libs: libwireplumber-0.4.so.0()(64bit) libwireplumber-module-default-nodes-api.so()(64bit) libwireplumber-module-default-nodes.so()(64bit) libwireplumber-module-default-profile.so()(64bit) libwireplumber-module-device-activation.so()(64bit) libwireplumber-module-lua-scripting.so()(64bit) libwireplumber-module-metadata.so()(64bit) libwireplumber-module-mixer-api.so()(64bit) libwireplumber-module-portal-permissionstore.so()(64bit) libwireplumber-module-reserve-device.so()(64bit) libwireplumber-module-si-audio-adapter.so()(64bit) libwireplumber-module-si-audio-endpoint.so()(64bit) libwireplumber-module-si-node.so()(64bit) libwireplumber-module-si-standard-link.so()(64bit) wireplumber-libs wireplumber-libs(x86-64) wireplumber-devel: pkgconfig(wireplumber-0.4) wireplumber-devel wireplumber-devel(x86-64) wireplumber-debuginfo: debuginfo(build-id) wireplumber-debuginfo wireplumber-debuginfo(x86-64) wireplumber-debugsource: wireplumber-debugsource wireplumber-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1976012 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: fonts, Ocaml, PHP, Java, SugarActivity, Python, Perl, Haskell, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Review notes: > [!]: Package requires other packages for directories it uses. > Note: No known owner of /etc/wireplumber Rather than making you go through this again, I'll just say that you can fix it on import. > [x]: Package must own all directories that it creates. > Note: Directories without known owners: /usr/lib64/girepository-1.0, > /usr/share/gir-1.0, /usr/lib/systemd, /etc/wireplumber, > /usr/lib/systemd/user False positives, meh.
So, as long as you declare "%dir %{_sysconfdir}/wireplumber" in the subpackage that directory is included in when you import into Fedora, then... PACKAGE APPROVED! 🎉
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/wireplumber
wireplumber-0.4.1-1.fc35 is now available in rawhide. celebrations are acceptable. Thanks for your patience Neal.