Bug 1976380 - Review Request: rust-beef - More compact Cow
Summary: Review Request: rust-beef - More compact Cow
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-06-25 21:59 UTC by Davide Cavalca
Modified: 2021-08-04 17:06 UTC (History)
2 users (show)

Fixed In Version: rust-beef-0.5.1-1.fc35
Clone Of:
Environment:
Last Closed: 2021-08-04 17:06:52 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2021-06-25 21:59:09 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/rust-beef/rust-beef.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/rust-beef/rust-beef-0.5.0-1.fc35.src.rpm

Description:
More compact Cow.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2021-06-25 21:59:11 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=70820845

Comment 2 Fabio Valentini 2021-06-28 17:45:02 UTC
Package generated with rust2rpm, simplifying the review:

- package builds and installs without errors on rawhide
- latest version is packaged
- patches are justified and linked to upstream PRs
- license is correct, acceptable, and included as %license
- test suite is run and all tests pass (unless otherwise justified)

PACKAGE APPROVED.

Minor issue:
Please exclude the "ci" directory from installed files, like this:
https://src.fedoraproject.org/rpms/rust-criterion/blob/rawhide/f/rust-criterion.spec#_47

Or even better, suggest upstream that they could use an "exclude = ["ci"]" directive in their Cargo.toml file, since those files are useless in published crates and for downstream users.

Comment 3 Davide Cavalca 2021-06-28 17:49:10 UTC
Thanks!

$ fedpkg request-repo rust-beef 1976380
https://pagure.io/releng/fedora-scm-requests/issue/35388

Comment 4 Gwyn Ciesla 2021-06-28 18:05:33 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-beef


Note You need to log in before you can comment on or make changes to this bug.