Bug 197640 - Mesa isn't getting built with optimizations
Summary: Mesa isn't getting built with optimizations
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: mesa
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mike A. Harris
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2006-07-05 07:09 UTC by Nicholas Miell
Modified: 2007-11-30 22:11 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2006-07-21 20:52:11 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
fix OPT_FLAGS usage (1020 bytes, patch)
2006-07-05 07:20 UTC, Nicholas Miell
no flags Details | Diff

Description Nicholas Miell 2006-07-05 07:09:30 UTC
I've opened this bug as instructed in
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=193979#c3

The spec changes to pass RPM_OPT_FLAGS in to the Mesa build via OPT_FLAGS aren't
sufficient -- the linux, linux-dri, and linux-dri-ppc Makefile fragments clobber
the OPT_FLAGS variable in a fashion similar to the already-fixed ARCH_FLAGS.

The OPT_FLAGS assignments in those files needs to be changed to a conditional
assignment or an appending assignment, depending on what you think it should do.
(Probably a conditional assignment, the PPC config selects a specific -mtune
option and I'm not sure how gcc will react to multiple conflicting -mtune options.)

Comment 1 Nicholas Miell 2006-07-05 07:20:22 UTC
Created attachment 131914 [details]
fix OPT_FLAGS usage

stick this in as Patch2, or just combine it with Patch0 and Patch1 into a new
all-devouring superpatch

Comment 2 Mike A. Harris 2006-07-05 08:36:44 UTC
Looks right to me.  Applied to -13.fc6 along with a fix to the problem you
mentioned in IRC (before getting timed out):

<DrNick> woo! /usr/lib64/dri got the wrong perms

* Wed Jul 05 2006 Mike A. Harris <mharris> 6.5-13.fc6
- Added mesa-6.5-fix-opt-flags-bug197640.patch as 2nd attempt to fix OPT_FLAGS
  for (#197640).
- Ensure that redhat-mesa-driver-install creates $DRIMODULE_DESTDIR with
  mode 0755.


Comment 3 Mike A. Harris 2006-07-05 08:45:47 UTC
Unfortunately, due to bug #195980 I am unable to build the newly fixed
mesa package, however I will build it once releng has rectified the
problem with the buildsystem.

Comment 4 Mike A. Harris 2006-07-21 20:52:11 UTC
Built this a long time ago.  Current is mesa-6.5-13.1.fc6


Note You need to log in before you can comment on or make changes to this bug.