Bug 1976529 - Review Request: rust-cfg-expr - parser and evaluator for Rust `cfg()` expressions
Summary: Review Request: rust-cfg-expr - parser and evaluator for Rust `cfg()` express...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2021-06-26 23:56 UTC by Rémi Lauzier
Modified: 2021-07-27 01:04 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-07-27 01:04:05 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Comment 1 Robert-André Mauchin 🐧 2021-07-10 15:48:03 UTC
 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Tests pass
 - Conforms to Packaging Guidelines

Package approved.

Comment 2 Gwyn Ciesla 2021-07-10 18:46:55 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-cfg-expr

Comment 3 Fedora Update System 2021-07-10 20:23:52 UTC
FEDORA-2021-1d4128d580 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-1d4128d580

Comment 4 Fedora Update System 2021-07-11 01:49:15 UTC
FEDORA-2021-1d4128d580 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-1d4128d580 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-1d4128d580

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 5 Fabio Valentini 2021-07-12 13:42:04 UTC
eclipseo, could you please check that all packages *install* as well as build during package reviews?
I'm not sure if fedora-review is broken, but it should definitely put those installability issues into the full report output.

https://bugzilla.redhat.com/show_bug.cgi?id=1981348

Comment 6 Rémi Lauzier 2021-07-12 15:46:49 UTC
It seems that fedora tools don't see optional dependency. It has been a few package that act like that maybe something is wrong with the tools.

Comment 7 Robert-André Mauchin 🐧 2021-07-12 17:19:30 UTC
I have:

DEBUG util.py:444:  Error: 
DEBUG util.py:444:   Problem 1: conflicting requests
DEBUG util.py:444:    - nothing provides (crate(target-lexicon/default) >= 0.11.2 with crate(target-lexicon/default) < 0.12.0~) needed by rust-cfg-expr+targets-devel-0.7.4-1.fc35.noarch
DEBUG util.py:444:   Problem 2: conflicting requests
DEBUG util.py:444:    - nothing provides (crate(target-lexicon/default) >= 0.11.2 with crate(target-lexicon/default) < 0.12.0~) needed by rust-cfg-expr+target-lexicon-devel-0.7.4-1.fc35.noarch
DEBUG util.py:446:  (try to add '--skip-broken' to skip uninstallable packages or '--nobest' to use not only best candidate packages)

But that doesn't matter since it's optional right?

Comment 8 Fedora Update System 2021-07-13 01:02:09 UTC
FEDORA-2021-bf6f7763bf has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-bf6f7763bf`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-bf6f7763bf

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fabio Valentini 2021-07-13 11:54:20 UTC
> It seems that fedora tools don't see optional dependency. It has been a few package that act like that maybe something is wrong with the tools.

fedora-review *should* complain if any of the built packages have unsatisfiable dependencies. If it doesn't, then that's a bug in fedora-review, and please report it here: https://pagure.io/FedoraReview

> But that doesn't matter since it's optional right?

It clearly *does* matter, or you wouldn't get a bug report for it. All package dependencies MUST be satisfiable from Fedora repositories, even "weak" dependencies (Recommends + Suggests) - though I don't remember which policy covers this.

In this case, the broken dependency is only not a problem so long as no dependent package uses the "target" feature of this package.

Possible solutions would be to either drop the "target" feature temporarily (if really nothing uses it), or to bump the dependency from 0.11.2 to 0.12.0, which is what's available in Fedora (assuming the package is compatible with the newer version, test this with a build with "--all-features", or run all cargo macros with the "-a" flag to test this).

PS: I try to run "mock ./*.src.rpm --postinstall" to check for unsatisfiable dependencies of any built packages. It's very convenient.

Comment 10 Fedora Update System 2021-07-17 01:07:39 UTC
FEDORA-2021-f56e15b9c2 has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-f56e15b9c2`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-f56e15b9c2

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2021-07-19 00:59:51 UTC
FEDORA-2021-0e6205558c has been pushed to the Fedora 34 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-0e6205558c`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-0e6205558c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Update System 2021-07-27 01:04:05 UTC
FEDORA-2021-0e6205558c has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.