Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qt6ct.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/qt6ct-0.3-1.fc34.src.rpm Description: This program allows users to configure Qt6 settings (theme, font, icons, etc.) under DE/WM without Qt integration. Fedora Account System Username: martinkg rpmlint -i -v qt6ct.spec /home/martin/rpmbuild/SRPMS/qt6ct-0.3-1.fc34.src.rpm /home/martin/rpmbuild/RPMS/x86_64/qt6ct-debugsource-0.3-1.fc34.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/qt6ct-0.3-1.fc34.x86_64.rpm /home/martin/rpmbuild/RPMS/x86_64/qt6ct-debuginfo-0.3-1.fc34.x86_64.rpm qt6ct.spec: I: checking qt6ct.spec: I: checking-url https://github.com/trialuser02/qt6ct/archive/0.3.tar.gz#/qt6ct-0.3.tar.gz (timeout 10 seconds) qt6ct.src: I: checking qt6ct.src: I: checking-url https://github.com/trialuser02/qt6ct (timeout 10 seconds) qt6ct.src: I: checking-url https://github.com/trialuser02/qt6ct/archive/0.3.tar.gz#/qt6ct-0.3.tar.gz (timeout 10 seconds) qt6ct-debugsource.x86_64: I: checking qt6ct-debugsource.x86_64: I: checking-url https://github.com/trialuser02/qt6ct (timeout 10 seconds) qt6ct.x86_64: I: checking qt6ct.x86_64: I: checking-url https://github.com/trialuser02/qt6ct (timeout 10 seconds) qt6ct.x86_64: W: no-manual-page-for-binary qt6ct Each executable in standard binary directories should have a man page. qt6ct-debuginfo.x86_64: I: checking qt6ct-debuginfo.x86_64: I: checking-url https://github.com/trialuser02/qt6ct (timeout 10 seconds) 4 packages and 1 specfiles checked; 0 errors, 1 warnings. %changelog * Thu Jul 01 2021 Martin Gansser <martinkg> - 0.3-1 - Update to 0.3 * Mon Feb 08 2021 Martin Gansser <martinkg> - 0.2-1 - initial Build
I should note that I'm a new contributor awaiting sponsorship into the package maintainers group, but this looks good to me! There are no obvious issues with this, though I am adding the contributor who will eventually be sponsoring me (Ankur Sinha) to the discussion for further input. Fedora Review output: ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 2-clause "Simplified" License". 99 files have unknown license. Detailed output of licensecheck in /home/arkstarta/Public/FedReviews/review-qt6ct/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/qt6ct/colors, /usr/share/qt6ct, /usr/share/qt6ct/qss [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/qt6ct/colors, /usr/share/qt6ct/qss, /usr/share/qt6ct [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/qt6/plugins/platformthemes(qt6-qtbase) [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 3 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. Note: Multiple Release: tags found [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM.
Thanks niohiani, There are quite a few [ ] (blank) checks. Have you done these? If not, please do these too, and if you have, please mark them in the review template to indicate so. I'll leave you to continue the review (and only step in if necessary :)). Cheers,
Sorry about that Ankur! I'll dig into this a bit more and make sure those blank sections are actually not required.
No worries :) If you have any doubts/queries please feel free to e-mail me. (I'm on vacation all of next week, though, so I may not be very responsive). Cheers, Ankur
After more carefully reviewing the N/A categories, I have only observed the following issue to be present: - Problem: No known owner of /usr/share/qt6ct/colors, /usr/share/qt6ct, /usr/share/qt6ct/qss -- Solution: Ensure the package owns said directories via listing them under %files in your .spec To a new contributor, this looks good to go. Will eMail Ankur for a more discerning pair of eyes.
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qt6ct.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/qt6ct-0.4-1.fc34.src.rpm %changelog * Wed Aug 11 2021 Martin Gansser <martinkg> - 0.4-1 - Update to 0.4 - Fix unowned directories
The review of your most recent package leads me to believe that this is ready for approval. If I could approve it myself, I would. I will update Ankur and hopefully this can be moved through the pipeline soon. --- Output below: This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [ ]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD (2 clause)". 99 files have unknown license. Detailed output of licensecheck in Public/FedReviews/review-qt6ct/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/qt6/plugins/platformthemes(qt6-qtbase) [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 3 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. Note: Multiple Release: tags found [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: qt6ct-0.4-1.fc35.x86_64.rpm qt6ct-debuginfo-0.4-1.fc35.x86_64.rpm qt6ct-debugsource-0.4-1.fc35.x86_64.rpm qt6ct-0.4-1.fc35.src.rpm qt6ct.x86_64: W: no-manual-page-for-binary qt6ct 4 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (debuginfo) ------------------- Checking: qt6ct-debuginfo-0.4-1.fc35.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Unversioned so-files -------------------- qt6ct: /usr/lib64/qt6/plugins/platformthemes/libqt6ct.so qt6ct: /usr/lib64/qt6/plugins/styles/libqt6ct-style.so Source checksums ---------------- https://github.com/trialuser02/qt6ct/archive/0.4.tar.gz#/qt6ct-0.4.tar.gz : CHECKSUM(SHA256) this package : 5ab7fd4ebe8db83ef49187c34f13e40035434db6c0c3b2b17c1fcd608112d106 CHECKSUM(SHA256) upstream package : 5ab7fd4ebe8db83ef49187c34f13e40035434db6c0c3b2b17c1fcd608112d106 Requires -------- qt6ct (rpmlib, GLIBC filtered): libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.1)(64bit) libQt6Gui.so.6()(64bit) libQt6Gui.so.6(Qt_6)(64bit) libQt6Gui.so.6(Qt_6_PRIVATE_API)(64bit) libQt6Widgets.so.6()(64bit) libQt6Widgets.so.6(Qt_6)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.13)(64bit) libstdc++.so.6(CXXABI_1.3.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) qt6-qtsvg rtld(GNU_HASH) qt6ct-debuginfo (rpmlib, GLIBC filtered): qt6ct-debugsource (rpmlib, GLIBC filtered): Provides -------- qt6ct: application() application(qt6ct.desktop) libqt6ct-style.so()(64bit) libqt6ct.so()(64bit) qt6ct qt6ct(x86-64) qt6ct-debuginfo: debuginfo(build-id) libqt6ct-style.so-0.4-1.fc35.x86_64.debug()(64bit) libqt6ct.so-0.4-1.fc35.x86_64.debug()(64bit) qt6ct-debuginfo qt6ct-debuginfo(x86-64) qt6ct-debugsource: qt6ct-debugsource qt6ct-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -u https://bugzilla.redhat.com/show_bug.cgi?id=1978188#c6 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: Haskell, Perl, R, PHP, fonts, SugarActivity, Python, Ocaml, Java Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
You are in the package maintainers group and can approve reviews now. https://fedoraproject.org/wiki/Package_Review_Process#Reviewer For completeness, please do address each item in the checklist.
Alright thanks Ankur! In regard to the items which can only be manually reviewed, these all pass or are N/A: [✓]: Package does not contain kernel modules. [✓]: Package contains no static executables. [✓]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [✓]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [✓]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD (2 clause)". 99 files have unknown license. Detailed output of licensecheck in Public/FedReviews/review-qt6ct/licensecheck.txt [✓]: License file installed when any subpackage combination is installed. [✓]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [✓]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib64/qt6/plugins/platformthemes(qt6-qtbase) [✓]: %build honors applicable compiler flags or justifies otherwise. [✓]: Package contains no bundled libraries without FPC exception. [✓]: Changelog in prescribed format. [✓]: Sources contain only permissible code or content. [✓]: Development files must be in a -devel package [✓]: Package uses nothing in %doc for runtime. [✓]: Package consistently uses macros (instead of hard-coded directory names). [✓]: Package is named according to the Package Naming Guidelines. [✓]: Package does not generate any conflict. [✓]: Package obeys FHS, except libexecdir and /usr/target. [✓]: If the package is a rename of another package, proper Obsoletes and Provides are present. [✓]: Requires correct, justified where necessary. [✓]: Spec file is legible and written in American English. [✓]: Package contains systemd file(s) if in need. [✓]: Useful -debuginfo package or justification otherwise. [✓]: Package is not known to require an ExcludeArch tag. [✓]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [✓]: Package complies to the Packaging Guidelines [✓]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [✓]: Final provides and requires are sane (see attachments). [✓]: Package functions as described. [✓]: Latest version is packaged. [✓]: Package does not include license text files separate from upstream. [✓]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [✓]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [✓]: Package should compile and build into binary rpms on all supported architectures. [✓]: %check is present and all tests pass. [✓]: Packages should try to preserve timestamps of original installed files. I'm going to approve this. Godspeed!
Thanks, for the review.
niohiani, normaly you have to take the ticket, on the top of the ticket, klick "take it" Assignee: Nobody's working on this, feel free to take it
I just stumbled across the review and noticed missing desktop-file-install or desktop-file-validate when desktop file is installed [1]. It is mandatory and mentioned already in comment #7. Not yet fixed. niohiani, you have granted review+, which is fine. But Martin needs to continue with "fedpkg request-repo qt6ct 1978188" command to request repository created. Such requests are always denied until you as a reviewer take the bug and change status to ASSIGNED. Without it he cannot continue even with your flag given. Please finish you review and take the bug. Except missing desktop file validation, you have made review well and can and should back your decision and assign your name to it. Do not be afraid and assign the bug to yourself. I would insist on desktop-file-validate first however. 1. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_file_install_usage
Thanks so much for all of the info folks! Much appreciated. Still getting to know the ropes, and meatworld responsibilities as of late have likely been contributing to my overlooking some of the requisite actions. No better ways to learn than through direct feedback and examples IMHO, so very much appreciated. MartinKG, please modify your spec file to include the following in-between the %install and %files sections: %check desktop-file-validate %{buildroot}%{_datadir}/applications/%{name}.desktop Once you have done so, you will need to be sponsored to the packagers group, and then follow the steps delineated here: https://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Add_Package_to_Source_Code_Management_.28SCM.29_system_and_Set_Owner
(In reply to niohiani from comment #13) > MartinKG, please modify your spec file to include the following in-between > the %install and %files sections: > %check > desktop-file-validate %{buildroot}%{_datadir}/applications/%{name}.desktop > done Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/qt6ct.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/qt6ct-0.4-2.fc34.src.rpm %changelog * Sat Aug 28 2021 Martin Gansser <martinkg> - 0.4-2 - Add missing desktop file validation - Add BR desktop-file-utils
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/qt6ct
Thanks for the review. Packages successfully build for rawhide, fc35 and fc34.
Congrats! This was my first package approval, so apologies again for missing some steps. Glad you got things rolling.