Spec URL: https://dcavalca.fedorapeople.org/review/libobjc2/libobjc2.spec SRPM URL: https://dcavalca.fedorapeople.org/review/libobjc2/libobjc2-2.1-1.fc35.src.rpm Description: The GNUstep Objective-C runtime is designed as a drop-in replacement for the GCC runtime. It supports both a legacy and a modern ABI, allowing code compiled with old versions of GCC to be supported without requiring recompilation. The modern ABI adds the following features: * Non-fragile instance variables. * Protocol uniquing. * Object planes support. * Declared property introspection. Both ABIs support the following feature above and beyond the GCC runtime: * The modern Objective-C runtime APIs, introduced with OS X 10.5. * Blocks (closures). * Low memory profile for platforms where memory usage is more important than speed. * Synthesised property accessors. * Efficient support for @synchronized() * Type-dependent dispatch, eliminating stack corruption from mismatched selectors. * Support for the associated reference APIs introduced with Mac OS X 10.6. * Support for the automatic reference counting APIs introduced with Mac OS X 10. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=71220652
This is based on https://github.com/trunkmaster/nextspace/blob/448b9e8e1bba4b814ffed33200f6cae3564a516f/Libraries/libobjc2/libobjc2.spec Note that I'm renaming an include to avoid a conflict with libdispatch-devel. A better way to handle this would probably be some kind of alternatives system so that one could pick the include they want.
> Source: %{url}/archive/v%{version}.tar.gz Please adjust this to "%{url}/archive/v%{version}/%{name}-%{version}.tar.gz"
Spec URL: https://dcavalca.fedorapeople.org/review/libobjc2/libobjc2.spec SRPM URL: https://dcavalca.fedorapeople.org/review/libobjc2/libobjc2-2.1-2.fc35.src.rpm Changelog: - Update source URL
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License". 175 files have unknown license. Detailed output of licensecheck in /home/ngompa/1978847-libobjc2/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: libobjc2-2.1-2.fc35.x86_64.rpm libobjc2-devel-2.1-2.fc35.x86_64.rpm libobjc2-debuginfo-2.1-2.fc35.x86_64.rpm libobjc2-debugsource-2.1-2.fc35.x86_64.rpm libobjc2-2.1-2.fc35.src.rpm libobjc2.x86_64: W: spelling-error %description -l en_US uniquing -> inquiring, gunning libobjc2.x86_64: W: spelling-error %description -l en_US accessors -> accessory, accessorizes, accessorize libobjc2-devel.x86_64: W: no-documentation libobjc2.src: W: spelling-error %description -l en_US uniquing -> inquiring, gunning libobjc2.src: W: spelling-error %description -l en_US accessors -> accessory, accessorizes, accessorize 5 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (debuginfo) ------------------- Checking: libobjc2-debuginfo-2.1-2.fc35.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/gnustep/libobjc2/archive/v2.1/libobjc2-2.1.tar.gz : CHECKSUM(SHA256) this package : 78fc3711db14bf863040ae98f7bdca08f41623ebeaf7efaea7dd49a38b5f054c CHECKSUM(SHA256) upstream package : 78fc3711db14bf863040ae98f7bdca08f41623ebeaf7efaea7dd49a38b5f054c Requires -------- libobjc2 (rpmlib, GLIBC filtered): glibc ld-linux-x86-64.so.2()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) libobjc2-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libobjc.so.4.6()(64bit) libobjc2(x86-64) libobjc2-debuginfo (rpmlib, GLIBC filtered): libobjc2-debugsource (rpmlib, GLIBC filtered): Provides -------- libobjc2: libobjc.so.4.6()(64bit) libobjc2 libobjc2(x86-64) libobjc2-devel: libobjc2-devel libobjc2-devel(x86-64) pkgconfig(libobjc) libobjc2-debuginfo: debuginfo(build-id) libobjc.so.4.6-2.1-2.fc35.x86_64.debug()(64bit) libobjc2-debuginfo libobjc2-debuginfo(x86-64) libobjc2-debugsource: libobjc2-debugsource libobjc2-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1978847 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: SugarActivity, Python, Haskell, Ocaml, Java, fonts, R, PHP, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Everything looks good, so... PACKAGE APPROVED.
$ fedpkg request-repo libobjc2 1978847 https://pagure.io/releng/fedora-scm-requests/issue/35466
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libobjc2