Spec URL: https://olem.fedorapeople.org/reviews/rust-just.spec SRPM URL: https://olem.fedorapeople.org/reviews/rust-just-0.9.6-1.fc34.src.rpm Description: just is a handy way to save and run project-specific commands. Fedora Account System Username: olem
Tests are disabled because they depend on internal unpublished crate. I wonder if I should instead try to convince upstream to publish the test crate.
Thank you for packaging this! (In reply to Olivier Lemasle from comment #1) > Tests are disabled because they depend on internal unpublished crate. I > wonder if I should instead try to convince upstream to publish the test > crate. What error are you getting when you try to run the tests? Is the crate in question the `test-utilities` crate?
Hi casey "upstream" :-) Yes, I'm referring to the `test-utilities` crate. As Fedora rust packages are built from the crate source (as downloaded from crates.io), running tests in the Fedora build process requires the availability of the dev-dependencies, hence having `test-utilities` itself published on crates.io.
(or the inclusion of the test utilities into the main `just` crate, to make it self-contained)
(In reply to Olivier Lemasle from comment #3) > Hi casey "upstream" :-) ^_^ > Yes, I'm referring to the `test-utilities` crate. > > As Fedora rust packages are built from the crate source (as downloaded from > crates.io), running tests in the Fedora build process requires the > availability of the dev-dependencies, hence having `test-utilities` itself > published on crates.io. > > (or the inclusion of the test utilities into the main `just` crate, to make > it self-contained) Makes sense! I had actually already published most of `test-utilities` to a crate called `temptree` on crates.io, so removing the rest of it was pretty easy. I just published `just` 0.9.7 which no longer contains `test-utilities`: https://crates.io/crates/just/versions
Thanks Casey! Package updated: Spec URL: https://olem.fedorapeople.org/reviews/rust-just.spec SRPM URL: https://olem.fedorapeople.org/reviews/rust-just-0.9.8-1.fc34.src.rpm Changelog: * Sun Jul 04 09:45:37 CEST 2021 Olivier Lemasle <o.lemasle> - 0.9.8-1 - Update to upstream 0.9.8; enable tests - Add shell completions
- Bump to 0.9.7 - License ok - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved.
- License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved.
Thanks for the review(s) Robert-André! https://pagure.io/releng/fedora-scm-requests/issue/35477
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-just
FEDORA-2021-fefc5d8b35 has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-fefc5d8b35
FEDORA-2021-2b211e977d has been submitted as an update to Fedora 34. https://bodhi.fedoraproject.org/updates/FEDORA-2021-2b211e977d
FEDORA-2021-2b211e977d has been pushed to the Fedora 34 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2021-2b211e977d \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-2b211e977d See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2021-2b211e977d has been pushed to the Fedora 34 stable repository. If problem still persists, please make note of it in this bug report.