Bug 1979009
| Summary: | Change log message about EFI not being supported in assisted-installer | ||
|---|---|---|---|
| Product: | OpenShift Container Platform | Reporter: | Osher De Paz <odepaz> |
| Component: | assisted-installer | Assignee: | Sagi Dayan <sdayan> |
| assisted-installer sub component: | Installer | QA Contact: | Udi Kalifon <ukalifon> |
| Status: | CLOSED ERRATA | Docs Contact: | |
| Severity: | low | ||
| Priority: | unspecified | CC: | aos-bugs, sdayan, ukalifon |
| Version: | 4.9 | Keywords: | Triaged |
| Target Milestone: | --- | ||
| Target Release: | 4.9.0 | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | AI-Team-Core | ||
| Fixed In Version: | OCP-Metal-v1.0.23.1 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-10-18 17:38:01 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Osher De Paz
2021-07-04 08:57:36 UTC
Also log of the test command is super confusing (failed executing nsenter...) Verified. The log shows: level=info msg="Install complete.\n" level=info msg="Done writing image to disk" level=info msg="Setting efibootmgr to boot from disk" @ukalifon shouldn't we see the new message "Setting boot order on efi is not supported. Skipping..."? It's not what we see, but the old misleading message is gone. Do you think that the new message we see is wrong? It looks like it succeeded to set the boot order (in our environments the boot order is already set correctly so it doesn't need to do anything). I think your environment is not EFI boot mode, making you skip this specific message. Showing the code will probably explain better what's happening: https://github.com/openshift/assisted-installer/blob/master/src/ops/ops.go#L222-L229 As you can see, your environment shows "Setting efibootmgr to boot from disk" Re-opening the bug. I tested on an EFI system, and I got the correct log message.
In the case of BIOS systems - the message should still be fixed:
func (o *ops) SetBootOrder(device string) error {
_, err := o.ExecPrivilegeCommand(nil, "test", "-d", "/sys/firmware/efi")
if err != nil {
o.log.Info("Setting boot order on efi is not supported. Skipping...") // FIX "EFI" TO "BIOS" !!!!
return nil
}
...
Note in the above code that if we got err != nil it should be interpreted as this being a BIOS system, so the message should say that "setting the boot order on BIOS systems is not supported". We actually do support efi - with the efibootmgr tool.
This needs to be tested on non-EFI machines, and we need to make sure that the logged message is not confusing.
right sorry @sdayan, I just missed the more problematic aspect about this message so we need to do this change as well @ Sure thing - Will fix this today. Verified. I tested on a BIOS system (VMs) and got this in installer.logs: Jul 28 11:01:24 master-0-1 installer[5804]: time="2021-07-28T11:01:24Z" level=info msg="setting the boot order on BIOS systems is not supported. Skipping..." Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (Moderate: OpenShift Container Platform 4.9.0 bug fix and security update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2021:3759 |